diff options
author | David Woodhouse <dwmw2@shinybook.infradead.org> | 2005-06-02 07:13:21 -0400 |
---|---|---|
committer | David Woodhouse <dwmw2@shinybook.infradead.org> | 2005-06-02 07:13:21 -0400 |
commit | 4bcff1b37e7c3aed914d1ce5b45994adc7dbf455 (patch) | |
tree | 0ab25e1679752cd6feaba64e7c7a495afc9d6a28 | |
parent | 8f37d47c9bf74cb48692691086b482e315d07f40 (diff) |
AUDIT: Fix user pointer deref thinko in sys_socketcall().
I cunningly put the audit call immediately after the
copy_from_user().... but used the _userspace_ copy of the args still.
Let's not do that.
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
-rw-r--r-- | net/socket.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/socket.c b/net/socket.c index 6b7c3b51a7c1..38729af09461 100644 --- a/net/socket.c +++ b/net/socket.c | |||
@@ -1908,7 +1908,7 @@ asmlinkage long sys_socketcall(int call, unsigned long __user *args) | |||
1908 | if (copy_from_user(a, args, nargs[call])) | 1908 | if (copy_from_user(a, args, nargs[call])) |
1909 | return -EFAULT; | 1909 | return -EFAULT; |
1910 | 1910 | ||
1911 | err = audit_socketcall(nargs[call]/sizeof(unsigned long), args); | 1911 | err = audit_socketcall(nargs[call]/sizeof(unsigned long), a); |
1912 | if (err) | 1912 | if (err) |
1913 | return err; | 1913 | return err; |
1914 | 1914 | ||