diff options
author | Stephen Hemminger <shemminger@osdl.org> | 2005-09-08 15:57:43 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2005-09-08 15:57:43 -0400 |
commit | 42ca89c18b75e1c4c3b02aa5589ad3aa916909a8 (patch) | |
tree | a3052c4ffdfa8451a182c49837a92054f5688672 | |
parent | e50ef933e649a2b43aa10c8a60c491543b8b4c02 (diff) |
[IPV6]: Need to use pskb_trim_rcsum().
Fix pskb_trim usage in ipv6. Only the udp one is really
a bug, other places are just doing equivalent code.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/ipv6/exthdrs.c | 9 | ||||
-rw-r--r-- | net/ipv6/reassembly.c | 9 | ||||
-rw-r--r-- | net/ipv6/udp.c | 2 |
3 files changed, 8 insertions, 12 deletions
diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c index 5be6da2584ee..3b9fa900a4bf 100644 --- a/net/ipv6/exthdrs.c +++ b/net/ipv6/exthdrs.c | |||
@@ -459,11 +459,10 @@ static int ipv6_hop_jumbo(struct sk_buff *skb, int optoff) | |||
459 | IP6_INC_STATS_BH(IPSTATS_MIB_INTRUNCATEDPKTS); | 459 | IP6_INC_STATS_BH(IPSTATS_MIB_INTRUNCATEDPKTS); |
460 | goto drop; | 460 | goto drop; |
461 | } | 461 | } |
462 | if (pkt_len + sizeof(struct ipv6hdr) < skb->len) { | 462 | |
463 | __pskb_trim(skb, pkt_len + sizeof(struct ipv6hdr)); | 463 | if (pskb_trim_rcsum(skb, pkt_len + sizeof(struct ipv6hdr))) |
464 | if (skb->ip_summed == CHECKSUM_HW) | 464 | goto drop; |
465 | skb->ip_summed = CHECKSUM_NONE; | 465 | |
466 | } | ||
467 | return 1; | 466 | return 1; |
468 | 467 | ||
469 | drop: | 468 | drop: |
diff --git a/net/ipv6/reassembly.c b/net/ipv6/reassembly.c index 9d9e04344c77..e4fe9ee484dd 100644 --- a/net/ipv6/reassembly.c +++ b/net/ipv6/reassembly.c | |||
@@ -479,12 +479,9 @@ static void ip6_frag_queue(struct frag_queue *fq, struct sk_buff *skb, | |||
479 | /* Point into the IP datagram 'data' part. */ | 479 | /* Point into the IP datagram 'data' part. */ |
480 | if (!pskb_pull(skb, (u8 *) (fhdr + 1) - skb->data)) | 480 | if (!pskb_pull(skb, (u8 *) (fhdr + 1) - skb->data)) |
481 | goto err; | 481 | goto err; |
482 | if (end-offset < skb->len) { | 482 | |
483 | if (pskb_trim(skb, end - offset)) | 483 | if (pskb_trim_rcsum(skb, end - offset)) |
484 | goto err; | 484 | goto err; |
485 | if (skb->ip_summed != CHECKSUM_UNNECESSARY) | ||
486 | skb->ip_summed = CHECKSUM_NONE; | ||
487 | } | ||
488 | 485 | ||
489 | /* Find out which fragments are in front and at the back of us | 486 | /* Find out which fragments are in front and at the back of us |
490 | * in the chain of fragments so far. We must know where to put | 487 | * in the chain of fragments so far. We must know where to put |
diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c index 390d750449ce..7cbcaa30cf5e 100644 --- a/net/ipv6/udp.c +++ b/net/ipv6/udp.c | |||
@@ -483,7 +483,7 @@ static int udpv6_rcv(struct sk_buff **pskb, unsigned int *nhoffp) | |||
483 | } | 483 | } |
484 | 484 | ||
485 | if (ulen < skb->len) { | 485 | if (ulen < skb->len) { |
486 | if (__pskb_trim(skb, ulen)) | 486 | if (pskb_trim_rcsum(skb, ulen)) |
487 | goto discard; | 487 | goto discard; |
488 | saddr = &skb->nh.ipv6h->saddr; | 488 | saddr = &skb->nh.ipv6h->saddr; |
489 | daddr = &skb->nh.ipv6h->daddr; | 489 | daddr = &skb->nh.ipv6h->daddr; |