diff options
author | Sedat Dilek <sedat.dilek@googlemail.com> | 2011-03-08 16:39:24 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2011-03-09 04:25:45 -0500 |
commit | 2ae9d293b14d17f35eff624272cfecac7979a2ee (patch) | |
tree | 29ca6c4dd88832784a0be89bc7dffb77b84b51f3 | |
parent | 1c4badbdeae53d2584bb5395a062cfebed76696e (diff) |
x86: Fix binutils-2.21 symbol related build failures
New binutils version 2.21.0.20110302-1 started checking that the symbol
parameter to the .size directive matches the entry name's
symbol parameter, unearthing two mismatches:
AS arch/x86/kernel/acpi/wakeup_rm.o
arch/x86/kernel/acpi/wakeup_rm.S: Assembler messages:
arch/x86/kernel/acpi/wakeup_rm.S:12: Error: .size expression with symbol `wakeup_code_start' does not evaluate to a constant
arch/x86/kernel/entry_32.S: Assembler messages:
arch/x86/kernel/entry_32.S:1421: Error: .size expression with
symbol `apf_page_fault' does not evaluate to a constant
The problem was discovered while using Debian's binutils
(2.21.0.20110302-1) and experimenting with binutils from
upstream.
Thanks Alexander and H.J. for the vital help.
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
Cc: Alexander van Heukelum <heukelum@fastmail.fm>
Cc: H.J. Lu <hjl.tools@gmail.com>
Cc: Len Brown <len.brown@intel.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Rafael J. Wysocki <rjw@sisk.pl>
LKML-Reference: <1299620364-21644-1-git-send-email-sedat.dilek@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r-- | arch/x86/kernel/acpi/wakeup_rm.S | 2 | ||||
-rw-r--r-- | arch/x86/kernel/entry_32.S | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/arch/x86/kernel/acpi/wakeup_rm.S b/arch/x86/kernel/acpi/wakeup_rm.S index 6ce81ee9cb03..63b8ab524f2c 100644 --- a/arch/x86/kernel/acpi/wakeup_rm.S +++ b/arch/x86/kernel/acpi/wakeup_rm.S | |||
@@ -9,4 +9,4 @@ | |||
9 | .globl acpi_wakeup_code | 9 | .globl acpi_wakeup_code |
10 | acpi_wakeup_code: | 10 | acpi_wakeup_code: |
11 | .incbin "arch/x86/kernel/acpi/realmode/wakeup.bin" | 11 | .incbin "arch/x86/kernel/acpi/realmode/wakeup.bin" |
12 | .size wakeup_code_start, .-wakeup_code_start | 12 | .size acpi_wakeup_code, .-acpi_wakeup_code |
diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S index c8b4efad7ebb..9ca3b0e343e5 100644 --- a/arch/x86/kernel/entry_32.S +++ b/arch/x86/kernel/entry_32.S | |||
@@ -1413,7 +1413,7 @@ ENTRY(async_page_fault) | |||
1413 | CFI_ADJUST_CFA_OFFSET 4 | 1413 | CFI_ADJUST_CFA_OFFSET 4 |
1414 | jmp error_code | 1414 | jmp error_code |
1415 | CFI_ENDPROC | 1415 | CFI_ENDPROC |
1416 | END(apf_page_fault) | 1416 | END(async_page_fault) |
1417 | #endif | 1417 | #endif |
1418 | 1418 | ||
1419 | /* | 1419 | /* |