diff options
author | Dave Kleikamp <shaggy@linux.vnet.ibm.com> | 2007-06-13 11:17:50 -0400 |
---|---|---|
committer | Dave Kleikamp <shaggy@linux.vnet.ibm.com> | 2007-06-13 11:17:50 -0400 |
commit | 288e4d838d1e999c0515f85a337cacb2be233071 (patch) | |
tree | 45b7a24ccc679310c28b1edbb2633c1739d50afc | |
parent | 209e101bf408a50acc426e32c8252daefacde5b0 (diff) |
JFS: Update print_hex_dump() syntax
Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
-rw-r--r-- | fs/jfs/jfs_imap.c | 4 | ||||
-rw-r--r-- | fs/jfs/jfs_logmgr.c | 26 | ||||
-rw-r--r-- | fs/jfs/jfs_metapage.c | 4 | ||||
-rw-r--r-- | fs/jfs/jfs_txnmgr.c | 19 | ||||
-rw-r--r-- | fs/jfs/xattr.c | 4 |
5 files changed, 28 insertions, 29 deletions
diff --git a/fs/jfs/jfs_imap.c b/fs/jfs/jfs_imap.c index 19da0e17e4de..3870ba8b9086 100644 --- a/fs/jfs/jfs_imap.c +++ b/fs/jfs/jfs_imap.c | |||
@@ -890,8 +890,8 @@ int diFree(struct inode *ip) | |||
890 | * the map. | 890 | * the map. |
891 | */ | 891 | */ |
892 | if (iagno >= imap->im_nextiag) { | 892 | if (iagno >= imap->im_nextiag) { |
893 | printk(KERN_ERR "Dump of imap:\n"); | 893 | print_hex_dump(KERN_ERR, "imap: ", DUMP_PREFIX_ADDRESS, 16, 4, |
894 | print_hex_dump(KERN_ERR, DUMP_PREFIX_ADDRESS, imap, 32); | 894 | imap, 32, 0); |
895 | jfs_error(ip->i_sb, | 895 | jfs_error(ip->i_sb, |
896 | "diFree: inum = %d, iagno = %d, nextiag = %d", | 896 | "diFree: inum = %d, iagno = %d, nextiag = %d", |
897 | (uint) inum, iagno, imap->im_nextiag); | 897 | (uint) inum, iagno, imap->im_nextiag); |
diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c index 2917ede90d67..de3e4a506dbc 100644 --- a/fs/jfs/jfs_logmgr.c +++ b/fs/jfs/jfs_logmgr.c | |||
@@ -1626,22 +1626,22 @@ void jfs_flush_journal(struct jfs_log *log, int wait) | |||
1626 | list_for_each_entry(lp, &log->synclist, synclist) { | 1626 | list_for_each_entry(lp, &log->synclist, synclist) { |
1627 | if (lp->xflag & COMMIT_PAGE) { | 1627 | if (lp->xflag & COMMIT_PAGE) { |
1628 | struct metapage *mp = (struct metapage *)lp; | 1628 | struct metapage *mp = (struct metapage *)lp; |
1629 | printk (KERN_ERR "orphan metapage:\n"); | 1629 | print_hex_dump(KERN_ERR, "metapage: ", |
1630 | print_hex_dump(KERN_ERR, DUMP_PREFIX_ADDRESS, | 1630 | DUMP_PREFIX_ADDRESS, 16, 4, |
1631 | lp, sizeof(struct metapage)); | 1631 | mp, sizeof(struct metapage), 0); |
1632 | printk (KERN_ERR "page:\n"); | 1632 | print_hex_dump(KERN_ERR, "page: ", |
1633 | print_hex_dump(KERN_ERR, DUMP_PREFIX_ADDRESS, | 1633 | DUMP_PREFIX_ADDRESS, 16, |
1634 | mp->page, sizeof(struct page)); | 1634 | sizeof(long), mp->page, |
1635 | } | 1635 | sizeof(struct page), 0); |
1636 | else { | 1636 | } else |
1637 | printk (KERN_ERR "orphan tblock:\n"); | 1637 | print_hex_dump(KERN_ERR, "tblock:", |
1638 | print_hex_dump(KERN_ERR, DUMP_PREFIX_ADDRESS, | 1638 | DUMP_PREFIX_ADDRESS, 16, 4, |
1639 | lp, sizeof(struct tblock)); | 1639 | lp, sizeof(struct tblock), 0); |
1640 | } | ||
1641 | } | 1640 | } |
1642 | } | 1641 | } |
1642 | #else | ||
1643 | WARN_ON(!list_empty(&log->synclist)); | ||
1643 | #endif | 1644 | #endif |
1644 | //assert(list_empty(&log->synclist)); | ||
1645 | clear_bit(log_FLUSH, &log->flag); | 1645 | clear_bit(log_FLUSH, &log->flag); |
1646 | } | 1646 | } |
1647 | 1647 | ||
diff --git a/fs/jfs/jfs_metapage.c b/fs/jfs/jfs_metapage.c index 1c4fced1e6d8..77c7f1129dde 100644 --- a/fs/jfs/jfs_metapage.c +++ b/fs/jfs/jfs_metapage.c | |||
@@ -472,8 +472,8 @@ add_failed: | |||
472 | printk(KERN_ERR "JFS: bio_add_page failed unexpectedly\n"); | 472 | printk(KERN_ERR "JFS: bio_add_page failed unexpectedly\n"); |
473 | goto skip; | 473 | goto skip; |
474 | dump_bio: | 474 | dump_bio: |
475 | printk(KERN_ERR "JFS: dump of bio:\n"); | 475 | print_hex_dump(KERN_ERR, "JFS: dump of bio: ", DUMP_PREFIX_ADDRESS, 16, |
476 | print_hex_dump(KERN_ERR, DUMP_PREFIX_ADDRESS, bio, sizeof(*bio)); | 476 | 4, bio, sizeof(*bio), 0); |
477 | skip: | 477 | skip: |
478 | bio_put(bio); | 478 | bio_put(bio); |
479 | unlock_page(page); | 479 | unlock_page(page); |
diff --git a/fs/jfs/jfs_txnmgr.c b/fs/jfs/jfs_txnmgr.c index d6f23f90ad36..7aa1f7004eaf 100644 --- a/fs/jfs/jfs_txnmgr.c +++ b/fs/jfs/jfs_txnmgr.c | |||
@@ -830,16 +830,15 @@ struct tlock *txLock(tid_t tid, struct inode *ip, struct metapage * mp, | |||
830 | /* assert(jfs_ip->fileset == AGGREGATE_I); */ | 830 | /* assert(jfs_ip->fileset == AGGREGATE_I); */ |
831 | if (jfs_ip->fileset != AGGREGATE_I) { | 831 | if (jfs_ip->fileset != AGGREGATE_I) { |
832 | printk(KERN_ERR "txLock: trying to lock locked page!"); | 832 | printk(KERN_ERR "txLock: trying to lock locked page!"); |
833 | printk(KERN_ERR "ip:\n"); | 833 | print_hex_dump(KERN_ERR, "ip: ", DUMP_PREFIX_ADDRESS, 16, 4, |
834 | print_hex_dump(KERN_ERR, DUMP_PREFIX_ADDRESS, ip, sizeof(*ip)); | 834 | ip, sizeof(*ip), 0); |
835 | printk(KERN_ERR "mp:\n"); | 835 | print_hex_dump(KERN_ERR, "mp: ", DUMP_PREFIX_ADDRESS, 16, 4, |
836 | print_hex_dump(KERN_ERR, DUMP_PREFIX_ADDRESS, mp, sizeof(*mp)); | 836 | mp, sizeof(*mp), 0); |
837 | printk(KERN_ERR "Locker's tblk:\n"); | 837 | print_hex_dump(KERN_ERR, "Locker's tblock: ", |
838 | print_hex_dump(KERN_ERR, DUMP_PREFIX_ADDRESS, | 838 | DUMP_PREFIX_ADDRESS, 16, 4, tid_to_tblock(tid), |
839 | tid_to_tblock(tid), sizeof(struct tblock)); | 839 | sizeof(struct tblock), 0); |
840 | printk(KERN_ERR "Tlock:\n"); | 840 | print_hex_dump(KERN_ERR, "Tlock: ", DUMP_PREFIX_ADDRESS, 16, 4, |
841 | print_hex_dump(KERN_ERR, DUMP_PREFIX_ADDRESS, tlck, | 841 | tlck, sizeof(*tlck), 0); |
842 | sizeof(*tlck)); | ||
843 | BUG(); | 842 | BUG(); |
844 | } | 843 | } |
845 | INCREMENT(stattx.waitlock); /* statistics */ | 844 | INCREMENT(stattx.waitlock); /* statistics */ |
diff --git a/fs/jfs/xattr.c b/fs/jfs/xattr.c index 2dcb13275429..b2375f0774b7 100644 --- a/fs/jfs/xattr.c +++ b/fs/jfs/xattr.c | |||
@@ -590,8 +590,8 @@ static int ea_get(struct inode *inode, struct ea_buffer *ea_buf, int min_size) | |||
590 | size_check: | 590 | size_check: |
591 | if (EALIST_SIZE(ea_buf->xattr) != ea_size) { | 591 | if (EALIST_SIZE(ea_buf->xattr) != ea_size) { |
592 | printk(KERN_ERR "ea_get: invalid extended attribute\n"); | 592 | printk(KERN_ERR "ea_get: invalid extended attribute\n"); |
593 | print_hex_dump(KERN_ERR, DUMP_PREFIX_ADDRESS, ea_buf->xattr, | 593 | print_hex_dump(KERN_ERR, "", DUMP_PREFIX_ADDRESS, 16, 1, |
594 | ea_size); | 594 | ea_buf->xattr, ea_size, 1); |
595 | ea_release(inode, ea_buf); | 595 | ea_release(inode, ea_buf); |
596 | rc = -EIO; | 596 | rc = -EIO; |
597 | goto clean_up; | 597 | goto clean_up; |