diff options
author | Brian Rogan <bcr6@cornell.edu> | 2006-03-28 04:56:20 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-03-28 12:16:02 -0500 |
commit | 273577165cd206d2d6689ee4b18aa13de1ec4bde (patch) | |
tree | f5dfaed2e193bb65a00ef551f02ace8726cc461c | |
parent | f83ca9fe3ee390755f18b4a7780c25ce593b484a (diff) |
[PATCH] Add oprofile_add_ext_sample
On ppc64 we look at a profiling register to work out the sample address and
if it was in userspace or kernel.
The backtrace interface oprofile_add_sample does not allow this. Create
oprofile_add_ext_sample and make oprofile_add_sample use it too.
Signed-off-by: Anton Blanchard <anton@samba.org>
Cc: Philippe Elie <phil.el@wanadoo.fr>
Cc: John Levon <levon@movementarian.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r-- | drivers/oprofile/cpu_buffer.c | 13 | ||||
-rw-r--r-- | include/linux/oprofile.h | 10 |
2 files changed, 20 insertions, 3 deletions
diff --git a/drivers/oprofile/cpu_buffer.c b/drivers/oprofile/cpu_buffer.c index 330d3869b41e..fc4bc9b94c74 100644 --- a/drivers/oprofile/cpu_buffer.c +++ b/drivers/oprofile/cpu_buffer.c | |||
@@ -217,11 +217,10 @@ static void oprofile_end_trace(struct oprofile_cpu_buffer * cpu_buf) | |||
217 | cpu_buf->tracing = 0; | 217 | cpu_buf->tracing = 0; |
218 | } | 218 | } |
219 | 219 | ||
220 | void oprofile_add_sample(struct pt_regs * const regs, unsigned long event) | 220 | void oprofile_add_ext_sample(unsigned long pc, struct pt_regs * const regs, |
221 | unsigned long event, int is_kernel) | ||
221 | { | 222 | { |
222 | struct oprofile_cpu_buffer * cpu_buf = &cpu_buffer[smp_processor_id()]; | 223 | struct oprofile_cpu_buffer * cpu_buf = &cpu_buffer[smp_processor_id()]; |
223 | unsigned long pc = profile_pc(regs); | ||
224 | int is_kernel = !user_mode(regs); | ||
225 | 224 | ||
226 | if (!backtrace_depth) { | 225 | if (!backtrace_depth) { |
227 | log_sample(cpu_buf, pc, is_kernel, event); | 226 | log_sample(cpu_buf, pc, is_kernel, event); |
@@ -238,6 +237,14 @@ void oprofile_add_sample(struct pt_regs * const regs, unsigned long event) | |||
238 | oprofile_end_trace(cpu_buf); | 237 | oprofile_end_trace(cpu_buf); |
239 | } | 238 | } |
240 | 239 | ||
240 | void oprofile_add_sample(struct pt_regs * const regs, unsigned long event) | ||
241 | { | ||
242 | int is_kernel = !user_mode(regs); | ||
243 | unsigned long pc = profile_pc(regs); | ||
244 | |||
245 | oprofile_add_ext_sample(pc, regs, event, is_kernel); | ||
246 | } | ||
247 | |||
241 | void oprofile_add_pc(unsigned long pc, int is_kernel, unsigned long event) | 248 | void oprofile_add_pc(unsigned long pc, int is_kernel, unsigned long event) |
242 | { | 249 | { |
243 | struct oprofile_cpu_buffer * cpu_buf = &cpu_buffer[smp_processor_id()]; | 250 | struct oprofile_cpu_buffer * cpu_buf = &cpu_buffer[smp_processor_id()]; |
diff --git a/include/linux/oprofile.h b/include/linux/oprofile.h index 559c4c38a9c7..b5b3197dfd4f 100644 --- a/include/linux/oprofile.h +++ b/include/linux/oprofile.h | |||
@@ -61,6 +61,16 @@ void oprofile_arch_exit(void); | |||
61 | */ | 61 | */ |
62 | void oprofile_add_sample(struct pt_regs * const regs, unsigned long event); | 62 | void oprofile_add_sample(struct pt_regs * const regs, unsigned long event); |
63 | 63 | ||
64 | /** | ||
65 | * Add an extended sample. Use this when the PC is not from the regs, and | ||
66 | * we cannot determine if we're in kernel mode from the regs. | ||
67 | * | ||
68 | * This function does perform a backtrace. | ||
69 | * | ||
70 | */ | ||
71 | void oprofile_add_ext_sample(unsigned long pc, struct pt_regs * const regs, | ||
72 | unsigned long event, int is_kernel); | ||
73 | |||
64 | /* Use this instead when the PC value is not from the regs. Doesn't | 74 | /* Use this instead when the PC value is not from the regs. Doesn't |
65 | * backtrace. */ | 75 | * backtrace. */ |
66 | void oprofile_add_pc(unsigned long pc, int is_kernel, unsigned long event); | 76 | void oprofile_add_pc(unsigned long pc, int is_kernel, unsigned long event); |