diff options
author | Harald Welte <laforge@netfilter.org> | 2005-11-03 13:20:07 -0500 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@mandriva.com> | 2005-11-05 13:35:27 -0500 |
commit | 10dfdc69ea07d5a6c24406755f5e8de95a1b8901 (patch) | |
tree | 2004603342d995ec88d53f3e6160e04befe498ef | |
parent | 0f81eb4db4f1cc560318b6e7762a7a1d7d8c7095 (diff) |
[NETFILTER] nfnetlink: Use kzalloc
These is a cleanup patch, kzalloc can be used in a couple of cases
Signed-off-by: Samir Bellabes <sbellabes@mandriva.com>
Signed-off-by: Harald Welte <laforge@netfilter.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
-rw-r--r-- | net/netfilter/nfnetlink_log.c | 6 | ||||
-rw-r--r-- | net/netfilter/nfnetlink_queue.c | 6 |
2 files changed, 4 insertions, 8 deletions
diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c index efcd10f996ba..d194676f3655 100644 --- a/net/netfilter/nfnetlink_log.c +++ b/net/netfilter/nfnetlink_log.c | |||
@@ -146,11 +146,10 @@ instance_create(u_int16_t group_num, int pid) | |||
146 | goto out_unlock; | 146 | goto out_unlock; |
147 | } | 147 | } |
148 | 148 | ||
149 | inst = kmalloc(sizeof(*inst), GFP_ATOMIC); | 149 | inst = kzalloc(sizeof(*inst), GFP_ATOMIC); |
150 | if (!inst) | 150 | if (!inst) |
151 | goto out_unlock; | 151 | goto out_unlock; |
152 | 152 | ||
153 | memset(inst, 0, sizeof(*inst)); | ||
154 | INIT_HLIST_NODE(&inst->hlist); | 153 | INIT_HLIST_NODE(&inst->hlist); |
155 | inst->lock = SPIN_LOCK_UNLOCKED; | 154 | inst->lock = SPIN_LOCK_UNLOCKED; |
156 | /* needs to be two, since we _put() after creation */ | 155 | /* needs to be two, since we _put() after creation */ |
@@ -962,10 +961,9 @@ static int nful_open(struct inode *inode, struct file *file) | |||
962 | struct iter_state *is; | 961 | struct iter_state *is; |
963 | int ret; | 962 | int ret; |
964 | 963 | ||
965 | is = kmalloc(sizeof(*is), GFP_KERNEL); | 964 | is = kzalloc(sizeof(*is), GFP_KERNEL); |
966 | if (!is) | 965 | if (!is) |
967 | return -ENOMEM; | 966 | return -ENOMEM; |
968 | memset(is, 0, sizeof(*is)); | ||
969 | ret = seq_open(file, &nful_seq_ops); | 967 | ret = seq_open(file, &nful_seq_ops); |
970 | if (ret < 0) | 968 | if (ret < 0) |
971 | goto out_free; | 969 | goto out_free; |
diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c index eaa44c49567b..f065a6c94953 100644 --- a/net/netfilter/nfnetlink_queue.c +++ b/net/netfilter/nfnetlink_queue.c | |||
@@ -136,11 +136,10 @@ instance_create(u_int16_t queue_num, int pid) | |||
136 | goto out_unlock; | 136 | goto out_unlock; |
137 | } | 137 | } |
138 | 138 | ||
139 | inst = kmalloc(sizeof(*inst), GFP_ATOMIC); | 139 | inst = kzalloc(sizeof(*inst), GFP_ATOMIC); |
140 | if (!inst) | 140 | if (!inst) |
141 | goto out_unlock; | 141 | goto out_unlock; |
142 | 142 | ||
143 | memset(inst, 0, sizeof(*inst)); | ||
144 | inst->queue_num = queue_num; | 143 | inst->queue_num = queue_num; |
145 | inst->peer_pid = pid; | 144 | inst->peer_pid = pid; |
146 | inst->queue_maxlen = NFQNL_QMAX_DEFAULT; | 145 | inst->queue_maxlen = NFQNL_QMAX_DEFAULT; |
@@ -1036,10 +1035,9 @@ static int nfqnl_open(struct inode *inode, struct file *file) | |||
1036 | struct iter_state *is; | 1035 | struct iter_state *is; |
1037 | int ret; | 1036 | int ret; |
1038 | 1037 | ||
1039 | is = kmalloc(sizeof(*is), GFP_KERNEL); | 1038 | is = kzalloc(sizeof(*is), GFP_KERNEL); |
1040 | if (!is) | 1039 | if (!is) |
1041 | return -ENOMEM; | 1040 | return -ENOMEM; |
1042 | memset(is, 0, sizeof(*is)); | ||
1043 | ret = seq_open(file, &nfqnl_seq_ops); | 1041 | ret = seq_open(file, &nfqnl_seq_ops); |
1044 | if (ret < 0) | 1042 | if (ret < 0) |
1045 | goto out_free; | 1043 | goto out_free; |