diff options
author | Joe Perches <joe@perches.com> | 2010-05-14 06:58:26 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-05-17 20:44:35 -0400 |
commit | ccbd6a5a4f76e821ed36f69fdaf59817c3a7f18e (patch) | |
tree | 9fd681809e588913cc312f63ae0e701f18599afc | |
parent | 935e2a26b85003c0bd52b6c92712c2f77a5f9d33 (diff) |
net: Remove unnecessary semicolons after switch statements
Also added an explicit break; to avoid
a fallthrough in net/ipv4/tcp_input.c
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/8021q/vlan_core.c | 2 | ||||
-rw-r--r-- | net/core/ethtool.c | 4 | ||||
-rw-r--r-- | net/ipv4/tcp.c | 2 | ||||
-rw-r--r-- | net/ipv4/tcp_input.c | 5 | ||||
-rw-r--r-- | net/rds/tcp_connect.c | 2 | ||||
-rw-r--r-- | net/socket.c | 2 | ||||
-rw-r--r-- | net/xfrm/xfrm_hash.h | 6 |
7 files changed, 12 insertions, 11 deletions
diff --git a/net/8021q/vlan_core.c b/net/8021q/vlan_core.c index c584a0af77d3..bd537fc10254 100644 --- a/net/8021q/vlan_core.c +++ b/net/8021q/vlan_core.c | |||
@@ -61,7 +61,7 @@ int vlan_hwaccel_do_receive(struct sk_buff *skb) | |||
61 | dev->dev_addr)) | 61 | dev->dev_addr)) |
62 | skb->pkt_type = PACKET_HOST; | 62 | skb->pkt_type = PACKET_HOST; |
63 | break; | 63 | break; |
64 | }; | 64 | } |
65 | return 0; | 65 | return 0; |
66 | } | 66 | } |
67 | 67 | ||
diff --git a/net/core/ethtool.c b/net/core/ethtool.c index 1a7db92037fa..a0f4964033d2 100644 --- a/net/core/ethtool.c +++ b/net/core/ethtool.c | |||
@@ -522,7 +522,7 @@ static int ethtool_get_rx_ntuple(struct net_device *dev, void __user *useraddr) | |||
522 | p += ETH_GSTRING_LEN; | 522 | p += ETH_GSTRING_LEN; |
523 | num_strings++; | 523 | num_strings++; |
524 | goto unknown_filter; | 524 | goto unknown_filter; |
525 | }; | 525 | } |
526 | 526 | ||
527 | /* now the rest of the filters */ | 527 | /* now the rest of the filters */ |
528 | switch (fsc->fs.flow_type) { | 528 | switch (fsc->fs.flow_type) { |
@@ -646,7 +646,7 @@ static int ethtool_get_rx_ntuple(struct net_device *dev, void __user *useraddr) | |||
646 | p += ETH_GSTRING_LEN; | 646 | p += ETH_GSTRING_LEN; |
647 | num_strings++; | 647 | num_strings++; |
648 | break; | 648 | break; |
649 | }; | 649 | } |
650 | sprintf(p, "\tVLAN: %d, mask: 0x%x\n", | 650 | sprintf(p, "\tVLAN: %d, mask: 0x%x\n", |
651 | fsc->fs.vlan_tag, fsc->fs.vlan_tag_mask); | 651 | fsc->fs.vlan_tag, fsc->fs.vlan_tag_mask); |
652 | p += ETH_GSTRING_LEN; | 652 | p += ETH_GSTRING_LEN; |
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index 3284393d09b4..6596b4feeddc 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c | |||
@@ -2215,7 +2215,7 @@ static int do_tcp_setsockopt(struct sock *sk, int level, | |||
2215 | default: | 2215 | default: |
2216 | /* fallthru */ | 2216 | /* fallthru */ |
2217 | break; | 2217 | break; |
2218 | }; | 2218 | } |
2219 | 2219 | ||
2220 | if (optlen < sizeof(int)) | 2220 | if (optlen < sizeof(int)) |
2221 | return -EINVAL; | 2221 | return -EINVAL; |
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index e82162c211bf..3e6dafcb1071 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c | |||
@@ -3845,12 +3845,13 @@ void tcp_parse_options(struct sk_buff *skb, struct tcp_options_received *opt_rx, | |||
3845 | /* 16-bit multiple */ | 3845 | /* 16-bit multiple */ |
3846 | opt_rx->cookie_plus = opsize; | 3846 | opt_rx->cookie_plus = opsize; |
3847 | *hvpp = ptr; | 3847 | *hvpp = ptr; |
3848 | break; | ||
3848 | default: | 3849 | default: |
3849 | /* ignore option */ | 3850 | /* ignore option */ |
3850 | break; | 3851 | break; |
3851 | }; | 3852 | } |
3852 | break; | 3853 | break; |
3853 | }; | 3854 | } |
3854 | 3855 | ||
3855 | ptr += opsize-2; | 3856 | ptr += opsize-2; |
3856 | length -= opsize; | 3857 | length -= opsize; |
diff --git a/net/rds/tcp_connect.c b/net/rds/tcp_connect.c index 056256285987..c397524c039c 100644 --- a/net/rds/tcp_connect.c +++ b/net/rds/tcp_connect.c | |||
@@ -141,7 +141,7 @@ void rds_tcp_conn_shutdown(struct rds_connection *conn) | |||
141 | 141 | ||
142 | release_sock(sock->sk); | 142 | release_sock(sock->sk); |
143 | sock_release(sock); | 143 | sock_release(sock); |
144 | }; | 144 | } |
145 | 145 | ||
146 | if (tc->t_tinc) { | 146 | if (tc->t_tinc) { |
147 | rds_inc_put(&tc->t_tinc->ti_inc); | 147 | rds_inc_put(&tc->t_tinc->ti_inc); |
diff --git a/net/socket.c b/net/socket.c index dae8c6b84a09..f9f7d0872cac 100644 --- a/net/socket.c +++ b/net/socket.c | |||
@@ -2615,7 +2615,7 @@ static int bond_ioctl(struct net *net, unsigned int cmd, | |||
2615 | return dev_ioctl(net, cmd, uifr); | 2615 | return dev_ioctl(net, cmd, uifr); |
2616 | default: | 2616 | default: |
2617 | return -EINVAL; | 2617 | return -EINVAL; |
2618 | }; | 2618 | } |
2619 | } | 2619 | } |
2620 | 2620 | ||
2621 | static int siocdevprivate_ioctl(struct net *net, unsigned int cmd, | 2621 | static int siocdevprivate_ioctl(struct net *net, unsigned int cmd, |
diff --git a/net/xfrm/xfrm_hash.h b/net/xfrm/xfrm_hash.h index 1396572d2ade..8e69533d2313 100644 --- a/net/xfrm/xfrm_hash.h +++ b/net/xfrm/xfrm_hash.h | |||
@@ -55,7 +55,7 @@ static inline unsigned __xfrm_src_hash(xfrm_address_t *daddr, | |||
55 | case AF_INET6: | 55 | case AF_INET6: |
56 | h ^= __xfrm6_daddr_saddr_hash(daddr, saddr); | 56 | h ^= __xfrm6_daddr_saddr_hash(daddr, saddr); |
57 | break; | 57 | break; |
58 | }; | 58 | } |
59 | return (h ^ (h >> 16)) & hmask; | 59 | return (h ^ (h >> 16)) & hmask; |
60 | } | 60 | } |
61 | 61 | ||
@@ -102,7 +102,7 @@ static inline unsigned int __sel_hash(struct xfrm_selector *sel, unsigned short | |||
102 | 102 | ||
103 | h = __xfrm6_daddr_saddr_hash(daddr, saddr); | 103 | h = __xfrm6_daddr_saddr_hash(daddr, saddr); |
104 | break; | 104 | break; |
105 | }; | 105 | } |
106 | h ^= (h >> 16); | 106 | h ^= (h >> 16); |
107 | return h & hmask; | 107 | return h & hmask; |
108 | } | 108 | } |
@@ -119,7 +119,7 @@ static inline unsigned int __addr_hash(xfrm_address_t *daddr, xfrm_address_t *sa | |||
119 | case AF_INET6: | 119 | case AF_INET6: |
120 | h = __xfrm6_daddr_saddr_hash(daddr, saddr); | 120 | h = __xfrm6_daddr_saddr_hash(daddr, saddr); |
121 | break; | 121 | break; |
122 | }; | 122 | } |
123 | h ^= (h >> 16); | 123 | h ^= (h >> 16); |
124 | return h & hmask; | 124 | return h & hmask; |
125 | } | 125 | } |