diff options
author | Linus Torvalds <torvalds@woody.osdl.org> | 2006-11-20 14:47:18 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.osdl.org> | 2006-11-20 14:47:18 -0500 |
commit | b3438f8266cb1f5010085ac47d7ad6a36a212164 (patch) | |
tree | bb74bd7a3ea7a629e380aa7761ba63a5e44992c7 | |
parent | f44ea623443ee0bec266d62f1cd346881224d47d (diff) |
Add "pure_initcall" for static variable initialization
This is a quick hack to overcome the fact that SRCU currently does not
allow static initializers, and we need to sometimes initialize those
things before any other initializers (even "core" ones) can do so.
Currently we don't allow this at all for modules, and the only user that
needs is right now is cpufreq. As reported by Thomas Gleixner:
"Commit b4dfdbb3c707474a2254c5b4d7e62be31a4b7da9 ("[PATCH] cpufreq:
make the transition_notifier chain use SRCU breaks cpu frequency
notification users, which register the callback > on core_init
level."
Cc: Thomas Gleixner <tglx@timesys.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Arjan van de Ven <arjan@infradead.org>
Cc: Andrew Morton <akpm@osdl.org>,
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r-- | drivers/cpufreq/cpufreq.c | 2 | ||||
-rw-r--r-- | include/asm-generic/vmlinux.lds.h | 2 | ||||
-rw-r--r-- | include/linux/init.h | 8 |
3 files changed, 11 insertions, 1 deletions
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 86e69b7f9122..dd0c2623e27b 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c | |||
@@ -59,7 +59,7 @@ static int __init init_cpufreq_transition_notifier_list(void) | |||
59 | srcu_init_notifier_head(&cpufreq_transition_notifier_list); | 59 | srcu_init_notifier_head(&cpufreq_transition_notifier_list); |
60 | return 0; | 60 | return 0; |
61 | } | 61 | } |
62 | core_initcall(init_cpufreq_transition_notifier_list); | 62 | pure_initcall(init_cpufreq_transition_notifier_list); |
63 | 63 | ||
64 | static LIST_HEAD(cpufreq_governor_list); | 64 | static LIST_HEAD(cpufreq_governor_list); |
65 | static DEFINE_MUTEX (cpufreq_governor_mutex); | 65 | static DEFINE_MUTEX (cpufreq_governor_mutex); |
diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h index 9d873163a7ab..e60d6f21fa62 100644 --- a/include/asm-generic/vmlinux.lds.h +++ b/include/asm-generic/vmlinux.lds.h | |||
@@ -215,6 +215,8 @@ | |||
215 | .notes : { *(.note.*) } :note | 215 | .notes : { *(.note.*) } :note |
216 | 216 | ||
217 | #define INITCALLS \ | 217 | #define INITCALLS \ |
218 | *(.initcall0.init) \ | ||
219 | *(.initcall0s.init) \ | ||
218 | *(.initcall1.init) \ | 220 | *(.initcall1.init) \ |
219 | *(.initcall1s.init) \ | 221 | *(.initcall1s.init) \ |
220 | *(.initcall2.init) \ | 222 | *(.initcall2.init) \ |
diff --git a/include/linux/init.h b/include/linux/init.h index ff40ea118e3a..5eb5d24b7680 100644 --- a/include/linux/init.h +++ b/include/linux/init.h | |||
@@ -93,6 +93,14 @@ extern void setup_arch(char **); | |||
93 | static initcall_t __initcall_##fn##id __attribute_used__ \ | 93 | static initcall_t __initcall_##fn##id __attribute_used__ \ |
94 | __attribute__((__section__(".initcall" level ".init"))) = fn | 94 | __attribute__((__section__(".initcall" level ".init"))) = fn |
95 | 95 | ||
96 | /* | ||
97 | * A "pure" initcall has no dependencies on anything else, and purely | ||
98 | * initializes variables that couldn't be statically initialized. | ||
99 | * | ||
100 | * This only exists for built-in code, not for modules. | ||
101 | */ | ||
102 | #define pure_initcall(fn) __define_initcall("0",fn,1) | ||
103 | |||
96 | #define core_initcall(fn) __define_initcall("1",fn,1) | 104 | #define core_initcall(fn) __define_initcall("1",fn,1) |
97 | #define core_initcall_sync(fn) __define_initcall("1s",fn,1s) | 105 | #define core_initcall_sync(fn) __define_initcall("1s",fn,1s) |
98 | #define postcore_initcall(fn) __define_initcall("2",fn,2) | 106 | #define postcore_initcall(fn) __define_initcall("2",fn,2) |