diff options
author | Takashi Iwai <tiwai@suse.de> | 2007-06-25 06:09:32 -0400 |
---|---|---|
committer | Jaroslav Kysela <perex@suse.cz> | 2007-07-20 05:11:36 -0400 |
commit | e65365de5ba280e058bd6b8b80c8790253268887 (patch) | |
tree | 8ce89e16bd1519b620c52c407511c30f3af391f3 | |
parent | c12aad6efbee1d937438f1deabbef695add0628b (diff) |
[ALSA] Fix invalid schedule_timeout_interruptible()
Fixed the invalid use of schedule_timeout_interruptible() without
checking pending signals. Simply replaced with schedule_timeout().
Suggestions thanks to Jeff Garzik.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz>
-rw-r--r-- | sound/core/seq/seq_instr.c | 6 | ||||
-rw-r--r-- | sound/isa/ad1848/ad1848_lib.c | 4 | ||||
-rw-r--r-- | sound/isa/sscape.c | 4 | ||||
-rw-r--r-- | sound/isa/wavefront/wavefront_synth.c | 2 | ||||
-rw-r--r-- | sound/pci/hda/hda_intel.c | 2 | ||||
-rw-r--r-- | sound/pci/via82xx.c | 4 | ||||
-rw-r--r-- | sound/pci/via82xx_modem.c | 4 |
7 files changed, 13 insertions, 13 deletions
diff --git a/sound/core/seq/seq_instr.c b/sound/core/seq/seq_instr.c index f30d171b6d96..5efe6523a589 100644 --- a/sound/core/seq/seq_instr.c +++ b/sound/core/seq/seq_instr.c | |||
@@ -109,7 +109,7 @@ void snd_seq_instr_list_free(struct snd_seq_kinstr_list **list_ptr) | |||
109 | spin_lock_irqsave(&list->lock, flags); | 109 | spin_lock_irqsave(&list->lock, flags); |
110 | while (instr->use) { | 110 | while (instr->use) { |
111 | spin_unlock_irqrestore(&list->lock, flags); | 111 | spin_unlock_irqrestore(&list->lock, flags); |
112 | schedule_timeout_interruptible(1); | 112 | schedule_timeout(1); |
113 | spin_lock_irqsave(&list->lock, flags); | 113 | spin_lock_irqsave(&list->lock, flags); |
114 | } | 114 | } |
115 | spin_unlock_irqrestore(&list->lock, flags); | 115 | spin_unlock_irqrestore(&list->lock, flags); |
@@ -199,7 +199,7 @@ int snd_seq_instr_list_free_cond(struct snd_seq_kinstr_list *list, | |||
199 | instr = flist; | 199 | instr = flist; |
200 | flist = instr->next; | 200 | flist = instr->next; |
201 | while (instr->use) | 201 | while (instr->use) |
202 | schedule_timeout_interruptible(1); | 202 | schedule_timeout(1); |
203 | if (snd_seq_instr_free(instr, atomic)<0) | 203 | if (snd_seq_instr_free(instr, atomic)<0) |
204 | snd_printk(KERN_WARNING "instrument free problem\n"); | 204 | snd_printk(KERN_WARNING "instrument free problem\n"); |
205 | instr = next; | 205 | instr = next; |
@@ -555,7 +555,7 @@ static int instr_free(struct snd_seq_kinstr_ops *ops, | |||
555 | SNDRV_SEQ_INSTR_NOTIFY_REMOVE); | 555 | SNDRV_SEQ_INSTR_NOTIFY_REMOVE); |
556 | while (instr->use) { | 556 | while (instr->use) { |
557 | spin_unlock_irqrestore(&list->lock, flags); | 557 | spin_unlock_irqrestore(&list->lock, flags); |
558 | schedule_timeout_interruptible(1); | 558 | schedule_timeout(1); |
559 | spin_lock_irqsave(&list->lock, flags); | 559 | spin_lock_irqsave(&list->lock, flags); |
560 | } | 560 | } |
561 | spin_unlock_irqrestore(&list->lock, flags); | 561 | spin_unlock_irqrestore(&list->lock, flags); |
diff --git a/sound/isa/ad1848/ad1848_lib.c b/sound/isa/ad1848/ad1848_lib.c index 8094282c2ae1..1bc2e3fd5721 100644 --- a/sound/isa/ad1848/ad1848_lib.c +++ b/sound/isa/ad1848/ad1848_lib.c | |||
@@ -245,7 +245,7 @@ static void snd_ad1848_mce_down(struct snd_ad1848 *chip) | |||
245 | snd_printk(KERN_ERR "mce_down - auto calibration time out (2)\n"); | 245 | snd_printk(KERN_ERR "mce_down - auto calibration time out (2)\n"); |
246 | return; | 246 | return; |
247 | } | 247 | } |
248 | time = schedule_timeout_interruptible(time); | 248 | time = schedule_timeout(time); |
249 | spin_lock_irqsave(&chip->reg_lock, flags); | 249 | spin_lock_irqsave(&chip->reg_lock, flags); |
250 | } | 250 | } |
251 | #if 0 | 251 | #if 0 |
@@ -258,7 +258,7 @@ static void snd_ad1848_mce_down(struct snd_ad1848 *chip) | |||
258 | snd_printk(KERN_ERR "mce_down - auto calibration time out (3)\n"); | 258 | snd_printk(KERN_ERR "mce_down - auto calibration time out (3)\n"); |
259 | return; | 259 | return; |
260 | } | 260 | } |
261 | time = schedule_timeout_interruptible(time); | 261 | time = schedule_timeout(time); |
262 | spin_lock_irqsave(&chip->reg_lock, flags); | 262 | spin_lock_irqsave(&chip->reg_lock, flags); |
263 | } | 263 | } |
264 | spin_unlock_irqrestore(&chip->reg_lock, flags); | 264 | spin_unlock_irqrestore(&chip->reg_lock, flags); |
diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c index 9ea417bcf3e5..cbad2a51cbaa 100644 --- a/sound/isa/sscape.c +++ b/sound/isa/sscape.c | |||
@@ -382,7 +382,7 @@ static int obp_startup_ack(struct soundscape *s, unsigned timeout) | |||
382 | unsigned long flags; | 382 | unsigned long flags; |
383 | unsigned char x; | 383 | unsigned char x; |
384 | 384 | ||
385 | schedule_timeout_interruptible(1); | 385 | schedule_timeout(1); |
386 | 386 | ||
387 | spin_lock_irqsave(&s->lock, flags); | 387 | spin_lock_irqsave(&s->lock, flags); |
388 | x = inb(HOST_DATA_IO(s->io_base)); | 388 | x = inb(HOST_DATA_IO(s->io_base)); |
@@ -409,7 +409,7 @@ static int host_startup_ack(struct soundscape *s, unsigned timeout) | |||
409 | unsigned long flags; | 409 | unsigned long flags; |
410 | unsigned char x; | 410 | unsigned char x; |
411 | 411 | ||
412 | schedule_timeout_interruptible(1); | 412 | schedule_timeout(1); |
413 | 413 | ||
414 | spin_lock_irqsave(&s->lock, flags); | 414 | spin_lock_irqsave(&s->lock, flags); |
415 | x = inb(HOST_DATA_IO(s->io_base)); | 415 | x = inb(HOST_DATA_IO(s->io_base)); |
diff --git a/sound/isa/wavefront/wavefront_synth.c b/sound/isa/wavefront/wavefront_synth.c index 78020d832e04..bacc51c86587 100644 --- a/sound/isa/wavefront/wavefront_synth.c +++ b/sound/isa/wavefront/wavefront_synth.c | |||
@@ -1780,7 +1780,7 @@ wavefront_should_cause_interrupt (snd_wavefront_t *dev, | |||
1780 | outb (val,port); | 1780 | outb (val,port); |
1781 | spin_unlock_irq(&dev->irq_lock); | 1781 | spin_unlock_irq(&dev->irq_lock); |
1782 | while (1) { | 1782 | while (1) { |
1783 | if ((timeout = schedule_timeout_interruptible(timeout)) == 0) | 1783 | if ((timeout = schedule_timeout(timeout)) == 0) |
1784 | return; | 1784 | return; |
1785 | if (dev->irq_ok) | 1785 | if (dev->irq_ok) |
1786 | return; | 1786 | return; |
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 74e5593a58e1..c78ff901a572 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c | |||
@@ -538,7 +538,7 @@ static unsigned int azx_rirb_get_response(struct hda_codec *codec) | |||
538 | } | 538 | } |
539 | if (! chip->rirb.cmds) | 539 | if (! chip->rirb.cmds) |
540 | return chip->rirb.res; /* the last value */ | 540 | return chip->rirb.res; /* the last value */ |
541 | schedule_timeout_interruptible(1); | 541 | schedule_timeout(1); |
542 | } while (time_after_eq(timeout, jiffies)); | 542 | } while (time_after_eq(timeout, jiffies)); |
543 | 543 | ||
544 | if (chip->msi) { | 544 | if (chip->msi) { |
diff --git a/sound/pci/via82xx.c b/sound/pci/via82xx.c index 50c9f92cfd1b..6ea09df0c73a 100644 --- a/sound/pci/via82xx.c +++ b/sound/pci/via82xx.c | |||
@@ -2098,7 +2098,7 @@ static int snd_via82xx_chip_init(struct via82xx *chip) | |||
2098 | pci_read_config_byte(chip->pci, VIA_ACLINK_STAT, &pval); | 2098 | pci_read_config_byte(chip->pci, VIA_ACLINK_STAT, &pval); |
2099 | if (pval & VIA_ACLINK_C00_READY) /* primary codec ready */ | 2099 | if (pval & VIA_ACLINK_C00_READY) /* primary codec ready */ |
2100 | break; | 2100 | break; |
2101 | schedule_timeout_uninterruptible(1); | 2101 | schedule_timeout(1); |
2102 | } while (time_before(jiffies, end_time)); | 2102 | } while (time_before(jiffies, end_time)); |
2103 | 2103 | ||
2104 | if ((val = snd_via82xx_codec_xread(chip)) & VIA_REG_AC97_BUSY) | 2104 | if ((val = snd_via82xx_codec_xread(chip)) & VIA_REG_AC97_BUSY) |
@@ -2117,7 +2117,7 @@ static int snd_via82xx_chip_init(struct via82xx *chip) | |||
2117 | chip->ac97_secondary = 1; | 2117 | chip->ac97_secondary = 1; |
2118 | goto __ac97_ok2; | 2118 | goto __ac97_ok2; |
2119 | } | 2119 | } |
2120 | schedule_timeout_interruptible(1); | 2120 | schedule_timeout(1); |
2121 | } while (time_before(jiffies, end_time)); | 2121 | } while (time_before(jiffies, end_time)); |
2122 | /* This is ok, the most of motherboards have only one codec */ | 2122 | /* This is ok, the most of motherboards have only one codec */ |
2123 | 2123 | ||
diff --git a/sound/pci/via82xx_modem.c b/sound/pci/via82xx_modem.c index 8cbf8eba4ae9..72425e73abae 100644 --- a/sound/pci/via82xx_modem.c +++ b/sound/pci/via82xx_modem.c | |||
@@ -983,7 +983,7 @@ static int snd_via82xx_chip_init(struct via82xx_modem *chip) | |||
983 | pci_read_config_byte(chip->pci, VIA_ACLINK_STAT, &pval); | 983 | pci_read_config_byte(chip->pci, VIA_ACLINK_STAT, &pval); |
984 | if (pval & VIA_ACLINK_C00_READY) /* primary codec ready */ | 984 | if (pval & VIA_ACLINK_C00_READY) /* primary codec ready */ |
985 | break; | 985 | break; |
986 | schedule_timeout_uninterruptible(1); | 986 | schedule_timeout(1); |
987 | } while (time_before(jiffies, end_time)); | 987 | } while (time_before(jiffies, end_time)); |
988 | 988 | ||
989 | if ((val = snd_via82xx_codec_xread(chip)) & VIA_REG_AC97_BUSY) | 989 | if ((val = snd_via82xx_codec_xread(chip)) & VIA_REG_AC97_BUSY) |
@@ -1001,7 +1001,7 @@ static int snd_via82xx_chip_init(struct via82xx_modem *chip) | |||
1001 | chip->ac97_secondary = 1; | 1001 | chip->ac97_secondary = 1; |
1002 | goto __ac97_ok2; | 1002 | goto __ac97_ok2; |
1003 | } | 1003 | } |
1004 | schedule_timeout_interruptible(1); | 1004 | schedule_timeout(1); |
1005 | } while (time_before(jiffies, end_time)); | 1005 | } while (time_before(jiffies, end_time)); |
1006 | /* This is ok, the most of motherboards have only one codec */ | 1006 | /* This is ok, the most of motherboards have only one codec */ |
1007 | 1007 | ||