diff options
author | Stephen Rothwell <sfr@canb.auug.org.au> | 2009-03-27 08:08:34 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-04-01 18:50:24 -0400 |
commit | a095bdbb136f7bed96b7adf5aa1dd27bb2f839bf (patch) | |
tree | 2cf083e37f348c1f2de82cb83003b3540f35a871 | |
parent | 8302294f43250dc337108c51882a6007f2b1e2e0 (diff) |
tracing, powerpc: fix powerpc tree and tracing tree interaction
Today's linux-next build (powerpc allyesconfig) failed like this:
arch/powerpc/kernel/ftrace.c: In function 'prepare_ftrace_return':
arch/powerpc/kernel/ftrace.c:612: warning: passing argument 3 of 'ftrace_push_return_trace' makes pointer from integer without a cast
arch/powerpc/kernel/ftrace.c:612: error: too many arguments to function 'ftrace_push_return_trace'
Caused by commit 5d1a03dc541dc6672e60e57249ed22f40654ca47
("function-graph: moved the timestamp from arch to generic code") from
the tracing tree which (removed an argument from
ftrace_push_return_trace()) interacting with commit
6794c78243bfda020ab184d6d578944f8e90d26c ("powerpc64: port of the
function graph tracer") from the powerpc tree.
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Steven Rostedt <srostedt@redhat.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: <linuxppc-dev@ozlabs.org>
LKML-Reference: <20090327230834.93d0221d.sfr@canb.auug.org.au>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r-- | arch/powerpc/kernel/ftrace.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/arch/powerpc/kernel/ftrace.c b/arch/powerpc/kernel/ftrace.c index 5b5d16b2cac8..5455943f16aa 100644 --- a/arch/powerpc/kernel/ftrace.c +++ b/arch/powerpc/kernel/ftrace.c | |||
@@ -557,7 +557,6 @@ extern void mod_return_to_handler(void); | |||
557 | void prepare_ftrace_return(unsigned long *parent, unsigned long self_addr) | 557 | void prepare_ftrace_return(unsigned long *parent, unsigned long self_addr) |
558 | { | 558 | { |
559 | unsigned long old; | 559 | unsigned long old; |
560 | unsigned long long calltime; | ||
561 | int faulted; | 560 | int faulted; |
562 | struct ftrace_graph_ent trace; | 561 | struct ftrace_graph_ent trace; |
563 | unsigned long return_hooker = (unsigned long)&return_to_handler; | 562 | unsigned long return_hooker = (unsigned long)&return_to_handler; |
@@ -606,10 +605,7 @@ void prepare_ftrace_return(unsigned long *parent, unsigned long self_addr) | |||
606 | return; | 605 | return; |
607 | } | 606 | } |
608 | 607 | ||
609 | calltime = cpu_clock(raw_smp_processor_id()); | 608 | if (ftrace_push_return_trace(old, self_addr, &trace.depth) == -EBUSY) { |
610 | |||
611 | if (ftrace_push_return_trace(old, calltime, | ||
612 | self_addr, &trace.depth) == -EBUSY) { | ||
613 | *parent = old; | 609 | *parent = old; |
614 | return; | 610 | return; |
615 | } | 611 | } |