aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJeff Garzik <jeff@garzik.org>2006-03-24 09:56:57 -0500
committerJeff Garzik <jeff@garzik.org>2006-03-24 09:56:57 -0500
commit2e9edbf815e42f93dd29a9981f27bd421acc47df (patch)
tree57f4026cc532879c0678c535e15c5172b62d2106
parentebdfca6eb1b755d3bfe9a81339ecdafd92038c1a (diff)
[libata] export ata_dev_pair; trim trailing whitespace
Mostly, trim trailing whitespace. Also: * export ata_dev_pair * move ata_dev_classify export closer to ata_dev_pair export
-rw-r--r--drivers/scsi/ata_piix.c6
-rw-r--r--drivers/scsi/libata-bmdma.c4
-rw-r--r--drivers/scsi/libata-core.c49
-rw-r--r--drivers/scsi/libata-scsi.c30
-rw-r--r--drivers/scsi/sata_sil24.c2
-rw-r--r--drivers/scsi/sata_vsc.c4
6 files changed, 48 insertions, 47 deletions
diff --git a/drivers/scsi/ata_piix.c b/drivers/scsi/ata_piix.c
index a74e23d39ba9..2d5be84d8bd4 100644
--- a/drivers/scsi/ata_piix.c
+++ b/drivers/scsi/ata_piix.c
@@ -742,7 +742,7 @@ static int piix_disable_ahci(struct pci_dev *pdev)
742/** 742/**
743 * piix_check_450nx_errata - Check for problem 450NX setup 743 * piix_check_450nx_errata - Check for problem 450NX setup
744 * @ata_dev: the PCI device to check 744 * @ata_dev: the PCI device to check
745 * 745 *
746 * Check for the present of 450NX errata #19 and errata #25. If 746 * Check for the present of 450NX errata #19 and errata #25. If
747 * they are found return an error code so we can turn off DMA 747 * they are found return an error code so we can turn off DMA
748 */ 748 */
@@ -753,7 +753,7 @@ static int __devinit piix_check_450nx_errata(struct pci_dev *ata_dev)
753 u16 cfg; 753 u16 cfg;
754 u8 rev; 754 u8 rev;
755 int no_piix_dma = 0; 755 int no_piix_dma = 0;
756 756
757 while((pdev = pci_get_device(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82454NX, pdev)) != NULL) 757 while((pdev = pci_get_device(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82454NX, pdev)) != NULL)
758 { 758 {
759 /* Look for 450NX PXB. Check for problem configurations 759 /* Look for 450NX PXB. Check for problem configurations
@@ -772,7 +772,7 @@ static int __devinit piix_check_450nx_errata(struct pci_dev *ata_dev)
772 if(no_piix_dma == 2) 772 if(no_piix_dma == 2)
773 dev_printk(KERN_WARNING, &ata_dev->dev, "A BIOS update may resolve this.\n"); 773 dev_printk(KERN_WARNING, &ata_dev->dev, "A BIOS update may resolve this.\n");
774 return no_piix_dma; 774 return no_piix_dma;
775} 775}
776 776
777static void __devinit piix_init_sata_map(struct pci_dev *pdev, 777static void __devinit piix_init_sata_map(struct pci_dev *pdev,
778 struct ata_port_info *pinfo) 778 struct ata_port_info *pinfo)
diff --git a/drivers/scsi/libata-bmdma.c b/drivers/scsi/libata-bmdma.c
index a00a78b30836..95d81d86d8b7 100644
--- a/drivers/scsi/libata-bmdma.c
+++ b/drivers/scsi/libata-bmdma.c
@@ -941,7 +941,7 @@ err_out:
941 * @pdev: PCI device 941 * @pdev: PCI device
942 * 942 *
943 * Some PCI ATA devices report simplex mode but in fact can be told to 943 * Some PCI ATA devices report simplex mode but in fact can be told to
944 * enter non simplex mode. This implements the neccessary logic to 944 * enter non simplex mode. This implements the neccessary logic to
945 * perform the task on such devices. Calling it on other devices will 945 * perform the task on such devices. Calling it on other devices will
946 * have -undefined- behaviour. 946 * have -undefined- behaviour.
947 */ 947 */
@@ -966,7 +966,7 @@ unsigned long ata_pci_default_filter(const struct ata_port *ap, struct ata_devic
966{ 966{
967 /* Filter out DMA modes if the device has been configured by 967 /* Filter out DMA modes if the device has been configured by
968 the BIOS as PIO only */ 968 the BIOS as PIO only */
969 969
970 if (ap->ioaddr.bmdma_addr == 0) 970 if (ap->ioaddr.bmdma_addr == 0)
971 xfer_mask &= ~(ATA_MASK_MWDMA | ATA_MASK_UDMA); 971 xfer_mask &= ~(ATA_MASK_MWDMA | ATA_MASK_UDMA);
972 return xfer_mask; 972 return xfer_mask;
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
index 909568f7a72a..94ad4acf8a59 100644
--- a/drivers/scsi/libata-core.c
+++ b/drivers/scsi/libata-core.c
@@ -190,7 +190,7 @@ static const u8 ata_rw_cmds[] = {
190 * ata_rwcmd_protocol - set taskfile r/w commands and protocol 190 * ata_rwcmd_protocol - set taskfile r/w commands and protocol
191 * @qc: command to examine and configure 191 * @qc: command to examine and configure
192 * 192 *
193 * Examine the device configuration and tf->flags to calculate 193 * Examine the device configuration and tf->flags to calculate
194 * the proper read/write commands and protocol to use. 194 * the proper read/write commands and protocol to use.
195 * 195 *
196 * LOCKING: 196 * LOCKING:
@@ -203,7 +203,7 @@ int ata_rwcmd_protocol(struct ata_queued_cmd *qc)
203 u8 cmd; 203 u8 cmd;
204 204
205 int index, fua, lba48, write; 205 int index, fua, lba48, write;
206 206
207 fua = (tf->flags & ATA_TFLAG_FUA) ? 4 : 0; 207 fua = (tf->flags & ATA_TFLAG_FUA) ? 4 : 0;
208 lba48 = (tf->flags & ATA_TFLAG_LBA48) ? 2 : 0; 208 lba48 = (tf->flags & ATA_TFLAG_LBA48) ? 2 : 0;
209 write = (tf->flags & ATA_TFLAG_WRITE) ? 1 : 0; 209 write = (tf->flags & ATA_TFLAG_WRITE) ? 1 : 0;
@@ -1055,7 +1055,7 @@ unsigned int ata_pio_need_iordy(const struct ata_device *adev)
1055 return 0; 1055 return 0;
1056 if (speed > 2) 1056 if (speed > 2)
1057 return 1; 1057 return 1;
1058 1058
1059 /* If we have no drive specific rule, then PIO 2 is non IORDY */ 1059 /* If we have no drive specific rule, then PIO 2 is non IORDY */
1060 1060
1061 if (adev->id[ATA_ID_FIELD_VALID] & 2) { /* EIDE */ 1061 if (adev->id[ATA_ID_FIELD_VALID] & 2) { /* EIDE */
@@ -1583,7 +1583,7 @@ void sata_phy_reset(struct ata_port *ap)
1583 * Obtain the other device on the same cable, or if none is 1583 * Obtain the other device on the same cable, or if none is
1584 * present NULL is returned 1584 * present NULL is returned
1585 */ 1585 */
1586 1586
1587struct ata_device *ata_dev_pair(struct ata_port *ap, struct ata_device *adev) 1587struct ata_device *ata_dev_pair(struct ata_port *ap, struct ata_device *adev)
1588{ 1588{
1589 struct ata_device *pair = &ap->device[1 - adev->devno]; 1589 struct ata_device *pair = &ap->device[1 - adev->devno];
@@ -1620,7 +1620,7 @@ void ata_port_disable(struct ata_port *ap)
1620 * PIO 0-5, MWDMA 0-2 and UDMA 0-6 timings (in nanoseconds). 1620 * PIO 0-5, MWDMA 0-2 and UDMA 0-6 timings (in nanoseconds).
1621 * These were taken from ATA/ATAPI-6 standard, rev 0a, except 1621 * These were taken from ATA/ATAPI-6 standard, rev 0a, except
1622 * for PIO 5, which is a nonstandard extension and UDMA6, which 1622 * for PIO 5, which is a nonstandard extension and UDMA6, which
1623 * is currently supported only by Maxtor drives. 1623 * is currently supported only by Maxtor drives.
1624 */ 1624 */
1625 1625
1626static const struct ata_timing ata_timing[] = { 1626static const struct ata_timing ata_timing[] = {
@@ -1635,11 +1635,11 @@ static const struct ata_timing ata_timing[] = {
1635 { XFER_UDMA_0, 0, 0, 0, 0, 0, 0, 0, 120 }, 1635 { XFER_UDMA_0, 0, 0, 0, 0, 0, 0, 0, 120 },
1636 1636
1637/* { XFER_UDMA_SLOW, 0, 0, 0, 0, 0, 0, 0, 150 }, */ 1637/* { XFER_UDMA_SLOW, 0, 0, 0, 0, 0, 0, 0, 150 }, */
1638 1638
1639 { XFER_MW_DMA_2, 25, 0, 0, 0, 70, 25, 120, 0 }, 1639 { XFER_MW_DMA_2, 25, 0, 0, 0, 70, 25, 120, 0 },
1640 { XFER_MW_DMA_1, 45, 0, 0, 0, 80, 50, 150, 0 }, 1640 { XFER_MW_DMA_1, 45, 0, 0, 0, 80, 50, 150, 0 },
1641 { XFER_MW_DMA_0, 60, 0, 0, 0, 215, 215, 480, 0 }, 1641 { XFER_MW_DMA_0, 60, 0, 0, 0, 215, 215, 480, 0 },
1642 1642
1643 { XFER_SW_DMA_2, 60, 0, 0, 0, 120, 120, 240, 0 }, 1643 { XFER_SW_DMA_2, 60, 0, 0, 0, 120, 120, 240, 0 },
1644 { XFER_SW_DMA_1, 90, 0, 0, 0, 240, 240, 480, 0 }, 1644 { XFER_SW_DMA_1, 90, 0, 0, 0, 240, 240, 480, 0 },
1645 { XFER_SW_DMA_0, 120, 0, 0, 0, 480, 480, 960, 0 }, 1645 { XFER_SW_DMA_0, 120, 0, 0, 0, 480, 480, 960, 0 },
@@ -1692,7 +1692,7 @@ static const struct ata_timing* ata_timing_find_mode(unsigned short speed)
1692 for (t = ata_timing; t->mode != speed; t++) 1692 for (t = ata_timing; t->mode != speed; t++)
1693 if (t->mode == 0xFF) 1693 if (t->mode == 0xFF)
1694 return NULL; 1694 return NULL;
1695 return t; 1695 return t;
1696} 1696}
1697 1697
1698int ata_timing_compute(struct ata_device *adev, unsigned short speed, 1698int ata_timing_compute(struct ata_device *adev, unsigned short speed,
@@ -1702,7 +1702,7 @@ int ata_timing_compute(struct ata_device *adev, unsigned short speed,
1702 struct ata_timing p; 1702 struct ata_timing p;
1703 1703
1704 /* 1704 /*
1705 * Find the mode. 1705 * Find the mode.
1706 */ 1706 */
1707 1707
1708 if (!(s = ata_timing_find_mode(speed))) 1708 if (!(s = ata_timing_find_mode(speed)))
@@ -2078,11 +2078,11 @@ static unsigned int ata_bus_softreset(struct ata_port *ap,
2078 */ 2078 */
2079 msleep(150); 2079 msleep(150);
2080 2080
2081 2081
2082 /* Before we perform post reset processing we want to see if 2082 /* Before we perform post reset processing we want to see if
2083 the bus shows 0xFF because the odd clown forgets the D7 pulldown 2083 the bus shows 0xFF because the odd clown forgets the D7 pulldown
2084 resistor */ 2084 resistor */
2085 2085
2086 if (ata_check_status(ap) == 0xFF) 2086 if (ata_check_status(ap) == 0xFF)
2087 return 1; /* Positive is failure for some reason */ 2087 return 1; /* Positive is failure for some reason */
2088 2088
@@ -2651,22 +2651,22 @@ static const char * const ata_dma_blacklist [] = {
2651 "SanDisk SDP3B-64", NULL, 2651 "SanDisk SDP3B-64", NULL,
2652 "SANYO CD-ROM CRD", NULL, 2652 "SANYO CD-ROM CRD", NULL,
2653 "HITACHI CDR-8", NULL, 2653 "HITACHI CDR-8", NULL,
2654 "HITACHI CDR-8335", NULL, 2654 "HITACHI CDR-8335", NULL,
2655 "HITACHI CDR-8435", NULL, 2655 "HITACHI CDR-8435", NULL,
2656 "Toshiba CD-ROM XM-6202B", NULL, 2656 "Toshiba CD-ROM XM-6202B", NULL,
2657 "TOSHIBA CD-ROM XM-1702BC", NULL, 2657 "TOSHIBA CD-ROM XM-1702BC", NULL,
2658 "CD-532E-A", NULL, 2658 "CD-532E-A", NULL,
2659 "E-IDE CD-ROM CR-840", NULL, 2659 "E-IDE CD-ROM CR-840", NULL,
2660 "CD-ROM Drive/F5A", NULL, 2660 "CD-ROM Drive/F5A", NULL,
2661 "WPI CDD-820", NULL, 2661 "WPI CDD-820", NULL,
2662 "SAMSUNG CD-ROM SC-148C", NULL, 2662 "SAMSUNG CD-ROM SC-148C", NULL,
2663 "SAMSUNG CD-ROM SC", NULL, 2663 "SAMSUNG CD-ROM SC", NULL,
2664 "SanDisk SDP3B-64", NULL, 2664 "SanDisk SDP3B-64", NULL,
2665 "ATAPI CD-ROM DRIVE 40X MAXIMUM",NULL, 2665 "ATAPI CD-ROM DRIVE 40X MAXIMUM",NULL,
2666 "_NEC DV5800A", NULL, 2666 "_NEC DV5800A", NULL,
2667 "SAMSUNG CD-ROM SN-124", "N001" 2667 "SAMSUNG CD-ROM SN-124", "N001"
2668}; 2668};
2669 2669
2670static int ata_strim(char *s, size_t len) 2670static int ata_strim(char *s, size_t len)
2671{ 2671{
2672 len = strnlen(s, len); 2672 len = strnlen(s, len);
@@ -3697,7 +3697,7 @@ static void ata_pio_error(struct ata_port *ap)
3697 if (qc->tf.command != ATA_CMD_PACKET) 3697 if (qc->tf.command != ATA_CMD_PACKET)
3698 printk(KERN_WARNING "ata%u: PIO error\n", ap->id); 3698 printk(KERN_WARNING "ata%u: PIO error\n", ap->id);
3699 3699
3700 /* make sure qc->err_mask is available to 3700 /* make sure qc->err_mask is available to
3701 * know what's wrong and recover 3701 * know what's wrong and recover
3702 */ 3702 */
3703 WARN_ON(qc->err_mask == 0); 3703 WARN_ON(qc->err_mask == 0);
@@ -4695,7 +4695,7 @@ err_free_ret:
4695 * ata_host_set_remove - PCI layer callback for device removal 4695 * ata_host_set_remove - PCI layer callback for device removal
4696 * @host_set: ATA host set that was removed 4696 * @host_set: ATA host set that was removed
4697 * 4697 *
4698 * Unregister all objects associated with this host set. Free those 4698 * Unregister all objects associated with this host set. Free those
4699 * objects. 4699 * objects.
4700 * 4700 *
4701 * LOCKING: 4701 * LOCKING:
@@ -4967,6 +4967,8 @@ EXPORT_SYMBOL_GPL(ata_std_postreset);
4967EXPORT_SYMBOL_GPL(ata_std_probe_reset); 4967EXPORT_SYMBOL_GPL(ata_std_probe_reset);
4968EXPORT_SYMBOL_GPL(ata_drive_probe_reset); 4968EXPORT_SYMBOL_GPL(ata_drive_probe_reset);
4969EXPORT_SYMBOL_GPL(ata_dev_revalidate); 4969EXPORT_SYMBOL_GPL(ata_dev_revalidate);
4970EXPORT_SYMBOL_GPL(ata_dev_classify);
4971EXPORT_SYMBOL_GPL(ata_dev_pair);
4970EXPORT_SYMBOL_GPL(ata_port_disable); 4972EXPORT_SYMBOL_GPL(ata_port_disable);
4971EXPORT_SYMBOL_GPL(ata_ratelimit); 4973EXPORT_SYMBOL_GPL(ata_ratelimit);
4972EXPORT_SYMBOL_GPL(ata_busy_sleep); 4974EXPORT_SYMBOL_GPL(ata_busy_sleep);
@@ -4977,7 +4979,6 @@ EXPORT_SYMBOL_GPL(ata_scsi_error);
4977EXPORT_SYMBOL_GPL(ata_scsi_slave_config); 4979EXPORT_SYMBOL_GPL(ata_scsi_slave_config);
4978EXPORT_SYMBOL_GPL(ata_scsi_release); 4980EXPORT_SYMBOL_GPL(ata_scsi_release);
4979EXPORT_SYMBOL_GPL(ata_host_intr); 4981EXPORT_SYMBOL_GPL(ata_host_intr);
4980EXPORT_SYMBOL_GPL(ata_dev_classify);
4981EXPORT_SYMBOL_GPL(ata_id_string); 4982EXPORT_SYMBOL_GPL(ata_id_string);
4982EXPORT_SYMBOL_GPL(ata_id_c_string); 4983EXPORT_SYMBOL_GPL(ata_id_c_string);
4983EXPORT_SYMBOL_GPL(ata_scsi_simulate); 4984EXPORT_SYMBOL_GPL(ata_scsi_simulate);
diff --git a/drivers/scsi/libata-scsi.c b/drivers/scsi/libata-scsi.c
index 1fd3826da97e..b7df37ed4393 100644
--- a/drivers/scsi/libata-scsi.c
+++ b/drivers/scsi/libata-scsi.c
@@ -256,7 +256,7 @@ int ata_task_ioctl(struct scsi_device *scsidev, void __user *arg)
256 scsi_cmd[14] = args[0]; 256 scsi_cmd[14] = args[0];
257 257
258 /* Good values for timeout and retries? Values below 258 /* Good values for timeout and retries? Values below
259 from scsi_ioctl_send_command() for default case... */ 259 from scsi_ioctl_send_command() for default case... */
260 if (scsi_execute_req(scsidev, scsi_cmd, DMA_NONE, NULL, 0, &sshdr, 260 if (scsi_execute_req(scsidev, scsi_cmd, DMA_NONE, NULL, 0, &sshdr,
261 (10*HZ), 5)) 261 (10*HZ), 5))
262 rc = -EIO; 262 rc = -EIO;
@@ -438,7 +438,7 @@ int ata_scsi_device_suspend(struct scsi_device *sdev, pm_message_t state)
438 * LOCKING: 438 * LOCKING:
439 * spin_lock_irqsave(host_set lock) 439 * spin_lock_irqsave(host_set lock)
440 */ 440 */
441void ata_to_sense_error(unsigned id, u8 drv_stat, u8 drv_err, u8 *sk, u8 *asc, 441void ata_to_sense_error(unsigned id, u8 drv_stat, u8 drv_err, u8 *sk, u8 *asc,
442 u8 *ascq) 442 u8 *ascq)
443{ 443{
444 int i; 444 int i;
@@ -495,7 +495,7 @@ void ata_to_sense_error(unsigned id, u8 drv_stat, u8 drv_err, u8 *sk, u8 *asc,
495 /* Look for drv_err */ 495 /* Look for drv_err */
496 for (i = 0; sense_table[i][0] != 0xFF; i++) { 496 for (i = 0; sense_table[i][0] != 0xFF; i++) {
497 /* Look for best matches first */ 497 /* Look for best matches first */
498 if ((sense_table[i][0] & drv_err) == 498 if ((sense_table[i][0] & drv_err) ==
499 sense_table[i][0]) { 499 sense_table[i][0]) {
500 *sk = sense_table[i][1]; 500 *sk = sense_table[i][1];
501 *asc = sense_table[i][2]; 501 *asc = sense_table[i][2];
@@ -518,7 +518,7 @@ void ata_to_sense_error(unsigned id, u8 drv_stat, u8 drv_err, u8 *sk, u8 *asc,
518 } 518 }
519 } 519 }
520 /* No error? Undecoded? */ 520 /* No error? Undecoded? */
521 printk(KERN_WARNING "ata%u: no sense translation for status: 0x%02x\n", 521 printk(KERN_WARNING "ata%u: no sense translation for status: 0x%02x\n",
522 id, drv_stat); 522 id, drv_stat);
523 523
524 /* We need a sensible error return here, which is tricky, and one 524 /* We need a sensible error return here, which is tricky, and one
@@ -1150,14 +1150,14 @@ static unsigned int ata_scsi_verify_xlat(struct ata_queued_cmd *qc, const u8 *sc
1150 1150
1151 DPRINTK("block %u track %u cyl %u head %u sect %u\n", 1151 DPRINTK("block %u track %u cyl %u head %u sect %u\n",
1152 (u32)block, track, cyl, head, sect); 1152 (u32)block, track, cyl, head, sect);
1153 1153
1154 /* Check whether the converted CHS can fit. 1154 /* Check whether the converted CHS can fit.
1155 Cylinder: 0-65535 1155 Cylinder: 0-65535
1156 Head: 0-15 1156 Head: 0-15
1157 Sector: 1-255*/ 1157 Sector: 1-255*/
1158 if ((cyl >> 16) || (head >> 4) || (sect >> 8) || (!sect)) 1158 if ((cyl >> 16) || (head >> 4) || (sect >> 8) || (!sect))
1159 goto out_of_range; 1159 goto out_of_range;
1160 1160
1161 tf->command = ATA_CMD_VERIFY; 1161 tf->command = ATA_CMD_VERIFY;
1162 tf->nsect = n_block & 0xff; /* Sector count 0 means 256 sectors */ 1162 tf->nsect = n_block & 0xff; /* Sector count 0 means 256 sectors */
1163 tf->lbal = sect; 1163 tf->lbal = sect;
@@ -1289,7 +1289,7 @@ static unsigned int ata_scsi_rw_xlat(struct ata_queued_cmd *qc, const u8 *scsicm
1289 tf->lbal = block & 0xff; 1289 tf->lbal = block & 0xff;
1290 1290
1291 tf->device |= ATA_LBA; 1291 tf->device |= ATA_LBA;
1292 } else { 1292 } else {
1293 /* CHS */ 1293 /* CHS */
1294 u32 sect, head, cyl, track; 1294 u32 sect, head, cyl, track;
1295 1295
@@ -1309,8 +1309,8 @@ static unsigned int ata_scsi_rw_xlat(struct ata_queued_cmd *qc, const u8 *scsicm
1309 DPRINTK("block %u track %u cyl %u head %u sect %u\n", 1309 DPRINTK("block %u track %u cyl %u head %u sect %u\n",
1310 (u32)block, track, cyl, head, sect); 1310 (u32)block, track, cyl, head, sect);
1311 1311
1312 /* Check whether the converted CHS can fit. 1312 /* Check whether the converted CHS can fit.
1313 Cylinder: 0-65535 1313 Cylinder: 0-65535
1314 Head: 0-15 1314 Head: 0-15
1315 Sector: 1-255*/ 1315 Sector: 1-255*/
1316 if ((cyl >> 16) || (head >> 4) || (sect >> 8) || (!sect)) 1316 if ((cyl >> 16) || (head >> 4) || (sect >> 8) || (!sect))
@@ -1697,7 +1697,7 @@ unsigned int ata_scsiop_inq_83(struct ata_scsi_args *args, u8 *rbuf,
1697 1697
1698 if (buflen > (ATA_SERNO_LEN + num + 3)) { 1698 if (buflen > (ATA_SERNO_LEN + num + 3)) {
1699 /* piv=0, assoc=lu, code_set=ACSII, designator=vendor */ 1699 /* piv=0, assoc=lu, code_set=ACSII, designator=vendor */
1700 rbuf[num + 0] = 2; 1700 rbuf[num + 0] = 2;
1701 rbuf[num + 3] = ATA_SERNO_LEN; 1701 rbuf[num + 3] = ATA_SERNO_LEN;
1702 num += 4; 1702 num += 4;
1703 ata_id_string(args->id, (unsigned char *) rbuf + num, 1703 ata_id_string(args->id, (unsigned char *) rbuf + num,
@@ -1707,8 +1707,8 @@ unsigned int ata_scsiop_inq_83(struct ata_scsi_args *args, u8 *rbuf,
1707 if (buflen > (sat_model_serial_desc_len + num + 3)) { 1707 if (buflen > (sat_model_serial_desc_len + num + 3)) {
1708 /* SAT defined lu model and serial numbers descriptor */ 1708 /* SAT defined lu model and serial numbers descriptor */
1709 /* piv=0, assoc=lu, code_set=ACSII, designator=t10 vendor id */ 1709 /* piv=0, assoc=lu, code_set=ACSII, designator=t10 vendor id */
1710 rbuf[num + 0] = 2; 1710 rbuf[num + 0] = 2;
1711 rbuf[num + 1] = 1; 1711 rbuf[num + 1] = 1;
1712 rbuf[num + 3] = sat_model_serial_desc_len; 1712 rbuf[num + 3] = sat_model_serial_desc_len;
1713 num += 4; 1713 num += 4;
1714 memcpy(rbuf + num, "ATA ", 8); 1714 memcpy(rbuf + num, "ATA ", 8);
diff --git a/drivers/scsi/sata_sil24.c b/drivers/scsi/sata_sil24.c
index 3efebea211f2..068c98a4111b 100644
--- a/drivers/scsi/sata_sil24.c
+++ b/drivers/scsi/sata_sil24.c
@@ -342,7 +342,7 @@ static struct ata_port_info sil24_port_info[] = {
342 .udma_mask = 0x3f, /* udma0-5 */ 342 .udma_mask = 0x3f, /* udma0-5 */
343 .port_ops = &sil24_ops, 343 .port_ops = &sil24_ops,
344 }, 344 },
345 /* sil_3132 */ 345 /* sil_3132 */
346 { 346 {
347 .sht = &sil24_sht, 347 .sht = &sil24_sht,
348 .host_flags = ATA_FLAG_SATA | ATA_FLAG_NO_LEGACY | 348 .host_flags = ATA_FLAG_SATA | ATA_FLAG_NO_LEGACY |
diff --git a/drivers/scsi/sata_vsc.c b/drivers/scsi/sata_vsc.c
index 9701a806539d..836bbbb26ff2 100644
--- a/drivers/scsi/sata_vsc.c
+++ b/drivers/scsi/sata_vsc.c
@@ -230,11 +230,11 @@ static irqreturn_t vsc_sata_interrupt (int irq, void *dev_instance,
230 handled += ata_host_intr(ap, qc); 230 handled += ata_host_intr(ap, qc);
231 } else if (is_vsc_sata_int_err(i, int_status)) { 231 } else if (is_vsc_sata_int_err(i, int_status)) {
232 /* 232 /*
233 * On some chips (i.e. Intel 31244), an error 233 * On some chips (i.e. Intel 31244), an error
234 * interrupt will sneak in at initialization 234 * interrupt will sneak in at initialization
235 * time (phy state changes). Clearing the SCR 235 * time (phy state changes). Clearing the SCR
236 * error register is not required, but it prevents 236 * error register is not required, but it prevents
237 * the phy state change interrupts from recurring 237 * the phy state change interrupts from recurring
238 * later. 238 * later.
239 */ 239 */
240 u32 err_status; 240 u32 err_status;