diff options
author | Adrian Bunk <bunk@stusta.de> | 2006-03-24 06:15:52 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-03-24 10:33:21 -0500 |
commit | 29c6e48601065908e7933c0d8440f383fffe155b (patch) | |
tree | f72cd38d9b533ba897b95dd1047edf3e378d6a46 | |
parent | caa9ee771de3195ae85ac6f8cb550f53e9ecdd82 (diff) |
[PATCH] fs/9p/: possible cleanups
- mux.c: v9fs_poll_mux() was inline but not static resuling in needless
object size bloat
- mux.c: remove all "inline"s: gcc should know best what to inline
- #if 0 the following unused global functions:
- 9p.c: v9fs_v9fs_t_flush()
- conv.c: v9fs_create_tauth()
- mux.c: v9fs_mux_rpcnb()
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Cc: Eric Van Hensbergen <ericvh@ericvh.myip.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r-- | fs/9p/9p.c | 2 | ||||
-rw-r--r-- | fs/9p/9p.h | 2 | ||||
-rw-r--r-- | fs/9p/conv.c | 2 | ||||
-rw-r--r-- | fs/9p/conv.h | 1 | ||||
-rw-r--r-- | fs/9p/mux.c | 11 | ||||
-rw-r--r-- | fs/9p/mux.h | 2 |
6 files changed, 10 insertions, 10 deletions
diff --git a/fs/9p/9p.c b/fs/9p/9p.c index f86a28d1d6a6..c148e6ba07e5 100644 --- a/fs/9p/9p.c +++ b/fs/9p/9p.c | |||
@@ -148,6 +148,7 @@ v9fs_t_clunk(struct v9fs_session_info *v9ses, u32 fid) | |||
148 | return ret; | 148 | return ret; |
149 | } | 149 | } |
150 | 150 | ||
151 | #if 0 | ||
151 | /** | 152 | /** |
152 | * v9fs_v9fs_t_flush - flush a pending transaction | 153 | * v9fs_v9fs_t_flush - flush a pending transaction |
153 | * @v9ses: 9P2000 session information | 154 | * @v9ses: 9P2000 session information |
@@ -171,6 +172,7 @@ int v9fs_t_flush(struct v9fs_session_info *v9ses, u16 oldtag) | |||
171 | 172 | ||
172 | return ret; | 173 | return ret; |
173 | } | 174 | } |
175 | #endif /* 0 */ | ||
174 | 176 | ||
175 | /** | 177 | /** |
176 | * v9fs_t_stat - read a file's meta-data | 178 | * v9fs_t_stat - read a file's meta-data |
diff --git a/fs/9p/9p.h b/fs/9p/9p.h index 0cd374d94717..95d72aec1c1a 100644 --- a/fs/9p/9p.h +++ b/fs/9p/9p.h | |||
@@ -348,8 +348,6 @@ int v9fs_t_attach(struct v9fs_session_info *v9ses, char *uname, char *aname, | |||
348 | 348 | ||
349 | int v9fs_t_clunk(struct v9fs_session_info *v9ses, u32 fid); | 349 | int v9fs_t_clunk(struct v9fs_session_info *v9ses, u32 fid); |
350 | 350 | ||
351 | int v9fs_t_flush(struct v9fs_session_info *v9ses, u16 oldtag); | ||
352 | |||
353 | int v9fs_t_stat(struct v9fs_session_info *v9ses, u32 fid, | 351 | int v9fs_t_stat(struct v9fs_session_info *v9ses, u32 fid, |
354 | struct v9fs_fcall **rcall); | 352 | struct v9fs_fcall **rcall); |
355 | 353 | ||
diff --git a/fs/9p/conv.c b/fs/9p/conv.c index bf1f10067960..bba817142465 100644 --- a/fs/9p/conv.c +++ b/fs/9p/conv.c | |||
@@ -536,6 +536,7 @@ struct v9fs_fcall *v9fs_create_tversion(u32 msize, char *version) | |||
536 | return fc; | 536 | return fc; |
537 | } | 537 | } |
538 | 538 | ||
539 | #if 0 | ||
539 | struct v9fs_fcall *v9fs_create_tauth(u32 afid, char *uname, char *aname) | 540 | struct v9fs_fcall *v9fs_create_tauth(u32 afid, char *uname, char *aname) |
540 | { | 541 | { |
541 | int size; | 542 | int size; |
@@ -559,6 +560,7 @@ struct v9fs_fcall *v9fs_create_tauth(u32 afid, char *uname, char *aname) | |||
559 | error: | 560 | error: |
560 | return fc; | 561 | return fc; |
561 | } | 562 | } |
563 | #endif /* 0 */ | ||
562 | 564 | ||
563 | struct v9fs_fcall * | 565 | struct v9fs_fcall * |
564 | v9fs_create_tattach(u32 fid, u32 afid, char *uname, char *aname) | 566 | v9fs_create_tattach(u32 fid, u32 afid, char *uname, char *aname) |
diff --git a/fs/9p/conv.h b/fs/9p/conv.h index 26a736e4a2e7..f5896628dae4 100644 --- a/fs/9p/conv.h +++ b/fs/9p/conv.h | |||
@@ -33,7 +33,6 @@ int v9fs_deserialize_fcall(void *buf, u32 buflen, struct v9fs_fcall *rcall, | |||
33 | void v9fs_set_tag(struct v9fs_fcall *fc, u16 tag); | 33 | void v9fs_set_tag(struct v9fs_fcall *fc, u16 tag); |
34 | 34 | ||
35 | struct v9fs_fcall *v9fs_create_tversion(u32 msize, char *version); | 35 | struct v9fs_fcall *v9fs_create_tversion(u32 msize, char *version); |
36 | struct v9fs_fcall *v9fs_create_tauth(u32 afid, char *uname, char *aname); | ||
37 | struct v9fs_fcall *v9fs_create_tattach(u32 fid, u32 afid, char *uname, | 36 | struct v9fs_fcall *v9fs_create_tattach(u32 fid, u32 afid, char *uname, |
38 | char *aname); | 37 | char *aname); |
39 | struct v9fs_fcall *v9fs_create_tflush(u16 oldtag); | 38 | struct v9fs_fcall *v9fs_create_tflush(u16 oldtag); |
diff --git a/fs/9p/mux.c b/fs/9p/mux.c index 8e8356c1c229..e2ae60adda99 100644 --- a/fs/9p/mux.c +++ b/fs/9p/mux.c | |||
@@ -143,7 +143,7 @@ void v9fs_mux_global_exit(void) | |||
143 | * | 143 | * |
144 | * The current implementation returns sqrt of the number of mounts. | 144 | * The current implementation returns sqrt of the number of mounts. |
145 | */ | 145 | */ |
146 | inline int v9fs_mux_calc_poll_procs(int muxnum) | 146 | static int v9fs_mux_calc_poll_procs(int muxnum) |
147 | { | 147 | { |
148 | int n; | 148 | int n; |
149 | 149 | ||
@@ -384,7 +384,7 @@ v9fs_pollwait(struct file *filp, wait_queue_head_t * wait_address, | |||
384 | /** | 384 | /** |
385 | * v9fs_poll_mux - polls a mux and schedules read or write works if necessary | 385 | * v9fs_poll_mux - polls a mux and schedules read or write works if necessary |
386 | */ | 386 | */ |
387 | static inline void v9fs_poll_mux(struct v9fs_mux_data *m) | 387 | static void v9fs_poll_mux(struct v9fs_mux_data *m) |
388 | { | 388 | { |
389 | int n; | 389 | int n; |
390 | 390 | ||
@@ -762,9 +762,8 @@ static struct v9fs_req *v9fs_send_request(struct v9fs_mux_data *m, | |||
762 | return req; | 762 | return req; |
763 | } | 763 | } |
764 | 764 | ||
765 | static inline void | 765 | static void v9fs_mux_flush_cb(void *a, struct v9fs_fcall *tc, |
766 | v9fs_mux_flush_cb(void *a, struct v9fs_fcall *tc, struct v9fs_fcall *rc, | 766 | struct v9fs_fcall *rc, int err) |
767 | int err) | ||
768 | { | 767 | { |
769 | v9fs_mux_req_callback cb; | 768 | v9fs_mux_req_callback cb; |
770 | int tag; | 769 | int tag; |
@@ -902,6 +901,7 @@ v9fs_mux_rpc(struct v9fs_mux_data *m, struct v9fs_fcall *tc, | |||
902 | return err; | 901 | return err; |
903 | } | 902 | } |
904 | 903 | ||
904 | #if 0 | ||
905 | /** | 905 | /** |
906 | * v9fs_mux_rpcnb - sends 9P request without waiting for response. | 906 | * v9fs_mux_rpcnb - sends 9P request without waiting for response. |
907 | * @m: mux data | 907 | * @m: mux data |
@@ -925,6 +925,7 @@ int v9fs_mux_rpcnb(struct v9fs_mux_data *m, struct v9fs_fcall *tc, | |||
925 | dprintk(DEBUG_MUX, "mux %p tc %p tag %d\n", m, tc, req->tag); | 925 | dprintk(DEBUG_MUX, "mux %p tc %p tag %d\n", m, tc, req->tag); |
926 | return 0; | 926 | return 0; |
927 | } | 927 | } |
928 | #endif /* 0 */ | ||
928 | 929 | ||
929 | /** | 930 | /** |
930 | * v9fs_mux_cancel - cancel all pending requests with error | 931 | * v9fs_mux_cancel - cancel all pending requests with error |
diff --git a/fs/9p/mux.h b/fs/9p/mux.h index 9473b84f24b2..17144fdfa11b 100644 --- a/fs/9p/mux.h +++ b/fs/9p/mux.h | |||
@@ -50,8 +50,6 @@ void v9fs_mux_destroy(struct v9fs_mux_data *); | |||
50 | int v9fs_mux_send(struct v9fs_mux_data *m, struct v9fs_fcall *tc); | 50 | int v9fs_mux_send(struct v9fs_mux_data *m, struct v9fs_fcall *tc); |
51 | struct v9fs_fcall *v9fs_mux_recv(struct v9fs_mux_data *m); | 51 | struct v9fs_fcall *v9fs_mux_recv(struct v9fs_mux_data *m); |
52 | int v9fs_mux_rpc(struct v9fs_mux_data *m, struct v9fs_fcall *tc, struct v9fs_fcall **rc); | 52 | int v9fs_mux_rpc(struct v9fs_mux_data *m, struct v9fs_fcall *tc, struct v9fs_fcall **rc); |
53 | int v9fs_mux_rpcnb(struct v9fs_mux_data *m, struct v9fs_fcall *tc, | ||
54 | v9fs_mux_req_callback cb, void *a); | ||
55 | 53 | ||
56 | void v9fs_mux_flush(struct v9fs_mux_data *m, int sendflush); | 54 | void v9fs_mux_flush(struct v9fs_mux_data *m, int sendflush); |
57 | void v9fs_mux_cancel(struct v9fs_mux_data *m, int err); | 55 | void v9fs_mux_cancel(struct v9fs_mux_data *m, int err); |