diff options
author | H. J. Lu <hjl.tools@gmail.com> | 2012-02-19 20:50:46 -0500 |
---|---|---|
committer | H. Peter Anvin <hpa@zytor.com> | 2012-02-20 15:48:48 -0500 |
commit | ee4fa23c4bfcc635d077a9633d405610de45bc70 (patch) | |
tree | 45cc8cadc91c44dfed9921d03ba36606f80ac072 | |
parent | da88cea1200b9df65a7811a3920aa5a4be7dab9f (diff) |
compat: Use COMPAT_USE_64BIT_TIME in net/compat.c
Handle 64-bit time structures in the networking core compat code.
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Cc: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/compat.c | 65 |
1 files changed, 40 insertions, 25 deletions
diff --git a/net/compat.c b/net/compat.c index 6def90e0a112..73bf0e06f3d7 100644 --- a/net/compat.c +++ b/net/compat.c | |||
@@ -219,8 +219,6 @@ Efault: | |||
219 | 219 | ||
220 | int put_cmsg_compat(struct msghdr *kmsg, int level, int type, int len, void *data) | 220 | int put_cmsg_compat(struct msghdr *kmsg, int level, int type, int len, void *data) |
221 | { | 221 | { |
222 | struct compat_timeval ctv; | ||
223 | struct compat_timespec cts[3]; | ||
224 | struct compat_cmsghdr __user *cm = (struct compat_cmsghdr __user *) kmsg->msg_control; | 222 | struct compat_cmsghdr __user *cm = (struct compat_cmsghdr __user *) kmsg->msg_control; |
225 | struct compat_cmsghdr cmhdr; | 223 | struct compat_cmsghdr cmhdr; |
226 | int cmlen; | 224 | int cmlen; |
@@ -230,24 +228,28 @@ int put_cmsg_compat(struct msghdr *kmsg, int level, int type, int len, void *dat | |||
230 | return 0; /* XXX: return error? check spec. */ | 228 | return 0; /* XXX: return error? check spec. */ |
231 | } | 229 | } |
232 | 230 | ||
233 | if (level == SOL_SOCKET && type == SCM_TIMESTAMP) { | 231 | if (!COMPAT_USE_64BIT_TIME) { |
234 | struct timeval *tv = (struct timeval *)data; | 232 | struct compat_timeval ctv; |
235 | ctv.tv_sec = tv->tv_sec; | 233 | struct compat_timespec cts[3]; |
236 | ctv.tv_usec = tv->tv_usec; | 234 | if (level == SOL_SOCKET && type == SCM_TIMESTAMP) { |
237 | data = &ctv; | 235 | struct timeval *tv = (struct timeval *)data; |
238 | len = sizeof(ctv); | 236 | ctv.tv_sec = tv->tv_sec; |
239 | } | 237 | ctv.tv_usec = tv->tv_usec; |
240 | if (level == SOL_SOCKET && | 238 | data = &ctv; |
241 | (type == SCM_TIMESTAMPNS || type == SCM_TIMESTAMPING)) { | 239 | len = sizeof(ctv); |
242 | int count = type == SCM_TIMESTAMPNS ? 1 : 3; | 240 | } |
243 | int i; | 241 | if (level == SOL_SOCKET && |
244 | struct timespec *ts = (struct timespec *)data; | 242 | (type == SCM_TIMESTAMPNS || type == SCM_TIMESTAMPING)) { |
245 | for (i = 0; i < count; i++) { | 243 | int count = type == SCM_TIMESTAMPNS ? 1 : 3; |
246 | cts[i].tv_sec = ts[i].tv_sec; | 244 | int i; |
247 | cts[i].tv_nsec = ts[i].tv_nsec; | 245 | struct timespec *ts = (struct timespec *)data; |
246 | for (i = 0; i < count; i++) { | ||
247 | cts[i].tv_sec = ts[i].tv_sec; | ||
248 | cts[i].tv_nsec = ts[i].tv_nsec; | ||
249 | } | ||
250 | data = &cts; | ||
251 | len = sizeof(cts[0]) * count; | ||
248 | } | 252 | } |
249 | data = &cts; | ||
250 | len = sizeof(cts[0]) * count; | ||
251 | } | 253 | } |
252 | 254 | ||
253 | cmlen = CMSG_COMPAT_LEN(len); | 255 | cmlen = CMSG_COMPAT_LEN(len); |
@@ -454,11 +456,15 @@ static int compat_sock_getsockopt(struct socket *sock, int level, int optname, | |||
454 | 456 | ||
455 | int compat_sock_get_timestamp(struct sock *sk, struct timeval __user *userstamp) | 457 | int compat_sock_get_timestamp(struct sock *sk, struct timeval __user *userstamp) |
456 | { | 458 | { |
457 | struct compat_timeval __user *ctv = | 459 | struct compat_timeval __user *ctv; |
458 | (struct compat_timeval __user *) userstamp; | 460 | int err; |
459 | int err = -ENOENT; | ||
460 | struct timeval tv; | 461 | struct timeval tv; |
461 | 462 | ||
463 | if (COMPAT_USE_64BIT_TIME) | ||
464 | return sock_get_timestamp(sk, userstamp); | ||
465 | |||
466 | ctv = (struct compat_timeval __user *) userstamp; | ||
467 | err = -ENOENT; | ||
462 | if (!sock_flag(sk, SOCK_TIMESTAMP)) | 468 | if (!sock_flag(sk, SOCK_TIMESTAMP)) |
463 | sock_enable_timestamp(sk, SOCK_TIMESTAMP); | 469 | sock_enable_timestamp(sk, SOCK_TIMESTAMP); |
464 | tv = ktime_to_timeval(sk->sk_stamp); | 470 | tv = ktime_to_timeval(sk->sk_stamp); |
@@ -478,11 +484,15 @@ EXPORT_SYMBOL(compat_sock_get_timestamp); | |||
478 | 484 | ||
479 | int compat_sock_get_timestampns(struct sock *sk, struct timespec __user *userstamp) | 485 | int compat_sock_get_timestampns(struct sock *sk, struct timespec __user *userstamp) |
480 | { | 486 | { |
481 | struct compat_timespec __user *ctv = | 487 | struct compat_timespec __user *ctv; |
482 | (struct compat_timespec __user *) userstamp; | 488 | int err; |
483 | int err = -ENOENT; | ||
484 | struct timespec ts; | 489 | struct timespec ts; |
485 | 490 | ||
491 | if (COMPAT_USE_64BIT_TIME) | ||
492 | return sock_get_timestampns (sk, userstamp); | ||
493 | |||
494 | ctv = (struct compat_timespec __user *) userstamp; | ||
495 | err = -ENOENT; | ||
486 | if (!sock_flag(sk, SOCK_TIMESTAMP)) | 496 | if (!sock_flag(sk, SOCK_TIMESTAMP)) |
487 | sock_enable_timestamp(sk, SOCK_TIMESTAMP); | 497 | sock_enable_timestamp(sk, SOCK_TIMESTAMP); |
488 | ts = ktime_to_timespec(sk->sk_stamp); | 498 | ts = ktime_to_timespec(sk->sk_stamp); |
@@ -767,6 +777,11 @@ asmlinkage long compat_sys_recvmmsg(int fd, struct compat_mmsghdr __user *mmsg, | |||
767 | int datagrams; | 777 | int datagrams; |
768 | struct timespec ktspec; | 778 | struct timespec ktspec; |
769 | 779 | ||
780 | if (COMPAT_USE_64BIT_TIME) | ||
781 | return __sys_recvmmsg(fd, (struct mmsghdr __user *)mmsg, vlen, | ||
782 | flags | MSG_CMSG_COMPAT, | ||
783 | (struct timespec *) timeout); | ||
784 | |||
770 | if (timeout == NULL) | 785 | if (timeout == NULL) |
771 | return __sys_recvmmsg(fd, (struct mmsghdr __user *)mmsg, vlen, | 786 | return __sys_recvmmsg(fd, (struct mmsghdr __user *)mmsg, vlen, |
772 | flags | MSG_CMSG_COMPAT, NULL); | 787 | flags | MSG_CMSG_COMPAT, NULL); |