aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJ. Bruce Fields <bfields@citi.umich.edu>2007-11-19 19:09:50 -0500
committerJ. Bruce Fields <bfields@citi.umich.edu>2008-02-01 16:42:05 -0500
commit49ba87811f34a0219dc7a373cd24aa68450f2058 (patch)
treec0e50e1378d002c5346451f3bf0aa031f893ff20
parenta186e767473bd329122f0229b91573b9b6fa43c1 (diff)
nfsd: eliminate final bogus case from setclientid logic
We're supposed to generate a different cl_confirm verifier for each new client, so these to cl_confirm values should never be the same. Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
-rw-r--r--fs/nfsd/nfs4state.c7
1 files changed, 1 insertions, 6 deletions
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 242fee7c1018..035e70a01027 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -769,7 +769,7 @@ nfsd4_setclientid(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
769 if (new == NULL) 769 if (new == NULL)
770 goto out; 770 goto out;
771 gen_clid(new); 771 gen_clid(new);
772 } else if (!same_verf(&conf->cl_confirm, &unconf->cl_confirm)) { 772 } else {
773 /* 773 /*
774 * RFC 3530 14.2.33 CASE 3: 774 * RFC 3530 14.2.33 CASE 3:
775 * probable client reboot; state will be removed if 775 * probable client reboot; state will be removed if
@@ -780,11 +780,6 @@ nfsd4_setclientid(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
780 if (new == NULL) 780 if (new == NULL)
781 goto out; 781 goto out;
782 gen_clid(new); 782 gen_clid(new);
783 } else {
784 /* No cases hit !!! */
785 status = nfserr_inval;
786 goto out;
787
788 } 783 }
789 copy_verf(new, &clverifier); 784 copy_verf(new, &clverifier);
790 new->cl_addr = sin->sin_addr.s_addr; 785 new->cl_addr = sin->sin_addr.s_addr;