diff options
author | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2008-01-17 18:49:59 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2008-01-17 18:49:59 -0500 |
commit | 30472908d50cf726a68c2b444127a1dafae8a91c (patch) | |
tree | 6277cdad2fe6949b9c7aa160e1de435fe367f18e | |
parent | abde3dff2496d9d44a218cf8e2a17c2383f20b22 (diff) | |
parent | e415e6ea0cd36ece29c7b12232286b5ca097ac96 (diff) |
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6
* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6:
[NIU]: Fix 1G PHY link state handling.
[NET]: Fix TX timeout regression in Intel drivers.
-rw-r--r-- | drivers/net/e1000/e1000_main.c | 9 | ||||
-rw-r--r-- | drivers/net/e1000e/netdev.c | 7 | ||||
-rw-r--r-- | drivers/net/ixgbe/ixgbe_main.c | 7 | ||||
-rw-r--r-- | drivers/net/niu.c | 3 |
4 files changed, 19 insertions, 7 deletions
diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index 13d57b0a88fa..0c9a6f7104d2 100644 --- a/drivers/net/e1000/e1000_main.c +++ b/drivers/net/e1000/e1000_main.c | |||
@@ -3919,7 +3919,7 @@ e1000_clean(struct napi_struct *napi, int budget) | |||
3919 | { | 3919 | { |
3920 | struct e1000_adapter *adapter = container_of(napi, struct e1000_adapter, napi); | 3920 | struct e1000_adapter *adapter = container_of(napi, struct e1000_adapter, napi); |
3921 | struct net_device *poll_dev = adapter->netdev; | 3921 | struct net_device *poll_dev = adapter->netdev; |
3922 | int work_done = 0; | 3922 | int tx_cleaned = 0, work_done = 0; |
3923 | 3923 | ||
3924 | /* Must NOT use netdev_priv macro here. */ | 3924 | /* Must NOT use netdev_priv macro here. */ |
3925 | adapter = poll_dev->priv; | 3925 | adapter = poll_dev->priv; |
@@ -3929,14 +3929,17 @@ e1000_clean(struct napi_struct *napi, int budget) | |||
3929 | * simultaneously. A failure obtaining the lock means | 3929 | * simultaneously. A failure obtaining the lock means |
3930 | * tx_ring[0] is currently being cleaned anyway. */ | 3930 | * tx_ring[0] is currently being cleaned anyway. */ |
3931 | if (spin_trylock(&adapter->tx_queue_lock)) { | 3931 | if (spin_trylock(&adapter->tx_queue_lock)) { |
3932 | e1000_clean_tx_irq(adapter, | 3932 | tx_cleaned = e1000_clean_tx_irq(adapter, |
3933 | &adapter->tx_ring[0]); | 3933 | &adapter->tx_ring[0]); |
3934 | spin_unlock(&adapter->tx_queue_lock); | 3934 | spin_unlock(&adapter->tx_queue_lock); |
3935 | } | 3935 | } |
3936 | 3936 | ||
3937 | adapter->clean_rx(adapter, &adapter->rx_ring[0], | 3937 | adapter->clean_rx(adapter, &adapter->rx_ring[0], |
3938 | &work_done, budget); | 3938 | &work_done, budget); |
3939 | 3939 | ||
3940 | if (tx_cleaned) | ||
3941 | work_done = budget; | ||
3942 | |||
3940 | /* If budget not fully consumed, exit the polling mode */ | 3943 | /* If budget not fully consumed, exit the polling mode */ |
3941 | if (work_done < budget) { | 3944 | if (work_done < budget) { |
3942 | if (likely(adapter->itr_setting & 3)) | 3945 | if (likely(adapter->itr_setting & 3)) |
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c index 4a6fc7453776..2ab3bfbb8a63 100644 --- a/drivers/net/e1000e/netdev.c +++ b/drivers/net/e1000e/netdev.c | |||
@@ -1384,7 +1384,7 @@ static int e1000_clean(struct napi_struct *napi, int budget) | |||
1384 | { | 1384 | { |
1385 | struct e1000_adapter *adapter = container_of(napi, struct e1000_adapter, napi); | 1385 | struct e1000_adapter *adapter = container_of(napi, struct e1000_adapter, napi); |
1386 | struct net_device *poll_dev = adapter->netdev; | 1386 | struct net_device *poll_dev = adapter->netdev; |
1387 | int work_done = 0; | 1387 | int tx_cleaned = 0, work_done = 0; |
1388 | 1388 | ||
1389 | /* Must NOT use netdev_priv macro here. */ | 1389 | /* Must NOT use netdev_priv macro here. */ |
1390 | adapter = poll_dev->priv; | 1390 | adapter = poll_dev->priv; |
@@ -1394,12 +1394,15 @@ static int e1000_clean(struct napi_struct *napi, int budget) | |||
1394 | * simultaneously. A failure obtaining the lock means | 1394 | * simultaneously. A failure obtaining the lock means |
1395 | * tx_ring is currently being cleaned anyway. */ | 1395 | * tx_ring is currently being cleaned anyway. */ |
1396 | if (spin_trylock(&adapter->tx_queue_lock)) { | 1396 | if (spin_trylock(&adapter->tx_queue_lock)) { |
1397 | e1000_clean_tx_irq(adapter); | 1397 | tx_cleaned = e1000_clean_tx_irq(adapter); |
1398 | spin_unlock(&adapter->tx_queue_lock); | 1398 | spin_unlock(&adapter->tx_queue_lock); |
1399 | } | 1399 | } |
1400 | 1400 | ||
1401 | adapter->clean_rx(adapter, &work_done, budget); | 1401 | adapter->clean_rx(adapter, &work_done, budget); |
1402 | 1402 | ||
1403 | if (tx_cleaned) | ||
1404 | work_done = budget; | ||
1405 | |||
1403 | /* If budget not fully consumed, exit the polling mode */ | 1406 | /* If budget not fully consumed, exit the polling mode */ |
1404 | if (work_done < budget) { | 1407 | if (work_done < budget) { |
1405 | if (adapter->itr_setting & 3) | 1408 | if (adapter->itr_setting & 3) |
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c index a56491617661..de3f45e4c5ae 100644 --- a/drivers/net/ixgbe/ixgbe_main.c +++ b/drivers/net/ixgbe/ixgbe_main.c | |||
@@ -1468,13 +1468,16 @@ static int ixgbe_clean(struct napi_struct *napi, int budget) | |||
1468 | struct ixgbe_adapter *adapter = container_of(napi, | 1468 | struct ixgbe_adapter *adapter = container_of(napi, |
1469 | struct ixgbe_adapter, napi); | 1469 | struct ixgbe_adapter, napi); |
1470 | struct net_device *netdev = adapter->netdev; | 1470 | struct net_device *netdev = adapter->netdev; |
1471 | int work_done = 0; | 1471 | int tx_cleaned = 0, work_done = 0; |
1472 | 1472 | ||
1473 | /* In non-MSIX case, there is no multi-Tx/Rx queue */ | 1473 | /* In non-MSIX case, there is no multi-Tx/Rx queue */ |
1474 | ixgbe_clean_tx_irq(adapter, adapter->tx_ring); | 1474 | tx_cleaned = ixgbe_clean_tx_irq(adapter, adapter->tx_ring); |
1475 | ixgbe_clean_rx_irq(adapter, &adapter->rx_ring[0], &work_done, | 1475 | ixgbe_clean_rx_irq(adapter, &adapter->rx_ring[0], &work_done, |
1476 | budget); | 1476 | budget); |
1477 | 1477 | ||
1478 | if (tx_cleaned) | ||
1479 | work_done = budget; | ||
1480 | |||
1478 | /* If budget not fully consumed, exit the polling mode */ | 1481 | /* If budget not fully consumed, exit the polling mode */ |
1479 | if (work_done < budget) { | 1482 | if (work_done < budget) { |
1480 | netif_rx_complete(netdev, napi); | 1483 | netif_rx_complete(netdev, napi); |
diff --git a/drivers/net/niu.c b/drivers/net/niu.c index 3bbcea11329f..5f6beabf2d17 100644 --- a/drivers/net/niu.c +++ b/drivers/net/niu.c | |||
@@ -1319,6 +1319,7 @@ static int link_status_10g(struct niu *np, int *link_up_p) | |||
1319 | 1319 | ||
1320 | static int link_status_1g(struct niu *np, int *link_up_p) | 1320 | static int link_status_1g(struct niu *np, int *link_up_p) |
1321 | { | 1321 | { |
1322 | struct niu_link_config *lp = &np->link_config; | ||
1322 | u16 current_speed, bmsr; | 1323 | u16 current_speed, bmsr; |
1323 | unsigned long flags; | 1324 | unsigned long flags; |
1324 | u8 current_duplex; | 1325 | u8 current_duplex; |
@@ -1386,6 +1387,8 @@ static int link_status_1g(struct niu *np, int *link_up_p) | |||
1386 | link_up = 0; | 1387 | link_up = 0; |
1387 | } | 1388 | } |
1388 | } | 1389 | } |
1390 | lp->active_speed = current_speed; | ||
1391 | lp->active_duplex = current_duplex; | ||
1389 | err = 0; | 1392 | err = 0; |
1390 | 1393 | ||
1391 | out: | 1394 | out: |