aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2008-04-29 14:45:16 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2008-04-29 14:45:16 -0400
commit6203554207728f43cfb9fd48585cd6500da73d42 (patch)
treea1e486f288c3ef0d29c4367a058fe906ece763e3
parent9781db7b345b5dfe93787aaaf310c861db7c1ede (diff)
drivers/net/tehuti: use proper capability check for raw IO access
Yeah, in practice they both mean "root", but Alan correctly points out that anybody who gets to do raw IO space accesses should really be using CAP_SYS_RAWIO rather than CAP_NET_ADMIN. Pointed-out-by: Alan Cox <alan@lxorguk.ukuu.org.uk> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--drivers/net/tehuti.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/tehuti.c b/drivers/net/tehuti.c
index e83b166aa6b9..432e837a1760 100644
--- a/drivers/net/tehuti.c
+++ b/drivers/net/tehuti.c
@@ -649,7 +649,7 @@ static int bdx_ioctl_priv(struct net_device *ndev, struct ifreq *ifr, int cmd)
649 DBG("%d 0x%x 0x%x\n", data[0], data[1], data[2]); 649 DBG("%d 0x%x 0x%x\n", data[0], data[1], data[2]);
650 } 650 }
651 651
652 if (!capable(CAP_NET_ADMIN)) 652 if (!capable(CAP_SYS_RAWIO))
653 return -EPERM; 653 return -EPERM;
654 654
655 switch (data[0]) { 655 switch (data[0]) {