diff options
author | Julian Calaby <julian.calaby@gmail.com> | 2009-01-05 03:07:18 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-01-05 03:07:18 -0500 |
commit | 47cd5265ea8fe0b246bfd9b42ba69e13aa8b99bd (patch) | |
tree | 3c413ded05253219d50b6ce9871e19d3bf2a259f | |
parent | 192eee8ef535cfdbdd0c93390e34f27ad7c02084 (diff) |
sparc: Clean arch-specific code in prom_common.c
prom_nextprop() and prom_firstprop() have slightly different calling
conventions in 32 and 64 bit SPARC.
prom_common.c uses a ifdef guard to ensure that these functions are
called correctly.
Adjust code to eliminate this ifdef by using a calling convention that
is compatible with both 32 and 64 bit SPARC.
Signed-off-by: Julian Calaby <julian.calaby@gmail.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | arch/sparc/kernel/prom_common.c | 14 |
1 files changed, 3 insertions, 11 deletions
diff --git a/arch/sparc/kernel/prom_common.c b/arch/sparc/kernel/prom_common.c index 4e9af593db49..ff7b591c8946 100644 --- a/arch/sparc/kernel/prom_common.c +++ b/arch/sparc/kernel/prom_common.c | |||
@@ -155,20 +155,12 @@ static struct property * __init build_one_prop(phandle node, char *prev, | |||
155 | p->value = prom_early_alloc(special_len); | 155 | p->value = prom_early_alloc(special_len); |
156 | memcpy(p->value, special_val, special_len); | 156 | memcpy(p->value, special_val, special_len); |
157 | } else { | 157 | } else { |
158 | #ifdef CONFIG_SPARC32 | ||
159 | if (prev == NULL) { | ||
160 | name = prom_firstprop(node, NULL); | ||
161 | } else { | ||
162 | name = prom_nextprop(node, prev, NULL); | ||
163 | } | ||
164 | #else | ||
165 | if (prev == NULL) { | 158 | if (prev == NULL) { |
166 | prom_firstprop(node, p->name); | 159 | name = prom_firstprop(node, p->name); |
167 | } else { | 160 | } else { |
168 | prom_nextprop(node, prev, p->name); | 161 | name = prom_nextprop(node, prev, p->name); |
169 | } | 162 | } |
170 | name = p->name; | 163 | |
171 | #endif | ||
172 | if (strlen(name) == 0) { | 164 | if (strlen(name) == 0) { |
173 | tmp = p; | 165 | tmp = p; |
174 | return NULL; | 166 | return NULL; |