diff options
author | Greg Kroah-Hartman <gregkh@suse.de> | 2008-12-16 15:23:36 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-01-06 13:44:32 -0500 |
commit | 2831fe6f9cc4e16c103504ee09a47a084297c0f3 (patch) | |
tree | 36869b2a4ad9dce0fb0812f44355233e907afa95 | |
parent | 2e5ba26a483218b51b7b327fb235b348890aea15 (diff) |
driver core: create a private portion of struct device
This is to be used to move things out of struct device that no code
outside of the driver core should ever touch.
Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r-- | drivers/base/base.h | 12 | ||||
-rw-r--r-- | drivers/base/core.c | 8 | ||||
-rw-r--r-- | include/linux/device.h | 3 |
3 files changed, 23 insertions, 0 deletions
diff --git a/drivers/base/base.h b/drivers/base/base.h index 0a5f055dffba..6b20809b5fd4 100644 --- a/drivers/base/base.h +++ b/drivers/base/base.h | |||
@@ -63,6 +63,18 @@ struct class_private { | |||
63 | #define to_class(obj) \ | 63 | #define to_class(obj) \ |
64 | container_of(obj, struct class_private, class_subsys.kobj) | 64 | container_of(obj, struct class_private, class_subsys.kobj) |
65 | 65 | ||
66 | /** | ||
67 | * struct device_private - structure to hold the private to the driver core portions of the device structure. | ||
68 | * | ||
69 | * @device - pointer back to the struct class that this structure is | ||
70 | * associated with. | ||
71 | * | ||
72 | * Nothing outside of the driver core should ever touch these fields. | ||
73 | */ | ||
74 | struct device_private { | ||
75 | struct device *device; | ||
76 | }; | ||
77 | |||
66 | /* initialisation functions */ | 78 | /* initialisation functions */ |
67 | extern int devices_init(void); | 79 | extern int devices_init(void); |
68 | extern int buses_init(void); | 80 | extern int buses_init(void); |
diff --git a/drivers/base/core.c b/drivers/base/core.c index 14aa2b6953c9..6657787e64f8 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c | |||
@@ -109,6 +109,7 @@ static struct sysfs_ops dev_sysfs_ops = { | |||
109 | static void device_release(struct kobject *kobj) | 109 | static void device_release(struct kobject *kobj) |
110 | { | 110 | { |
111 | struct device *dev = to_dev(kobj); | 111 | struct device *dev = to_dev(kobj); |
112 | struct device_private *p = dev->p; | ||
112 | 113 | ||
113 | if (dev->release) | 114 | if (dev->release) |
114 | dev->release(dev); | 115 | dev->release(dev); |
@@ -120,6 +121,7 @@ static void device_release(struct kobject *kobj) | |||
120 | WARN(1, KERN_ERR "Device '%s' does not have a release() " | 121 | WARN(1, KERN_ERR "Device '%s' does not have a release() " |
121 | "function, it is broken and must be fixed.\n", | 122 | "function, it is broken and must be fixed.\n", |
122 | dev_name(dev)); | 123 | dev_name(dev)); |
124 | kfree(p); | ||
123 | } | 125 | } |
124 | 126 | ||
125 | static struct kobj_type device_ktype = { | 127 | static struct kobj_type device_ktype = { |
@@ -536,6 +538,12 @@ static void klist_children_put(struct klist_node *n) | |||
536 | */ | 538 | */ |
537 | void device_initialize(struct device *dev) | 539 | void device_initialize(struct device *dev) |
538 | { | 540 | { |
541 | dev->p = kzalloc(sizeof(*dev->p), GFP_KERNEL); | ||
542 | if (!dev->p) { | ||
543 | WARN_ON(1); | ||
544 | return; | ||
545 | } | ||
546 | dev->p->device = dev; | ||
539 | dev->kobj.kset = devices_kset; | 547 | dev->kobj.kset = devices_kset; |
540 | kobject_init(&dev->kobj, &device_ktype); | 548 | kobject_init(&dev->kobj, &device_ktype); |
541 | klist_init(&dev->klist_children, klist_children_get, | 549 | klist_init(&dev->klist_children, klist_children_get, |
diff --git a/include/linux/device.h b/include/linux/device.h index 4e14fad41430..d6d34084fd37 100644 --- a/include/linux/device.h +++ b/include/linux/device.h | |||
@@ -28,6 +28,7 @@ | |||
28 | #define BUS_ID_SIZE 20 | 28 | #define BUS_ID_SIZE 20 |
29 | 29 | ||
30 | struct device; | 30 | struct device; |
31 | struct device_private; | ||
31 | struct device_driver; | 32 | struct device_driver; |
32 | struct driver_private; | 33 | struct driver_private; |
33 | struct class; | 34 | struct class; |
@@ -371,6 +372,8 @@ struct device { | |||
371 | struct klist_node knode_bus; | 372 | struct klist_node knode_bus; |
372 | struct device *parent; | 373 | struct device *parent; |
373 | 374 | ||
375 | struct device_private *p; | ||
376 | |||
374 | struct kobject kobj; | 377 | struct kobject kobj; |
375 | char bus_id[BUS_ID_SIZE]; /* position on parent bus */ | 378 | char bus_id[BUS_ID_SIZE]; /* position on parent bus */ |
376 | unsigned uevent_suppress:1; | 379 | unsigned uevent_suppress:1; |