aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChen, Kenneth W <kenneth.w.chen@intel.com>2005-10-13 15:49:29 -0400
committerJens Axboe <axboe@nelson.home.kernel.dk>2005-10-28 02:15:43 -0400
commitb2982649ce38293b14684b26bcda20cfc54164e6 (patch)
tree8208c0cd33f2565f0f193d0afab282a7d0778382
parent20e5c81fcff89535dced2ed71cf24c6c648ff40e (diff)
Following the same idea, it occurs to me that we should only update
disk stat when "now" is different from disk->stamp. Otherwise, we are again needlessly adding zero to the stats. Signed-off-by: Ken Chen <kenneth.w.chen@intel.com> Signed-off-by: Jens Axboe <axboe@suse.de>
-rw-r--r--drivers/block/ll_rw_blk.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/block/ll_rw_blk.c b/drivers/block/ll_rw_blk.c
index c42071fd2e95..4e2b1b06b411 100644
--- a/drivers/block/ll_rw_blk.c
+++ b/drivers/block/ll_rw_blk.c
@@ -2433,6 +2433,9 @@ void disk_round_stats(struct gendisk *disk)
2433{ 2433{
2434 unsigned long now = jiffies; 2434 unsigned long now = jiffies;
2435 2435
2436 if (now == disk->stamp)
2437 return;
2438
2436 if (disk->in_flight) { 2439 if (disk->in_flight) {
2437 __disk_stat_add(disk, time_in_queue, 2440 __disk_stat_add(disk, time_in_queue,
2438 disk->in_flight * (now - disk->stamp)); 2441 disk->in_flight * (now - disk->stamp));