diff options
author | Eric Dumazet <eric.dumazet@gmail.com> | 2011-05-11 18:38:10 -0400 |
---|---|---|
committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2011-05-12 11:28:57 -0400 |
commit | 7cbbb758d3c93b24b45b169af55440d2e7d5b7f6 (patch) | |
tree | 2eda8bad7a0f92c67b2255e9076e892309e85011 | |
parent | 1201e7e67634624aec89317cf308cd0d3d8d4770 (diff) |
Input: remove useless synchronize_rcu() calls
There is no need to call synchronize_rcu() after a list insertion,
or a NULL->ptr assignment.
However, the reverse operations do need this call.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
-rw-r--r-- | drivers/input/evdev.c | 2 | ||||
-rw-r--r-- | drivers/input/input.c | 1 | ||||
-rw-r--r-- | drivers/input/joydev.c | 1 | ||||
-rw-r--r-- | drivers/input/mousedev.c | 1 |
4 files changed, 0 insertions, 5 deletions
diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c index 75c4e8683033..be0921ef6b52 100644 --- a/drivers/input/evdev.c +++ b/drivers/input/evdev.c | |||
@@ -164,7 +164,6 @@ static int evdev_grab(struct evdev *evdev, struct evdev_client *client) | |||
164 | return error; | 164 | return error; |
165 | 165 | ||
166 | rcu_assign_pointer(evdev->grab, client); | 166 | rcu_assign_pointer(evdev->grab, client); |
167 | synchronize_rcu(); | ||
168 | 167 | ||
169 | return 0; | 168 | return 0; |
170 | } | 169 | } |
@@ -187,7 +186,6 @@ static void evdev_attach_client(struct evdev *evdev, | |||
187 | spin_lock(&evdev->client_lock); | 186 | spin_lock(&evdev->client_lock); |
188 | list_add_tail_rcu(&client->node, &evdev->client_list); | 187 | list_add_tail_rcu(&client->node, &evdev->client_list); |
189 | spin_unlock(&evdev->client_lock); | 188 | spin_unlock(&evdev->client_lock); |
190 | synchronize_rcu(); | ||
191 | } | 189 | } |
192 | 190 | ||
193 | static void evdev_detach_client(struct evdev *evdev, | 191 | static void evdev_detach_client(struct evdev *evdev, |
diff --git a/drivers/input/input.c b/drivers/input/input.c index ebbceedc92f4..75e11c7b70fd 100644 --- a/drivers/input/input.c +++ b/drivers/input/input.c | |||
@@ -451,7 +451,6 @@ int input_grab_device(struct input_handle *handle) | |||
451 | } | 451 | } |
452 | 452 | ||
453 | rcu_assign_pointer(dev->grab, handle); | 453 | rcu_assign_pointer(dev->grab, handle); |
454 | synchronize_rcu(); | ||
455 | 454 | ||
456 | out: | 455 | out: |
457 | mutex_unlock(&dev->mutex); | 456 | mutex_unlock(&dev->mutex); |
diff --git a/drivers/input/joydev.c b/drivers/input/joydev.c index 5688b5c88f24..c24ec2d5f926 100644 --- a/drivers/input/joydev.c +++ b/drivers/input/joydev.c | |||
@@ -180,7 +180,6 @@ static void joydev_attach_client(struct joydev *joydev, | |||
180 | spin_lock(&joydev->client_lock); | 180 | spin_lock(&joydev->client_lock); |
181 | list_add_tail_rcu(&client->node, &joydev->client_list); | 181 | list_add_tail_rcu(&client->node, &joydev->client_list); |
182 | spin_unlock(&joydev->client_lock); | 182 | spin_unlock(&joydev->client_lock); |
183 | synchronize_rcu(); | ||
184 | } | 183 | } |
185 | 184 | ||
186 | static void joydev_detach_client(struct joydev *joydev, | 185 | static void joydev_detach_client(struct joydev *joydev, |
diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c index 7630273e9474..257e033986e4 100644 --- a/drivers/input/mousedev.c +++ b/drivers/input/mousedev.c | |||
@@ -508,7 +508,6 @@ static void mousedev_attach_client(struct mousedev *mousedev, | |||
508 | spin_lock(&mousedev->client_lock); | 508 | spin_lock(&mousedev->client_lock); |
509 | list_add_tail_rcu(&client->node, &mousedev->client_list); | 509 | list_add_tail_rcu(&client->node, &mousedev->client_list); |
510 | spin_unlock(&mousedev->client_lock); | 510 | spin_unlock(&mousedev->client_lock); |
511 | synchronize_rcu(); | ||
512 | } | 511 | } |
513 | 512 | ||
514 | static void mousedev_detach_client(struct mousedev *mousedev, | 513 | static void mousedev_detach_client(struct mousedev *mousedev, |