diff options
author | Julia Lawall <julia@diku.dk> | 2010-05-13 16:07:46 -0400 |
---|---|---|
committer | David Woodhouse <David.Woodhouse@intel.com> | 2010-05-13 16:21:38 -0400 |
commit | ecce2a6f9bdc7635838baeff8a09a76c9a70e7e0 (patch) | |
tree | 7334dbb776baa37979545636d6346ebdca44281d | |
parent | aadff49c56f921d18cc280cbf087a550c67bbd02 (diff) |
drivers/mtd/nand: Use kzalloc
Use kzalloc rather than the combination of kmalloc and memset.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression x,size,flags;
statement S;
@@
-x = kmalloc(size,flags);
+x = kzalloc(size,flags);
if (x == NULL) S
-memset(x, 0, size);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
-rw-r--r-- | drivers/mtd/nand/s3c2410.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c index dc02dcd0c08f..239aadfd01b0 100644 --- a/drivers/mtd/nand/s3c2410.c +++ b/drivers/mtd/nand/s3c2410.c | |||
@@ -929,14 +929,13 @@ static int s3c24xx_nand_probe(struct platform_device *pdev) | |||
929 | 929 | ||
930 | pr_debug("s3c2410_nand_probe(%p)\n", pdev); | 930 | pr_debug("s3c2410_nand_probe(%p)\n", pdev); |
931 | 931 | ||
932 | info = kmalloc(sizeof(*info), GFP_KERNEL); | 932 | info = kzalloc(sizeof(*info), GFP_KERNEL); |
933 | if (info == NULL) { | 933 | if (info == NULL) { |
934 | dev_err(&pdev->dev, "no memory for flash info\n"); | 934 | dev_err(&pdev->dev, "no memory for flash info\n"); |
935 | err = -ENOMEM; | 935 | err = -ENOMEM; |
936 | goto exit_error; | 936 | goto exit_error; |
937 | } | 937 | } |
938 | 938 | ||
939 | memset(info, 0, sizeof(*info)); | ||
940 | platform_set_drvdata(pdev, info); | 939 | platform_set_drvdata(pdev, info); |
941 | 940 | ||
942 | spin_lock_init(&info->controller.lock); | 941 | spin_lock_init(&info->controller.lock); |
@@ -994,15 +993,13 @@ static int s3c24xx_nand_probe(struct platform_device *pdev) | |||
994 | /* allocate our information */ | 993 | /* allocate our information */ |
995 | 994 | ||
996 | size = nr_sets * sizeof(*info->mtds); | 995 | size = nr_sets * sizeof(*info->mtds); |
997 | info->mtds = kmalloc(size, GFP_KERNEL); | 996 | info->mtds = kzalloc(size, GFP_KERNEL); |
998 | if (info->mtds == NULL) { | 997 | if (info->mtds == NULL) { |
999 | dev_err(&pdev->dev, "failed to allocate mtd storage\n"); | 998 | dev_err(&pdev->dev, "failed to allocate mtd storage\n"); |
1000 | err = -ENOMEM; | 999 | err = -ENOMEM; |
1001 | goto exit_error; | 1000 | goto exit_error; |
1002 | } | 1001 | } |
1003 | 1002 | ||
1004 | memset(info->mtds, 0, size); | ||
1005 | |||
1006 | /* initialise all possible chips */ | 1003 | /* initialise all possible chips */ |
1007 | 1004 | ||
1008 | nmtd = info->mtds; | 1005 | nmtd = info->mtds; |