diff options
author | Jan Kara <jack@suse.cz> | 2009-04-27 10:43:50 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2009-06-11 21:36:03 -0400 |
commit | 429479f031322a0cc5c921ffb2321a51718dc875 (patch) | |
tree | 6741f7f1bfa1d889bbc4f44ab0489de97a3e47c0 | |
parent | bfe881255c74800147523b59c85328a1a826ba21 (diff) |
vfs: Make __fsync_super() a static function (version 4)
__fsync_super() does the same thing as fsync_super(). So change the only
caller to use fsync_super() and make __fsync_super() static. This removes
unnecessarily duplicated call to sync_blockdev() and prepares ground
for the changes to __fsync_super() in the following patches.
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
-rw-r--r-- | fs/block_dev.c | 2 | ||||
-rw-r--r-- | fs/super.c | 7 | ||||
-rw-r--r-- | include/linux/fs.h | 1 |
3 files changed, 4 insertions, 6 deletions
diff --git a/fs/block_dev.c b/fs/block_dev.c index 931f6b8c4b2f..fe47f7227618 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c | |||
@@ -241,7 +241,7 @@ struct super_block *freeze_bdev(struct block_device *bdev) | |||
241 | sb->s_frozen = SB_FREEZE_WRITE; | 241 | sb->s_frozen = SB_FREEZE_WRITE; |
242 | smp_wmb(); | 242 | smp_wmb(); |
243 | 243 | ||
244 | __fsync_super(sb); | 244 | fsync_super(sb); |
245 | 245 | ||
246 | sb->s_frozen = SB_FREEZE_TRANS; | 246 | sb->s_frozen = SB_FREEZE_TRANS; |
247 | smp_wmb(); | 247 | smp_wmb(); |
diff --git a/fs/super.c b/fs/super.c index fae91ba38e48..8dbe1ead9ddd 100644 --- a/fs/super.c +++ b/fs/super.c | |||
@@ -289,7 +289,7 @@ EXPORT_SYMBOL(unlock_super); | |||
289 | * device. Takes the superblock lock. Requires a second blkdev | 289 | * device. Takes the superblock lock. Requires a second blkdev |
290 | * flush by the caller to complete the operation. | 290 | * flush by the caller to complete the operation. |
291 | */ | 291 | */ |
292 | void __fsync_super(struct super_block *sb) | 292 | static int __fsync_super(struct super_block *sb) |
293 | { | 293 | { |
294 | sync_inodes_sb(sb, 0); | 294 | sync_inodes_sb(sb, 0); |
295 | vfs_dq_sync(sb); | 295 | vfs_dq_sync(sb); |
@@ -300,7 +300,7 @@ void __fsync_super(struct super_block *sb) | |||
300 | unlock_super(sb); | 300 | unlock_super(sb); |
301 | if (sb->s_op->sync_fs) | 301 | if (sb->s_op->sync_fs) |
302 | sb->s_op->sync_fs(sb, 1); | 302 | sb->s_op->sync_fs(sb, 1); |
303 | sync_blockdev(sb->s_bdev); | 303 | return sync_blockdev(sb->s_bdev); |
304 | } | 304 | } |
305 | 305 | ||
306 | /* | 306 | /* |
@@ -310,8 +310,7 @@ void __fsync_super(struct super_block *sb) | |||
310 | */ | 310 | */ |
311 | int fsync_super(struct super_block *sb) | 311 | int fsync_super(struct super_block *sb) |
312 | { | 312 | { |
313 | __fsync_super(sb); | 313 | return __fsync_super(sb); |
314 | return sync_blockdev(sb->s_bdev); | ||
315 | } | 314 | } |
316 | EXPORT_SYMBOL_GPL(fsync_super); | 315 | EXPORT_SYMBOL_GPL(fsync_super); |
317 | 316 | ||
diff --git a/include/linux/fs.h b/include/linux/fs.h index 36bcff7036ef..41a9907f342e 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h | |||
@@ -2078,7 +2078,6 @@ extern int filemap_fdatawrite_range(struct address_space *mapping, | |||
2078 | extern int vfs_fsync(struct file *file, struct dentry *dentry, int datasync); | 2078 | extern int vfs_fsync(struct file *file, struct dentry *dentry, int datasync); |
2079 | extern void sync_supers(void); | 2079 | extern void sync_supers(void); |
2080 | extern void sync_filesystems(int wait); | 2080 | extern void sync_filesystems(int wait); |
2081 | extern void __fsync_super(struct super_block *sb); | ||
2082 | extern void emergency_sync(void); | 2081 | extern void emergency_sync(void); |
2083 | extern void emergency_remount(void); | 2082 | extern void emergency_remount(void); |
2084 | extern int do_remount_sb(struct super_block *sb, int flags, | 2083 | extern int do_remount_sb(struct super_block *sb, int flags, |