aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2010-02-11 01:30:30 -0500
committerMauro Carvalho Chehab <mchehab@redhat.com>2010-05-17 23:43:58 -0400
commitf8960ee7a44d58d79aae063e46f3316e1d5748e0 (patch)
treeb0010d415a3b5b1b75fd3af24541b8688ef02a10
parent29ec15e90ba9e20ff33da4824c32721bbc6bcfad (diff)
V4L/DVB: drivers/staging/tm6000/tm6000-video.c: correct NULL test
Test the just-allocated value for NULL rather than some other value. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression x,y; statement S; @@ x = \(kmalloc\|kcalloc\|kzalloc\)(...); ( if ((x) == NULL) S | if ( - y + x == NULL) S ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Acked-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
-rw-r--r--drivers/staging/tm6000/tm6000-video.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/tm6000/tm6000-video.c b/drivers/staging/tm6000/tm6000-video.c
index 217721f2195c..627b0ddfcd18 100644
--- a/drivers/staging/tm6000/tm6000-video.c
+++ b/drivers/staging/tm6000/tm6000-video.c
@@ -644,7 +644,7 @@ static int tm6000_prepare_isoc(struct tm6000_core *dev, unsigned int framesize)
644 644
645 dev->isoc_ctl.transfer_buffer = kmalloc(sizeof(void *)*num_bufs, 645 dev->isoc_ctl.transfer_buffer = kmalloc(sizeof(void *)*num_bufs,
646 GFP_KERNEL); 646 GFP_KERNEL);
647 if (!dev->isoc_ctl.urb) { 647 if (!dev->isoc_ctl.transfer_buffer) {
648 tm6000_err("cannot allocate memory for usbtransfer\n"); 648 tm6000_err("cannot allocate memory for usbtransfer\n");
649 kfree(dev->isoc_ctl.urb); 649 kfree(dev->isoc_ctl.urb);
650 return -ENOMEM; 650 return -ENOMEM;