diff options
author | Joe Perches <joe@perches.com> | 2010-08-09 20:21:01 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-08-09 23:45:09 -0400 |
commit | 8bbea968f9022c3f66a36902509574597611be99 (patch) | |
tree | 4d0a274a811cbe9169ce03267dbfce1dd99b8403 | |
parent | 5150bda43c58cdce7eb851c3fe2ca913524459a0 (diff) |
checkpatch: add more exceptions to 80 char lines
Add new logging functions netdev_<level> and netif_<level>.
Don't complain if the only thing on a line is a quoted string.
Signed-off-by: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@shadowen.org>
Cc: Wolfram Sang <w.sang@pengutronix.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rwxr-xr-x | scripts/checkpatch.pl | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 25d716cc44dc..2018f4349b47 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl | |||
@@ -195,7 +195,7 @@ our $typeTypedefs = qr{(?x: | |||
195 | our $logFunctions = qr{(?x: | 195 | our $logFunctions = qr{(?x: |
196 | printk| | 196 | printk| |
197 | pr_(debug|dbg|vdbg|devel|info|warning|err|notice|alert|crit|emerg|cont)| | 197 | pr_(debug|dbg|vdbg|devel|info|warning|err|notice|alert|crit|emerg|cont)| |
198 | dev_(printk|dbg|vdbg|info|warn|err|notice|alert|crit|emerg|WARN)| | 198 | (dev|netdev|netif)_(printk|dbg|vdbg|info|warn|err|notice|alert|crit|emerg|WARN)| |
199 | WARN| | 199 | WARN| |
200 | panic | 200 | panic |
201 | )}; | 201 | )}; |
@@ -1409,7 +1409,8 @@ sub process { | |||
1409 | #80 column limit | 1409 | #80 column limit |
1410 | if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ && | 1410 | if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ && |
1411 | $rawline !~ /^.\s*\*\s*\@$Ident\s/ && | 1411 | $rawline !~ /^.\s*\*\s*\@$Ident\s/ && |
1412 | $line !~ /^\+\s*$logFunctions\s*\(\s*(?:KERN_\S+\s*)?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ && | 1412 | !($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(KERN_\S+\s*|[^"]*))?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ || |
1413 | $line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) && | ||
1413 | $length > 80) | 1414 | $length > 80) |
1414 | { | 1415 | { |
1415 | WARN("line over 80 characters\n" . $herecurr); | 1416 | WARN("line over 80 characters\n" . $herecurr); |