diff options
author | Matt Mackall <mpm@selenic.com> | 2006-10-03 04:14:16 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-10-03 11:04:07 -0400 |
commit | 83d7dbc4095a0c314b191c573be5fb4fa6ce0897 (patch) | |
tree | 0da41cd73f0dfdac778e5e415592da92db85db7a | |
parent | ce42f19137225d01be9388a73703df40fb7af80f (diff) |
[PATCH] Make number of IDE interfaces configurable
Make IDE_HWIFS configurable if EMBEDDED
This lets us lop as much as 16k off an x86 build. It's a little ugly, but
it's dead simple. Note the fix for HWIFS < 2.
Sizing interfaces dynamically unfortunately turns out to be pretty
major surgery.
add/remove: 0/1 grow/shrink: 0/11 up/down: 0/-16182 (-16182)
function old new delta
ide_hwifs 16920 1692 -15228
init_irq 1113 750 -363
ideprobe_init 283 138 -145
ide_pci_setup_ports 1329 1193 -136
save_match 85 - -85
ide_register_hw_with_fixup 367 287 -80
ide_setup 1364 1308 -56
is_chipset_set 40 4 -36
create_proc_ide_interfaces 225 205 -20
init_ide_data 84 67 -17
ide_probe_for_cmd640x 1198 1183 -15
ide_unregister 1452 1451 -1
Signed-off-by: Matt Mackall <mpm@selenic.com>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Acked-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r-- | drivers/ide/Kconfig | 2 | ||||
-rw-r--r-- | drivers/ide/setup-pci.c | 2 | ||||
-rw-r--r-- | include/linux/ide.h | 3 |
3 files changed, 4 insertions, 3 deletions
diff --git a/drivers/ide/Kconfig b/drivers/ide/Kconfig index 0524f17175fd..abcabb295592 100644 --- a/drivers/ide/Kconfig +++ b/drivers/ide/Kconfig | |||
@@ -56,7 +56,7 @@ if IDE | |||
56 | 56 | ||
57 | config IDE_MAX_HWIFS | 57 | config IDE_MAX_HWIFS |
58 | int "Max IDE interfaces" | 58 | int "Max IDE interfaces" |
59 | depends on ALPHA || SUPERH || IA64 | 59 | depends on ALPHA || SUPERH || IA64 || EMBEDDED |
60 | default 4 | 60 | default 4 |
61 | help | 61 | help |
62 | This is the maximum number of IDE hardware interfaces that will | 62 | This is the maximum number of IDE hardware interfaces that will |
diff --git a/drivers/ide/setup-pci.c b/drivers/ide/setup-pci.c index eb0945284acc..157fe93ea342 100644 --- a/drivers/ide/setup-pci.c +++ b/drivers/ide/setup-pci.c | |||
@@ -101,7 +101,7 @@ static ide_hwif_t *ide_match_hwif(unsigned long io_base, u8 bootable, const char | |||
101 | return hwif; /* pick an unused entry */ | 101 | return hwif; /* pick an unused entry */ |
102 | } | 102 | } |
103 | } | 103 | } |
104 | for (h = 0; h < 2; ++h) { | 104 | for (h = 0; h < 2 && h < MAX_HWIFS; ++h) { |
105 | hwif = ide_hwifs + h; | 105 | hwif = ide_hwifs + h; |
106 | if (hwif->chipset == ide_unknown) | 106 | if (hwif->chipset == ide_unknown) |
107 | return hwif; /* pick an unused entry */ | 107 | return hwif; /* pick an unused entry */ |
diff --git a/include/linux/ide.h b/include/linux/ide.h index 11608cd03d4c..bdb2733208c5 100644 --- a/include/linux/ide.h +++ b/include/linux/ide.h | |||
@@ -251,7 +251,8 @@ static inline void ide_std_init_ports(hw_regs_t *hw, | |||
251 | 251 | ||
252 | #include <asm/ide.h> | 252 | #include <asm/ide.h> |
253 | 253 | ||
254 | #ifndef MAX_HWIFS | 254 | #if !defined(MAX_HWIFS) || defined(CONFIG_EMBEDDED) |
255 | #undef MAX_HWIFS | ||
255 | #define MAX_HWIFS CONFIG_IDE_MAX_HWIFS | 256 | #define MAX_HWIFS CONFIG_IDE_MAX_HWIFS |
256 | #endif | 257 | #endif |
257 | 258 | ||