aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKrzysztof Helt <krzysztof.h1@wp.pl>2007-05-08 03:40:10 -0400
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-05-08 14:15:33 -0400
commit4c7bf38699aed591b6624add40acfa71fe6d902c (patch)
treee70d2e2ef6744b06d882e9c8e4d02b06cc53e59f
parent7e645ffd83f987c8650e9dd0f22a0c57296ed458 (diff)
skeletonfb: more corrections
More corrections to skeletonfb.c file: - fixed types of more arguments - removed returned values in void functions - removed not existing fb_poll function - fixed closing comment typo - corrected misleading constant name ADDR Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl> Acked-By: James Simmons <jsimmons@infradead.org> Signed-off-by: Antonino Daplas <adaplas@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--drivers/video/skeletonfb.c26
1 files changed, 5 insertions, 21 deletions
diff --git a/drivers/video/skeletonfb.c b/drivers/video/skeletonfb.c
index 7a7ed7dbe326..c15b6fefe919 100644
--- a/drivers/video/skeletonfb.c
+++ b/drivers/video/skeletonfb.c
@@ -148,7 +148,7 @@ int xxxfb_setup(char*);
148 * 148 *
149 * Returns negative errno on error, or zero on success. 149 * Returns negative errno on error, or zero on success.
150 */ 150 */
151static int xxxfb_open(const struct fb_info *info, int user) 151static int xxxfb_open(struct fb_info *info, int user)
152{ 152{
153 return 0; 153 return 0;
154} 154}
@@ -167,7 +167,7 @@ static int xxxfb_open(const struct fb_info *info, int user)
167 * 167 *
168 * Returns negative errno on error, or zero on success. 168 * Returns negative errno on error, or zero on success.
169 */ 169 */
170static int xxxfb_release(const struct fb_info *info, int user) 170static int xxxfb_release(struct fb_info *info, int user)
171{ 171{
172 return 0; 172 return 0;
173} 173}
@@ -629,19 +629,6 @@ void xxxfb_rotate(struct fb_info *info, int angle)
629} 629}
630 630
631/** 631/**
632 * xxxfb_poll - NOT a required function. The purpose of this
633 * function is to provide a way for some process
634 * to wait until a specific hardware event occurs
635 * for the framebuffer device.
636 *
637 * @info: frame buffer structure that represents a single frame buffer
638 * @wait: poll table where we store process that await a event.
639 */
640void xxxfb_poll(struct fb_info *info, poll_table *wait)
641{
642}
643
644/**
645 * xxxfb_sync - NOT a required function. Normally the accel engine 632 * xxxfb_sync - NOT a required function. Normally the accel engine
646 * for a graphics card take a specific amount of time. 633 * for a graphics card take a specific amount of time.
647 * Often we have to wait for the accelerator to finish 634 * Often we have to wait for the accelerator to finish
@@ -678,7 +665,6 @@ static struct fb_ops xxxfb_ops = {
678 .fb_imageblit = xxxfb_imageblit, /* Needed !!! */ 665 .fb_imageblit = xxxfb_imageblit, /* Needed !!! */
679 .fb_cursor = xxxfb_cursor, /* Optional !!! */ 666 .fb_cursor = xxxfb_cursor, /* Optional !!! */
680 .fb_rotate = xxxfb_rotate, 667 .fb_rotate = xxxfb_rotate,
681 .fb_poll = xxxfb_poll,
682 .fb_sync = xxxfb_sync, 668 .fb_sync = xxxfb_sync,
683 .fb_ioctl = xxxfb_ioctl, 669 .fb_ioctl = xxxfb_ioctl,
684 .fb_mmap = xxxfb_mmap, 670 .fb_mmap = xxxfb_mmap,
@@ -692,7 +678,7 @@ static struct fb_ops xxxfb_ops = {
692 678
693/* static int __init xxfb_probe (struct device *device) -- for platform devs */ 679/* static int __init xxfb_probe (struct device *device) -- for platform devs */
694static int __devinit xxxfb_probe(struct pci_dev *dev, 680static int __devinit xxxfb_probe(struct pci_dev *dev,
695 const_struct pci_device_id *ent) 681 const struct pci_device_id *ent)
696{ 682{
697 struct fb_info *info; 683 struct fb_info *info;
698 struct xxx_par *par; 684 struct xxx_par *par;
@@ -858,8 +844,6 @@ static void __devexit xxxfb_remove(struct pci_dev *dev)
858 /* ... */ 844 /* ... */
859 framebuffer_release(info); 845 framebuffer_release(info);
860 } 846 }
861
862 return 0;
863} 847}
864 848
865#ifdef CONFIG_PCI 849#ifdef CONFIG_PCI
@@ -902,7 +886,7 @@ static int xxxfb_resume(struct pci_dev *dev)
902static struct pci_device_id xxxfb_id_table[] = { 886static struct pci_device_id xxxfb_id_table[] = {
903 { PCI_VENDOR_ID_XXX, PCI_DEVICE_ID_XXX, 887 { PCI_VENDOR_ID_XXX, PCI_DEVICE_ID_XXX,
904 PCI_ANY_ID, PCI_ANY_ID, PCI_BASE_CLASS_DISPLAY << 16, 888 PCI_ANY_ID, PCI_ANY_ID, PCI_BASE_CLASS_DISPLAY << 16,
905 ADDR, 0 }, 889 PCI_CLASS_MASK, 0 },
906 { 0, } 890 { 0, }
907}; 891};
908 892
@@ -1033,7 +1017,7 @@ int __init xxxfb_setup(char *options)
1033{ 1017{
1034 /* Parse user speficied options (`video=xxxfb:') */ 1018 /* Parse user speficied options (`video=xxxfb:') */
1035} 1019}
1036#endif /* MODULE *? 1020#endif /* MODULE */
1037 1021
1038/* ------------------------------------------------------------------------- */ 1022/* ------------------------------------------------------------------------- */
1039 1023