aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTom Tucker <tom@opengridcomputing.com>2007-12-30 22:07:38 -0500
committerJ. Bruce Fields <bfields@citi.umich.edu>2008-02-01 16:42:09 -0500
commit44a6995b32eb9b021ee71b279edb84728c9f5160 (patch)
treefbe6492dc072aaf80cda94353e2bfce8738802e9
parent38a417cc993f4535548e47207f9894e7c27e05e4 (diff)
svc: Remove unnecessary call to svc_sock_enqueue
The svc_tcp_accept function calls svc_sock_enqueue after setting the SK_CONN bit. This doesn't actually do anything because the SK_BUSY bit is still set. The call is unnecessary anyway because the generic code in svc_recv calls svc_sock_received after calling the accept function. Signed-off-by: Tom Tucker <tom@opengridcomputing.com> Acked-by: Neil Brown <neilb@suse.de> Reviewed-by: Chuck Lever <chuck.lever@oracle.com> Reviewed-by: Greg Banks <gnb@sgi.com> Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
-rw-r--r--net/sunrpc/svcsock.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
index 41d1f815fbbd..962dbf43a728 100644
--- a/net/sunrpc/svcsock.c
+++ b/net/sunrpc/svcsock.c
@@ -1064,7 +1064,6 @@ static struct svc_xprt *svc_tcp_accept(struct svc_xprt *xprt)
1064 } 1064 }
1065 1065
1066 set_bit(SK_CONN, &svsk->sk_flags); 1066 set_bit(SK_CONN, &svsk->sk_flags);
1067 svc_sock_enqueue(svsk);
1068 1067
1069 err = kernel_getpeername(newsock, sin, &slen); 1068 err = kernel_getpeername(newsock, sin, &slen);
1070 if (err < 0) { 1069 if (err < 0) {