aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGrant Likely <grant.likely@secretlab.ca>2009-04-25 08:53:44 -0400
committerDavid S. Miller <davem@davemloft.net>2009-04-27 05:53:53 -0400
commit434e7b0d12f4e2de6686841a42bd344325b4d756 (patch)
tree669a676a0f70f6b0a33eae1d195cee02eb057705
parent92744989533cbe85e8057935d230e128810168ce (diff)
net: fix fsl_pq_mdio driver to use module_init()
Modules are not supposed to use any of the *_initcall*() hooks as the entry point. fsl_pq_mdio.c was using subsys_initcall_sync() instead of module_init() to guarantee that the MDIO bus was initialized before the Ethernet driver goes looking for the phy. However, the recent OF helpers rework happens to also make sure PHY connection is deferred to .open time, so using an initcall is no longer necessary. This patch replaces the initcall with a more traditional an accepted module_init() call. Tested on Freescale MPC8349emitxgp eval board. Signed-off-by: Grant Likely <grant.likely@secretlab.ca> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/fsl_pq_mdio.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/fsl_pq_mdio.c b/drivers/net/fsl_pq_mdio.c
index b01daa1e3adf..d12e0e0336f4 100644
--- a/drivers/net/fsl_pq_mdio.c
+++ b/drivers/net/fsl_pq_mdio.c
@@ -415,10 +415,10 @@ int __init fsl_pq_mdio_init(void)
415{ 415{
416 return of_register_platform_driver(&fsl_pq_mdio_driver); 416 return of_register_platform_driver(&fsl_pq_mdio_driver);
417} 417}
418module_init(fsl_pq_mdio_init);
418 419
419void fsl_pq_mdio_exit(void) 420void fsl_pq_mdio_exit(void)
420{ 421{
421 of_unregister_platform_driver(&fsl_pq_mdio_driver); 422 of_unregister_platform_driver(&fsl_pq_mdio_driver);
422} 423}
423subsys_initcall_sync(fsl_pq_mdio_init);
424module_exit(fsl_pq_mdio_exit); 424module_exit(fsl_pq_mdio_exit);