diff options
| author | Steve Glendinning <steve.glendinning@smsc.com> | 2009-02-16 02:46:06 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-02-20 03:35:08 -0500 |
| commit | 9df8f4e3ee760c14211a5f484e9ee4f0bc0c566b (patch) | |
| tree | d0262254d16becb4867cf6883108b3998891e123 | |
| parent | 494ef10ebacc23679350a17483879366d8bafebd (diff) | |
smsc9420: fix another postfixed timeout
Roel Kluin recently fixed several instances where variables reach -1,
but 0 is tested afterwards. This patch fixes another, so the timeout
will be correctly detected and a warning printed.
Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/smsc9420.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/smsc9420.c b/drivers/net/smsc9420.c index a1e4b3895b33..83938e1953b0 100644 --- a/drivers/net/smsc9420.c +++ b/drivers/net/smsc9420.c | |||
| @@ -341,7 +341,7 @@ static int smsc9420_eeprom_send_cmd(struct smsc9420_pdata *pd, u32 op) | |||
| 341 | do { | 341 | do { |
| 342 | msleep(1); | 342 | msleep(1); |
| 343 | e2cmd = smsc9420_reg_read(pd, E2P_CMD); | 343 | e2cmd = smsc9420_reg_read(pd, E2P_CMD); |
| 344 | } while ((e2cmd & E2P_CMD_EPC_BUSY_) && (timeout--)); | 344 | } while ((e2cmd & E2P_CMD_EPC_BUSY_) && (--timeout)); |
| 345 | 345 | ||
| 346 | if (!timeout) { | 346 | if (!timeout) { |
| 347 | smsc_info(HW, "TIMED OUT"); | 347 | smsc_info(HW, "TIMED OUT"); |
