diff options
author | Julia Lawall <julia@diku.dk> | 2009-01-03 14:53:10 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2009-01-07 19:18:56 -0500 |
commit | 2230c3c803a5f3a84f7c3bd86b8159a551edc8ca (patch) | |
tree | 3642fade950eb5040c6239708942680af51b45dc | |
parent | 439b72b69e4992e9ec34b74304f0fa95623934eb (diff) |
V4L/DVB (10185): Use negated usb_endpoint_xfer_control, etc
This patch extends 134179823b3ca9c8b98e0631906459dbb022ff9b by using
usb_endpoint_xfer_control, usb_endpoint_xfer_isoc, usb_endpoint_xfer_bulk,
and usb_endpoint_xfer_int in the negated case as well.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@ struct usb_endpoint_descriptor *epd; @@
- (usb_endpoint_type(epd) != \(USB_ENDPOINT_XFER_CONTROL\|0\))
+ !usb_endpoint_xfer_control(epd)
@@ struct usb_endpoint_descriptor *epd; @@
- (usb_endpoint_type(epd) != \(USB_ENDPOINT_XFER_ISOC\|1\))
+ !usb_endpoint_xfer_isoc(epd)
@@ struct usb_endpoint_descriptor *epd; @@
- (usb_endpoint_type(epd) != \(USB_ENDPOINT_XFER_BULK\|2\))
+ !usb_endpoint_xfer_bulk(epd)
@@ struct usb_endpoint_descriptor *epd; @@
- (usb_endpoint_type(epd) != \(USB_ENDPOINT_XFER_INT\|3\))
+ !usb_endpoint_xfer_int(epd)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
-rw-r--r-- | drivers/media/video/em28xx/em28xx-cards.c | 3 | ||||
-rw-r--r-- | drivers/media/video/usbvideo/ibmcam.c | 2 | ||||
-rw-r--r-- | drivers/media/video/usbvideo/konicawc.c | 2 | ||||
-rw-r--r-- | drivers/media/video/usbvideo/ultracam.c | 2 | ||||
-rw-r--r-- | drivers/media/video/usbvision/usbvision-video.c | 3 |
5 files changed, 5 insertions, 7 deletions
diff --git a/drivers/media/video/em28xx/em28xx-cards.c b/drivers/media/video/em28xx/em28xx-cards.c index 6d2e4a6f8b2b..ef9bf008a924 100644 --- a/drivers/media/video/em28xx/em28xx-cards.c +++ b/drivers/media/video/em28xx/em28xx-cards.c | |||
@@ -1990,8 +1990,7 @@ static int em28xx_usb_probe(struct usb_interface *interface, | |||
1990 | int check_interface = 1; | 1990 | int check_interface = 1; |
1991 | isoc_pipe = 1; | 1991 | isoc_pipe = 1; |
1992 | endpoint = &interface->cur_altsetting->endpoint[1].desc; | 1992 | endpoint = &interface->cur_altsetting->endpoint[1].desc; |
1993 | if (usb_endpoint_type(endpoint) != | 1993 | if (!usb_endpoint_xfer_isoc(endpoint)) |
1994 | USB_ENDPOINT_XFER_ISOC) | ||
1995 | check_interface = 0; | 1994 | check_interface = 0; |
1996 | 1995 | ||
1997 | if (usb_endpoint_dir_out(endpoint)) | 1996 | if (usb_endpoint_dir_out(endpoint)) |
diff --git a/drivers/media/video/usbvideo/ibmcam.c b/drivers/media/video/usbvideo/ibmcam.c index f8d85ddb4804..b08549661781 100644 --- a/drivers/media/video/usbvideo/ibmcam.c +++ b/drivers/media/video/usbvideo/ibmcam.c | |||
@@ -3779,7 +3779,7 @@ static int ibmcam_probe(struct usb_interface *intf, const struct usb_device_id * | |||
3779 | err("Alternate settings have different endpoint addresses!"); | 3779 | err("Alternate settings have different endpoint addresses!"); |
3780 | return -ENODEV; | 3780 | return -ENODEV; |
3781 | } | 3781 | } |
3782 | if (usb_endpoint_type(endpoint) != USB_ENDPOINT_XFER_ISOC) { | 3782 | if (!usb_endpoint_xfer_isoc(endpoint)) { |
3783 | err("Interface %d. has non-ISO endpoint!", ifnum); | 3783 | err("Interface %d. has non-ISO endpoint!", ifnum); |
3784 | return -ENODEV; | 3784 | return -ENODEV; |
3785 | } | 3785 | } |
diff --git a/drivers/media/video/usbvideo/konicawc.c b/drivers/media/video/usbvideo/konicawc.c index 90f0ce6a26bc..900ec2129ca1 100644 --- a/drivers/media/video/usbvideo/konicawc.c +++ b/drivers/media/video/usbvideo/konicawc.c | |||
@@ -823,7 +823,7 @@ static int konicawc_probe(struct usb_interface *intf, const struct usb_device_id | |||
823 | err("Alternate settings have different endpoint addresses!"); | 823 | err("Alternate settings have different endpoint addresses!"); |
824 | return -ENODEV; | 824 | return -ENODEV; |
825 | } | 825 | } |
826 | if (usb_endpoint_type(endpoint) != USB_ENDPOINT_XFER_ISOC) { | 826 | if (!usb_endpoint_xfer_isoc(endpoint)) { |
827 | err("Interface %d. has non-ISO endpoint!", | 827 | err("Interface %d. has non-ISO endpoint!", |
828 | interface->desc.bInterfaceNumber); | 828 | interface->desc.bInterfaceNumber); |
829 | return -ENODEV; | 829 | return -ENODEV; |
diff --git a/drivers/media/video/usbvideo/ultracam.c b/drivers/media/video/usbvideo/ultracam.c index 839a08240c25..fbd1b6392290 100644 --- a/drivers/media/video/usbvideo/ultracam.c +++ b/drivers/media/video/usbvideo/ultracam.c | |||
@@ -556,7 +556,7 @@ static int ultracam_probe(struct usb_interface *intf, const struct usb_device_id | |||
556 | err("Alternate settings have different endpoint addresses!"); | 556 | err("Alternate settings have different endpoint addresses!"); |
557 | return -ENODEV; | 557 | return -ENODEV; |
558 | } | 558 | } |
559 | if (usb_endpoint_type(endpoint) != USB_ENDPOINT_XFER_ISOC) { | 559 | if (!usb_endpoint_xfer_isoc(endpoint)) { |
560 | err("Interface %d. has non-ISO endpoint!", | 560 | err("Interface %d. has non-ISO endpoint!", |
561 | interface->desc.bInterfaceNumber); | 561 | interface->desc.bInterfaceNumber); |
562 | return -ENODEV; | 562 | return -ENODEV; |
diff --git a/drivers/media/video/usbvision/usbvision-video.c b/drivers/media/video/usbvision/usbvision-video.c index 2be5e47ed081..2622de003a45 100644 --- a/drivers/media/video/usbvision/usbvision-video.c +++ b/drivers/media/video/usbvision/usbvision-video.c | |||
@@ -1674,8 +1674,7 @@ static int __devinit usbvision_probe(struct usb_interface *intf, | |||
1674 | interface = &dev->actconfig->interface[ifnum]->altsetting[0]; | 1674 | interface = &dev->actconfig->interface[ifnum]->altsetting[0]; |
1675 | } | 1675 | } |
1676 | endpoint = &interface->endpoint[1].desc; | 1676 | endpoint = &interface->endpoint[1].desc; |
1677 | if (usb_endpoint_type(endpoint) != | 1677 | if (!usb_endpoint_xfer_isoc(endpoint)) { |
1678 | USB_ENDPOINT_XFER_ISOC) { | ||
1679 | err("%s: interface %d. has non-ISO endpoint!", | 1678 | err("%s: interface %d. has non-ISO endpoint!", |
1680 | __func__, ifnum); | 1679 | __func__, ifnum); |
1681 | err("%s: Endpoint attributes %d", | 1680 | err("%s: Endpoint attributes %d", |