diff options
author | NeilBrown <neilb@suse.de> | 2007-05-09 05:34:52 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-05-09 15:30:54 -0400 |
commit | 153e44d22fb5f98198f90fbf56e89b345e48534d (patch) | |
tree | 1bb266798f1a08d2c5f09f2bd3c87564fea52744 | |
parent | 402acd29e552cb80109d1d5c0ada53f634465d87 (diff) |
knfsd: rpc: fix server-side wrapping of krb5i replies
It's not necessarily correct to assume that the xdr_buf used to hold the
server's reply must have page data whenever it has tail data.
And there's no need for us to deal with that case separately anyway.
Acked-by: "J. Bruce Fields" <bfields@citi.umich.edu>
Signed-off-by: Neil Brown <neilb@suse.de>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | net/sunrpc/auth_gss/svcauth_gss.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c index db298b501c81..c678f5f461c6 100644 --- a/net/sunrpc/auth_gss/svcauth_gss.c +++ b/net/sunrpc/auth_gss/svcauth_gss.c | |||
@@ -1196,13 +1196,7 @@ svcauth_gss_wrap_resp_integ(struct svc_rqst *rqstp) | |||
1196 | if (xdr_buf_subsegment(resbuf, &integ_buf, integ_offset, | 1196 | if (xdr_buf_subsegment(resbuf, &integ_buf, integ_offset, |
1197 | integ_len)) | 1197 | integ_len)) |
1198 | BUG(); | 1198 | BUG(); |
1199 | if (resbuf->page_len == 0 | 1199 | if (resbuf->tail[0].iov_base == NULL) { |
1200 | && resbuf->head[0].iov_len + RPC_MAX_AUTH_SIZE | ||
1201 | < PAGE_SIZE) { | ||
1202 | BUG_ON(resbuf->tail[0].iov_len); | ||
1203 | /* Use head for everything */ | ||
1204 | resv = &resbuf->head[0]; | ||
1205 | } else if (resbuf->tail[0].iov_base == NULL) { | ||
1206 | if (resbuf->head[0].iov_len + RPC_MAX_AUTH_SIZE > PAGE_SIZE) | 1200 | if (resbuf->head[0].iov_len + RPC_MAX_AUTH_SIZE > PAGE_SIZE) |
1207 | goto out_err; | 1201 | goto out_err; |
1208 | resbuf->tail[0].iov_base = resbuf->head[0].iov_base | 1202 | resbuf->tail[0].iov_base = resbuf->head[0].iov_base |