aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2009-04-28 00:06:13 -0400
committerJens Axboe <jens.axboe@oracle.com>2009-04-28 02:14:51 -0400
commite138b4e08ef65771000fbe6d93d67e3960ff862b (patch)
tree2f7593bc1774bd6771dc29b8a522d681e9aa1719
parent467ca759fc83fc35cb7d15aec0d74c62cffc4481 (diff)
swim: clean up request completion paths
swim curiously tries to update request parameters before calling __blk_end_request() when __blk_end_request() will do it anyway and unnecessarily checks whether current_nr_sectors is zero right after fetching. Drop unnecessary stuff and use standard block layer mechanisms. [ Impact: cleanup ] Signed-off-by: Tejun Heo <tj@kernel.org> Cc: Laurent Vivier <Laurent@lvivier.info> Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
-rw-r--r--drivers/block/swim.c7
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/block/swim.c b/drivers/block/swim.c
index 6544a7b06bf0..97ef4266c4c7 100644
--- a/drivers/block/swim.c
+++ b/drivers/block/swim.c
@@ -535,10 +535,6 @@ static void redo_fd_request(struct request_queue *q)
535 __blk_end_request_cur(req, -EIO); 535 __blk_end_request_cur(req, -EIO);
536 continue; 536 continue;
537 } 537 }
538 if (req->current_nr_sectors == 0) {
539 __blk_end_request_cur(req, 0);
540 continue;
541 }
542 if (!fs->disk_in) { 538 if (!fs->disk_in) {
543 __blk_end_request_cur(req, -EIO); 539 __blk_end_request_cur(req, -EIO);
544 continue; 540 continue;
@@ -561,9 +557,6 @@ static void redo_fd_request(struct request_queue *q)
561 __blk_end_request_cur(req, -EIO); 557 __blk_end_request_cur(req, -EIO);
562 continue; 558 continue;
563 } 559 }
564 req->nr_sectors -= req->current_nr_sectors;
565 req->sector += req->current_nr_sectors;
566 req->buffer += req->current_nr_sectors * 512;
567 __blk_end_request_cur(req, 0); 560 __blk_end_request_cur(req, 0);
568 break; 561 break;
569 } 562 }