aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSage Weil <sage@newdream.net>2010-01-25 19:03:02 -0500
committerSage Weil <sage@newdream.net>2010-01-25 19:03:02 -0500
commit361be8601d78e488b5249032cc4e779b81d7928e (patch)
tree9a443ca3913854104e88620db70fbdf6fc7f1d3a
parent0d59ab81c3d3adf466c3fd37d7fb6d46b05d1fd4 (diff)
ceph: precede encoded ceph_pg_pool struct with version
Signed-off-by: Sage Weil <sage@newdream.net>
-rw-r--r--fs/ceph/ceph_fs.h2
-rw-r--r--fs/ceph/osdmap.c8
2 files changed, 8 insertions, 2 deletions
diff --git a/fs/ceph/ceph_fs.h b/fs/ceph/ceph_fs.h
index d8923fed8c2e..f3bfc3c4f6e6 100644
--- a/fs/ceph/ceph_fs.h
+++ b/fs/ceph/ceph_fs.h
@@ -38,7 +38,7 @@
38#define CEPH_OSD_PROTOCOL 8 /* cluster internal */ 38#define CEPH_OSD_PROTOCOL 8 /* cluster internal */
39#define CEPH_MDS_PROTOCOL 9 /* cluster internal */ 39#define CEPH_MDS_PROTOCOL 9 /* cluster internal */
40#define CEPH_MON_PROTOCOL 5 /* cluster internal */ 40#define CEPH_MON_PROTOCOL 5 /* cluster internal */
41#define CEPH_OSDC_PROTOCOL 22 /* server/client */ 41#define CEPH_OSDC_PROTOCOL 23 /* server/client */
42#define CEPH_MDSC_PROTOCOL 32 /* server/client */ 42#define CEPH_MDSC_PROTOCOL 32 /* server/client */
43#define CEPH_MONC_PROTOCOL 15 /* server/client */ 43#define CEPH_MONC_PROTOCOL 15 /* server/client */
44 44
diff --git a/fs/ceph/osdmap.c b/fs/ceph/osdmap.c
index 0dbd606e21c4..a143c51c2cfb 100644
--- a/fs/ceph/osdmap.c
+++ b/fs/ceph/osdmap.c
@@ -414,6 +414,7 @@ struct ceph_osdmap *osdmap_decode(void **p, void *end)
414 struct ceph_osdmap *map; 414 struct ceph_osdmap *map;
415 u16 version; 415 u16 version;
416 u32 len, max, i; 416 u32 len, max, i;
417 u8 ev;
417 int err = -EINVAL; 418 int err = -EINVAL;
418 void *start = *p; 419 void *start = *p;
419 420
@@ -441,10 +442,11 @@ struct ceph_osdmap *osdmap_decode(void **p, void *end)
441 } 442 }
442 ceph_decode_32_safe(p, end, max, bad); 443 ceph_decode_32_safe(p, end, max, bad);
443 while (max--) { 444 while (max--) {
444 ceph_decode_need(p, end, 4+sizeof(map->pg_pool->v), bad); 445 ceph_decode_need(p, end, 4+1+sizeof(map->pg_pool->v), bad);
445 i = ceph_decode_32(p); 446 i = ceph_decode_32(p);
446 if (i >= map->num_pools) 447 if (i >= map->num_pools)
447 goto bad; 448 goto bad;
449 ev = ceph_decode_8(p); /* encoding version */
448 ceph_decode_copy(p, &map->pg_pool[i].v, 450 ceph_decode_copy(p, &map->pg_pool[i].v,
449 sizeof(map->pg_pool->v)); 451 sizeof(map->pg_pool->v));
450 calc_pg_masks(&map->pg_pool[i]); 452 calc_pg_masks(&map->pg_pool[i]);
@@ -603,6 +605,8 @@ struct ceph_osdmap *osdmap_apply_incremental(void **p, void *end,
603 /* new_pool */ 605 /* new_pool */
604 ceph_decode_32_safe(p, end, len, bad); 606 ceph_decode_32_safe(p, end, len, bad);
605 while (len--) { 607 while (len--) {
608 __u8 ev;
609
606 ceph_decode_32_safe(p, end, pool, bad); 610 ceph_decode_32_safe(p, end, pool, bad);
607 if (pool >= map->num_pools) { 611 if (pool >= map->num_pools) {
608 void *pg_pool = kcalloc(pool + 1, 612 void *pg_pool = kcalloc(pool + 1,
@@ -618,6 +622,8 @@ struct ceph_osdmap *osdmap_apply_incremental(void **p, void *end,
618 map->pg_pool = pg_pool; 622 map->pg_pool = pg_pool;
619 map->num_pools = pool+1; 623 map->num_pools = pool+1;
620 } 624 }
625 ceph_decode_need(p, end, 1 + sizeof(map->pg_pool->v), bad);
626 ev = ceph_decode_8(p); /* encoding version */
621 ceph_decode_copy(p, &map->pg_pool[pool].v, 627 ceph_decode_copy(p, &map->pg_pool[pool].v,
622 sizeof(map->pg_pool->v)); 628 sizeof(map->pg_pool->v));
623 calc_pg_masks(&map->pg_pool[pool]); 629 calc_pg_masks(&map->pg_pool[pool]);