aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPatrick McHardy <kaber@trash.net>2006-09-20 15:11:12 -0400
committerDavid S. Miller <davem@sunset.davemloft.net>2006-09-22 18:20:19 -0400
commitfd5e3befa405ea64d4db6b393b821644bf963c57 (patch)
tree8e8519eb437b20a457c0c8897269216c1fa5622a
parent62fbe9c82b20197a4f9c54f7add5d368418ba277 (diff)
[NETFILTER]: PPTP conntrack: fix GRE keymap leak
When destroying the GRE expectations without having seen the GRE connection the keymap entry is not freed, leading to a memory leak and, in case of a following call within the same session, failure during expectation setup. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/ipv4/netfilter/ip_conntrack_helper_pptp.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/net/ipv4/netfilter/ip_conntrack_helper_pptp.c b/net/ipv4/netfilter/ip_conntrack_helper_pptp.c
index b0225b65ca35..98267b0d2a47 100644
--- a/net/ipv4/netfilter/ip_conntrack_helper_pptp.c
+++ b/net/ipv4/netfilter/ip_conntrack_helper_pptp.c
@@ -194,6 +194,7 @@ static void pptp_destroy_siblings(struct ip_conntrack *ct)
194{ 194{
195 struct ip_conntrack_tuple t; 195 struct ip_conntrack_tuple t;
196 196
197 ip_ct_gre_keymap_destroy(ct);
197 /* Since ct->sibling_list has literally rusted away in 2.6.11, 198 /* Since ct->sibling_list has literally rusted away in 2.6.11,
198 * we now need another way to find out about our sibling 199 * we now need another way to find out about our sibling
199 * contrack and expects... -HW */ 200 * contrack and expects... -HW */