aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Brownell <dbrownell@users.sourceforge.net>2008-10-16 01:02:46 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2008-10-16 14:21:38 -0400
commit673c0c00382ed807f09d94e806f3519ddeeb4f70 (patch)
tree005bccdee7f27660fd2c738fbe26635f019aae96
parent2bec19feabd53cba75e9dab0e79afbe868a37113 (diff)
spi: core and gpio expanders use subsys_init
Make the SPI external GPIO expander drivers register themselves at subsys_initcall() time when they're statically linked, and make the SPI core do its driver model initialization earlier so that's safe. SOC-integrated GPIOs are available starting very early -- often before initcalls start to run, or earily in arch_initcall() at latest -- so this improves consistency, letting more subsystems rely on GPIOs being usable by their own subsys_initcall() code. Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--drivers/gpio/max7301.c6
-rw-r--r--drivers/gpio/mcp23s08.c5
-rw-r--r--drivers/spi/spi.c2
3 files changed, 9 insertions, 4 deletions
diff --git a/drivers/gpio/max7301.c b/drivers/gpio/max7301.c
index 39c795ad8312..1b5ad97b9e5b 100644
--- a/drivers/gpio/max7301.c
+++ b/drivers/gpio/max7301.c
@@ -325,13 +325,15 @@ static int __init max7301_init(void)
325{ 325{
326 return spi_register_driver(&max7301_driver); 326 return spi_register_driver(&max7301_driver);
327} 327}
328/* register after spi postcore initcall and before
329 * subsys initcalls that may rely on these GPIOs
330 */
331subsys_initcall(max7301_init);
328 332
329static void __exit max7301_exit(void) 333static void __exit max7301_exit(void)
330{ 334{
331 spi_unregister_driver(&max7301_driver); 335 spi_unregister_driver(&max7301_driver);
332} 336}
333
334module_init(max7301_init);
335module_exit(max7301_exit); 337module_exit(max7301_exit);
336 338
337MODULE_AUTHOR("Juergen Beisert"); 339MODULE_AUTHOR("Juergen Beisert");
diff --git a/drivers/gpio/mcp23s08.c b/drivers/gpio/mcp23s08.c
index 8a1b405fefda..89c1d222e9d1 100644
--- a/drivers/gpio/mcp23s08.c
+++ b/drivers/gpio/mcp23s08.c
@@ -419,7 +419,10 @@ static int __init mcp23s08_init(void)
419{ 419{
420 return spi_register_driver(&mcp23s08_driver); 420 return spi_register_driver(&mcp23s08_driver);
421} 421}
422module_init(mcp23s08_init); 422/* register after spi postcore initcall and before
423 * subsys initcalls that may rely on these GPIOs
424 */
425subsys_initcall(mcp23s08_init);
423 426
424static void __exit mcp23s08_exit(void) 427static void __exit mcp23s08_exit(void)
425{ 428{
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 2de6b0e72f3f..3734dc9708e1 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -738,5 +738,5 @@ err0:
738 * driver registration) _could_ be dynamically linked (modular) ... costs 738 * driver registration) _could_ be dynamically linked (modular) ... costs
739 * include needing to have boardinfo data structures be much more public. 739 * include needing to have boardinfo data structures be much more public.
740 */ 740 */
741subsys_initcall(spi_init); 741postcore_initcall(spi_init);
742 742