diff options
author | Jiri Pirko <jpirko@redhat.com> | 2009-05-11 19:37:15 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-05-17 14:59:47 -0400 |
commit | 3a6d54c56326c29c5357655779cfe6cf36481b17 (patch) | |
tree | 1c2f47eecebe98b8501d884cf482a8b777171cd7 | |
parent | 8b3521eeb7598c3b10c7e14361a7974464527702 (diff) |
net: remove needless (now buggy) & from dev->dev_addr
Patch fixes issues with dev->dev_addr changing from array to pointer.
Hopefully there are no others.
Signed-off-by: Jiri Pirko <jpirko@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/bonding/bond_3ad.c | 5 | ||||
-rw-r--r-- | drivers/net/ibmveth.c | 4 | ||||
-rw-r--r-- | drivers/net/wireless/hostap/hostap_hw.c | 2 | ||||
-rw-r--r-- | drivers/net/wireless/ray_cs.c | 2 | ||||
-rw-r--r-- | net/ipv6/ip6_tunnel.c | 4 | ||||
-rw-r--r-- | net/tipc/eth_media.c | 2 |
6 files changed, 10 insertions, 9 deletions
diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c index 8c2e5ab51f08..06009dc50b19 100644 --- a/drivers/net/bonding/bond_3ad.c +++ b/drivers/net/bonding/bond_3ad.c | |||
@@ -1845,9 +1845,10 @@ static u16 aggregator_identifier; | |||
1845 | * Can be called only after the mac address of the bond is set. | 1845 | * Can be called only after the mac address of the bond is set. |
1846 | */ | 1846 | */ |
1847 | void bond_3ad_initialize(struct bonding *bond, u16 tick_resolution, int lacp_fast) | 1847 | void bond_3ad_initialize(struct bonding *bond, u16 tick_resolution, int lacp_fast) |
1848 | { | 1848 | { |
1849 | // check that the bond is not initialized yet | 1849 | // check that the bond is not initialized yet |
1850 | if (MAC_ADDRESS_COMPARE(&(BOND_AD_INFO(bond).system.sys_mac_addr), &(bond->dev->dev_addr))) { | 1850 | if (MAC_ADDRESS_COMPARE(&(BOND_AD_INFO(bond).system.sys_mac_addr), |
1851 | bond->dev->dev_addr)) { | ||
1851 | 1852 | ||
1852 | aggregator_identifier = 0; | 1853 | aggregator_identifier = 0; |
1853 | 1854 | ||
diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c index 7902e5e16a1a..53af71aceb8a 100644 --- a/drivers/net/ibmveth.c +++ b/drivers/net/ibmveth.c | |||
@@ -1374,8 +1374,8 @@ static void ibmveth_proc_unregister_driver(void) | |||
1374 | static int ibmveth_show(struct seq_file *seq, void *v) | 1374 | static int ibmveth_show(struct seq_file *seq, void *v) |
1375 | { | 1375 | { |
1376 | struct ibmveth_adapter *adapter = seq->private; | 1376 | struct ibmveth_adapter *adapter = seq->private; |
1377 | char *current_mac = ((char*) &adapter->netdev->dev_addr); | 1377 | char *current_mac = (char *) adapter->netdev->dev_addr; |
1378 | char *firmware_mac = ((char*) &adapter->mac_addr) ; | 1378 | char *firmware_mac = (char *) &adapter->mac_addr; |
1379 | 1379 | ||
1380 | seq_printf(seq, "%s %s\n\n", ibmveth_driver_string, ibmveth_driver_version); | 1380 | seq_printf(seq, "%s %s\n\n", ibmveth_driver_string, ibmveth_driver_version); |
1381 | 1381 | ||
diff --git a/drivers/net/wireless/hostap/hostap_hw.c b/drivers/net/wireless/hostap/hostap_hw.c index 3dad1cf8f241..ff9b5c882184 100644 --- a/drivers/net/wireless/hostap/hostap_hw.c +++ b/drivers/net/wireless/hostap/hostap_hw.c | |||
@@ -1423,7 +1423,7 @@ static int prism2_hw_init2(struct net_device *dev, int initial) | |||
1423 | prism2_check_sta_fw_version(local); | 1423 | prism2_check_sta_fw_version(local); |
1424 | 1424 | ||
1425 | if (hfa384x_get_rid(dev, HFA384X_RID_CNFOWNMACADDR, | 1425 | if (hfa384x_get_rid(dev, HFA384X_RID_CNFOWNMACADDR, |
1426 | &dev->dev_addr, 6, 1) < 0) { | 1426 | dev->dev_addr, 6, 1) < 0) { |
1427 | printk("%s: could not get own MAC address\n", | 1427 | printk("%s: could not get own MAC address\n", |
1428 | dev->name); | 1428 | dev->name); |
1429 | } | 1429 | } |
diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c index fa90d1d8d82e..22e71856aa24 100644 --- a/drivers/net/wireless/ray_cs.c +++ b/drivers/net/wireless/ray_cs.c | |||
@@ -892,7 +892,7 @@ static int ray_dev_init(struct net_device *dev) | |||
892 | #endif /* RAY_IMMEDIATE_INIT */ | 892 | #endif /* RAY_IMMEDIATE_INIT */ |
893 | 893 | ||
894 | /* copy mac and broadcast addresses to linux device */ | 894 | /* copy mac and broadcast addresses to linux device */ |
895 | memcpy(&dev->dev_addr, &local->sparm.b4.a_mac_addr, ADDRLEN); | 895 | memcpy(dev->dev_addr, &local->sparm.b4.a_mac_addr, ADDRLEN); |
896 | memset(dev->broadcast, 0xff, ETH_ALEN); | 896 | memset(dev->broadcast, 0xff, ETH_ALEN); |
897 | 897 | ||
898 | DEBUG(2, "ray_dev_init ending\n"); | 898 | DEBUG(2, "ray_dev_init ending\n"); |
diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c index d994c55a5b16..af256d47fd35 100644 --- a/net/ipv6/ip6_tunnel.c +++ b/net/ipv6/ip6_tunnel.c | |||
@@ -1100,8 +1100,8 @@ static void ip6_tnl_link_config(struct ip6_tnl *t) | |||
1100 | struct ip6_tnl_parm *p = &t->parms; | 1100 | struct ip6_tnl_parm *p = &t->parms; |
1101 | struct flowi *fl = &t->fl; | 1101 | struct flowi *fl = &t->fl; |
1102 | 1102 | ||
1103 | memcpy(&dev->dev_addr, &p->laddr, sizeof(struct in6_addr)); | 1103 | memcpy(dev->dev_addr, &p->laddr, sizeof(struct in6_addr)); |
1104 | memcpy(&dev->broadcast, &p->raddr, sizeof(struct in6_addr)); | 1104 | memcpy(dev->broadcast, &p->raddr, sizeof(struct in6_addr)); |
1105 | 1105 | ||
1106 | /* Set up flowi template */ | 1106 | /* Set up flowi template */ |
1107 | ipv6_addr_copy(&fl->fl6_src, &p->laddr); | 1107 | ipv6_addr_copy(&fl->fl6_src, &p->laddr); |
diff --git a/net/tipc/eth_media.c b/net/tipc/eth_media.c index f72ba774c246..524ba5696d4d 100644 --- a/net/tipc/eth_media.c +++ b/net/tipc/eth_media.c | |||
@@ -167,7 +167,7 @@ static int enable_bearer(struct tipc_bearer *tb_ptr) | |||
167 | tb_ptr->mtu = dev->mtu; | 167 | tb_ptr->mtu = dev->mtu; |
168 | tb_ptr->blocked = 0; | 168 | tb_ptr->blocked = 0; |
169 | tb_ptr->addr.type = htonl(TIPC_MEDIA_TYPE_ETH); | 169 | tb_ptr->addr.type = htonl(TIPC_MEDIA_TYPE_ETH); |
170 | memcpy(&tb_ptr->addr.dev_addr, &dev->dev_addr, ETH_ALEN); | 170 | memcpy(&tb_ptr->addr.dev_addr, dev->dev_addr, ETH_ALEN); |
171 | return 0; | 171 | return 0; |
172 | } | 172 | } |
173 | 173 | ||