diff options
author | Greg Kroah-Hartman <gregkh@suse.de> | 2007-09-12 18:06:57 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2007-10-12 17:51:02 -0400 |
commit | 19c38de88a80913351fcacefdb461cc0b585fa87 (patch) | |
tree | 17d2978ce27861926a0d9a3eb49471b9b736f968 | |
parent | 5901d0145c6b9e791bacd049eea11c9db9a3006e (diff) |
kobjects: fix up improper use of the kobject name field
A number of different drivers incorrect access the kobject name field
directly. This is not correct as the name might not be in the array.
Use the proper accessor function instead.
-rw-r--r-- | block/elevator.c | 2 | ||||
-rw-r--r-- | block/ll_rw_blk.c | 2 | ||||
-rw-r--r-- | drivers/acpi/bus.c | 2 | ||||
-rw-r--r-- | drivers/cpufreq/cpufreq.c | 2 | ||||
-rw-r--r-- | drivers/md/md.c | 3 | ||||
-rw-r--r-- | drivers/net/ibmveth.c | 2 | ||||
-rw-r--r-- | drivers/pci/setup-irq.c | 2 | ||||
-rw-r--r-- | fs/partitions/check.c | 12 | ||||
-rw-r--r-- | fs/sysfs/dir.c | 2 | ||||
-rw-r--r-- | net/bridge/br_sysfs_br.c | 2 |
10 files changed, 16 insertions, 15 deletions
diff --git a/block/elevator.c b/block/elevator.c index c6d153de9fd6..b9c518afe1f8 100644 --- a/block/elevator.c +++ b/block/elevator.c | |||
@@ -186,7 +186,7 @@ static elevator_t *elevator_alloc(struct request_queue *q, | |||
186 | eq->ops = &e->ops; | 186 | eq->ops = &e->ops; |
187 | eq->elevator_type = e; | 187 | eq->elevator_type = e; |
188 | kobject_init(&eq->kobj); | 188 | kobject_init(&eq->kobj); |
189 | snprintf(eq->kobj.name, KOBJ_NAME_LEN, "%s", "iosched"); | 189 | kobject_set_name(&eq->kobj, "%s", "iosched"); |
190 | eq->kobj.ktype = &elv_ktype; | 190 | eq->kobj.ktype = &elv_ktype; |
191 | mutex_init(&eq->sysfs_lock); | 191 | mutex_init(&eq->sysfs_lock); |
192 | 192 | ||
diff --git a/block/ll_rw_blk.c b/block/ll_rw_blk.c index cd9d2c5d91ae..d875673e76cd 100644 --- a/block/ll_rw_blk.c +++ b/block/ll_rw_blk.c | |||
@@ -1854,7 +1854,7 @@ struct request_queue *blk_alloc_queue_node(gfp_t gfp_mask, int node_id) | |||
1854 | 1854 | ||
1855 | init_timer(&q->unplug_timer); | 1855 | init_timer(&q->unplug_timer); |
1856 | 1856 | ||
1857 | snprintf(q->kobj.name, KOBJ_NAME_LEN, "%s", "queue"); | 1857 | kobject_set_name(&q->kobj, "%s", "queue"); |
1858 | q->kobj.ktype = &queue_ktype; | 1858 | q->kobj.ktype = &queue_ktype; |
1859 | kobject_init(&q->kobj); | 1859 | kobject_init(&q->kobj); |
1860 | 1860 | ||
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index feab124d8e05..cbfc81579c9a 100644 --- a/drivers/acpi/bus.c +++ b/drivers/acpi/bus.c | |||
@@ -194,7 +194,7 @@ int acpi_bus_set_power(acpi_handle handle, int state) | |||
194 | 194 | ||
195 | if (!device->flags.power_manageable) { | 195 | if (!device->flags.power_manageable) { |
196 | ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Device `[%s]' is not power manageable\n", | 196 | ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Device `[%s]' is not power manageable\n", |
197 | device->dev.kobj.name)); | 197 | kobject_name(&device->dev.kobj))); |
198 | return -ENODEV; | 198 | return -ENODEV; |
199 | } | 199 | } |
200 | /* | 200 | /* |
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 2f6a73c01b71..2ce3de5e84af 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c | |||
@@ -828,7 +828,7 @@ static int cpufreq_add_dev (struct sys_device * sys_dev) | |||
828 | /* prepare interface data */ | 828 | /* prepare interface data */ |
829 | policy->kobj.parent = &sys_dev->kobj; | 829 | policy->kobj.parent = &sys_dev->kobj; |
830 | policy->kobj.ktype = &ktype_cpufreq; | 830 | policy->kobj.ktype = &ktype_cpufreq; |
831 | strlcpy(policy->kobj.name, "cpufreq", KOBJ_NAME_LEN); | 831 | kobject_set_name(&policy->kobj, "cpufreq"); |
832 | 832 | ||
833 | ret = kobject_register(&policy->kobj); | 833 | ret = kobject_register(&policy->kobj); |
834 | if (ret) { | 834 | if (ret) { |
diff --git a/drivers/md/md.c b/drivers/md/md.c index e8f102ea9b03..acf1b81b47cb 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c | |||
@@ -3076,8 +3076,7 @@ static struct kobject *md_probe(dev_t dev, int *part, void *data) | |||
3076 | mddev->gendisk = disk; | 3076 | mddev->gendisk = disk; |
3077 | mutex_unlock(&disks_mutex); | 3077 | mutex_unlock(&disks_mutex); |
3078 | mddev->kobj.parent = &disk->kobj; | 3078 | mddev->kobj.parent = &disk->kobj; |
3079 | mddev->kobj.k_name = NULL; | 3079 | kobject_set_name(&mddev->kobj, "%s", "md"); |
3080 | snprintf(mddev->kobj.name, KOBJ_NAME_LEN, "%s", "md"); | ||
3081 | mddev->kobj.ktype = &md_ktype; | 3080 | mddev->kobj.ktype = &md_ktype; |
3082 | if (kobject_register(&mddev->kobj)) | 3081 | if (kobject_register(&mddev->kobj)) |
3083 | printk(KERN_WARNING "md: cannot register %s/md - name in use\n", | 3082 | printk(KERN_WARNING "md: cannot register %s/md - name in use\n", |
diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c index 4ac161e1ca12..7d7758f3ad8c 100644 --- a/drivers/net/ibmveth.c +++ b/drivers/net/ibmveth.c | |||
@@ -1183,7 +1183,7 @@ static int __devinit ibmveth_probe(struct vio_dev *dev, const struct vio_device_ | |||
1183 | pool_count[i], pool_size[i], | 1183 | pool_count[i], pool_size[i], |
1184 | pool_active[i]); | 1184 | pool_active[i]); |
1185 | kobj->parent = &dev->dev.kobj; | 1185 | kobj->parent = &dev->dev.kobj; |
1186 | sprintf(kobj->name, "pool%d", i); | 1186 | kobject_set_name(kobj, "pool%d", i); |
1187 | kobj->ktype = &ktype_veth_pool; | 1187 | kobj->ktype = &ktype_veth_pool; |
1188 | kobject_register(kobj); | 1188 | kobject_register(kobj); |
1189 | } | 1189 | } |
diff --git a/drivers/pci/setup-irq.c b/drivers/pci/setup-irq.c index 568f1877315c..05ca2ed9eb51 100644 --- a/drivers/pci/setup-irq.c +++ b/drivers/pci/setup-irq.c | |||
@@ -48,7 +48,7 @@ pdev_fixup_irq(struct pci_dev *dev, | |||
48 | dev->irq = irq; | 48 | dev->irq = irq; |
49 | 49 | ||
50 | pr_debug("PCI: fixup irq: (%s) got %d\n", | 50 | pr_debug("PCI: fixup irq: (%s) got %d\n", |
51 | dev->dev.kobj.name, dev->irq); | 51 | kobject_name(&dev->dev.kobj), dev->irq); |
52 | 52 | ||
53 | /* Always tell the device, so the driver knows what is | 53 | /* Always tell the device, so the driver knows what is |
54 | the real IRQ to use; the device does not use it. */ | 54 | the real IRQ to use; the device does not use it. */ |
diff --git a/fs/partitions/check.c b/fs/partitions/check.c index 783c57ec07d3..722e12e5acc7 100644 --- a/fs/partitions/check.c +++ b/fs/partitions/check.c | |||
@@ -381,10 +381,12 @@ void add_partition(struct gendisk *disk, int part, sector_t start, sector_t len, | |||
381 | p->partno = part; | 381 | p->partno = part; |
382 | p->policy = disk->policy; | 382 | p->policy = disk->policy; |
383 | 383 | ||
384 | if (isdigit(disk->kobj.name[strlen(disk->kobj.name)-1])) | 384 | if (isdigit(disk->kobj.k_name[strlen(disk->kobj.k_name)-1])) |
385 | snprintf(p->kobj.name,KOBJ_NAME_LEN,"%sp%d",disk->kobj.name,part); | 385 | kobject_set_name(&p->kobj, "%sp%d", |
386 | kobject_name(&disk->kobj), part); | ||
386 | else | 387 | else |
387 | snprintf(p->kobj.name,KOBJ_NAME_LEN,"%s%d",disk->kobj.name,part); | 388 | kobject_set_name(&p->kobj, "%s%d", |
389 | kobject_name(&disk->kobj),part); | ||
388 | p->kobj.parent = &disk->kobj; | 390 | p->kobj.parent = &disk->kobj; |
389 | p->kobj.ktype = &ktype_part; | 391 | p->kobj.ktype = &ktype_part; |
390 | kobject_init(&p->kobj); | 392 | kobject_init(&p->kobj); |
@@ -477,9 +479,9 @@ void register_disk(struct gendisk *disk) | |||
477 | struct hd_struct *p; | 479 | struct hd_struct *p; |
478 | int err; | 480 | int err; |
479 | 481 | ||
480 | strlcpy(disk->kobj.name,disk->disk_name,KOBJ_NAME_LEN); | 482 | kobject_set_name(&disk->kobj, "%s", disk->disk_name); |
481 | /* ewww... some of these buggers have / in name... */ | 483 | /* ewww... some of these buggers have / in name... */ |
482 | s = strchr(disk->kobj.name, '/'); | 484 | s = strchr(disk->kobj.k_name, '/'); |
483 | if (s) | 485 | if (s) |
484 | *s = '!'; | 486 | *s = '!'; |
485 | if ((err = kobject_add(&disk->kobj))) | 487 | if ((err = kobject_add(&disk->kobj))) |
diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c index 83e76b3813c9..ea33b660ae8a 100644 --- a/fs/sysfs/dir.c +++ b/fs/sysfs/dir.c | |||
@@ -1013,7 +1013,7 @@ again: | |||
1013 | goto again; | 1013 | goto again; |
1014 | } | 1014 | } |
1015 | 1015 | ||
1016 | new_dentry = lookup_one_len(kobj->name, new_parent, strlen(kobj->name)); | 1016 | new_dentry = lookup_one_len(kobject_name(kobj), new_parent, strlen(kobject_name(kobj))); |
1017 | if (IS_ERR(new_dentry)) { | 1017 | if (IS_ERR(new_dentry)) { |
1018 | error = PTR_ERR(new_dentry); | 1018 | error = PTR_ERR(new_dentry); |
1019 | goto out_unlock; | 1019 | goto out_unlock; |
diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c index c65f54e0e27f..3312e8f2abe4 100644 --- a/net/bridge/br_sysfs_br.c +++ b/net/bridge/br_sysfs_br.c | |||
@@ -435,7 +435,7 @@ int br_sysfs_addbr(struct net_device *dev) | |||
435 | err = kobject_register(&br->ifobj); | 435 | err = kobject_register(&br->ifobj); |
436 | if (err) { | 436 | if (err) { |
437 | pr_info("%s: can't add kobject (directory) %s/%s\n", | 437 | pr_info("%s: can't add kobject (directory) %s/%s\n", |
438 | __FUNCTION__, dev->name, br->ifobj.name); | 438 | __FUNCTION__, dev->name, kobject_name(&br->ifobj)); |
439 | goto out3; | 439 | goto out3; |
440 | } | 440 | } |
441 | return 0; | 441 | return 0; |