diff options
author | Bjorn Helgaas <bjorn.helgaas@hp.com> | 2009-03-24 18:50:09 -0400 |
---|---|---|
committer | Len Brown <len.brown@intel.com> | 2009-03-27 12:51:16 -0400 |
commit | 0e46517d9660ee6ae0a0c5d8a4e50451bc84d61d (patch) | |
tree | 1ccbd9b77ad53f9b8b5de562d5d2adab08f55b43 | |
parent | 84f810c33f695e020776ce66c903e0b41872f1b2 (diff) |
ACPI: call init_acpi_device_notify() explicitly rather than as initcall
This patch makes acpi_init() call init_acpi_device_notify() directly.
Previously, init_acpi_device_notify() was an arch_initcall (sequence 3),
so it was called before acpi_init() (a subsys_initcall at sequence 4).
init_acpi_device_notify() sets the platform_notify and
platform_notify_remove function pointers. These pointers
are not used until acpi_init() enumerates ACPI devices in
this path:
acpi_init()
acpi_scan_init()
acpi_bus_scan()
acpi_add_single_object()
acpi_device_register()
device_add()
<use platform_notify>
So it is sufficient to have acpi_init() call init_acpi_device_notify()
directly before it enumerates devices.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Len Brown <len.brown@intel.com>
-rw-r--r-- | drivers/acpi/bus.c | 1 | ||||
-rw-r--r-- | drivers/acpi/glue.c | 6 | ||||
-rw-r--r-- | drivers/acpi/internal.h | 1 |
3 files changed, 3 insertions, 5 deletions
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index f32cfd64c999..db9eca8d3cf2 100644 --- a/drivers/acpi/bus.c +++ b/drivers/acpi/bus.c | |||
@@ -855,6 +855,7 @@ static int __init acpi_init(void) | |||
855 | acpi_kobj = NULL; | 855 | acpi_kobj = NULL; |
856 | } | 856 | } |
857 | 857 | ||
858 | init_acpi_device_notify(); | ||
858 | result = acpi_bus_init(); | 859 | result = acpi_bus_init(); |
859 | 860 | ||
860 | if (!result) { | 861 | if (!result) { |
diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c index 5479b9f42513..8bd2c2a6884d 100644 --- a/drivers/acpi/glue.c +++ b/drivers/acpi/glue.c | |||
@@ -286,10 +286,8 @@ static int acpi_platform_notify_remove(struct device *dev) | |||
286 | return 0; | 286 | return 0; |
287 | } | 287 | } |
288 | 288 | ||
289 | static int __init init_acpi_device_notify(void) | 289 | int __init init_acpi_device_notify(void) |
290 | { | 290 | { |
291 | if (acpi_disabled) | ||
292 | return 0; | ||
293 | if (platform_notify || platform_notify_remove) { | 291 | if (platform_notify || platform_notify_remove) { |
294 | printk(KERN_ERR PREFIX "Can't use platform_notify\n"); | 292 | printk(KERN_ERR PREFIX "Can't use platform_notify\n"); |
295 | return 0; | 293 | return 0; |
@@ -298,5 +296,3 @@ static int __init init_acpi_device_notify(void) | |||
298 | platform_notify_remove = acpi_platform_notify_remove; | 296 | platform_notify_remove = acpi_platform_notify_remove; |
299 | return 0; | 297 | return 0; |
300 | } | 298 | } |
301 | |||
302 | arch_initcall(init_acpi_device_notify); | ||
diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h index 44b84021d84d..8a45dd8e03b5 100644 --- a/drivers/acpi/internal.h +++ b/drivers/acpi/internal.h | |||
@@ -1,5 +1,6 @@ | |||
1 | /* For use by Linux/ACPI infrastructure, not drivers */ | 1 | /* For use by Linux/ACPI infrastructure, not drivers */ |
2 | 2 | ||
3 | int init_acpi_device_notify(void); | ||
3 | int acpi_scan_init(void); | 4 | int acpi_scan_init(void); |
4 | int acpi_system_init(void); | 5 | int acpi_system_init(void); |
5 | 6 | ||