aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDave Martin <dave.martin@linaro.org>2011-02-08 06:09:52 -0500
committerRussell King <rmk+kernel@arm.linux.org.uk>2011-02-19 11:07:21 -0500
commit3ba6e69ad887f8a814267ed36fd4bfbddf8855a9 (patch)
treeaff91a8e58d1b3ac83a8dd37e8a9f325961add2a
parent917692f5f7ec63de3b093c825913d68e910db282 (diff)
ARM: 6653/1: bitops: Use BX instead of MOV PC,LR
The kernel doesn't officially need to interwork, but using BX wherever appropriate will help educate people into good assembler coding habits. BX is appropriate here because this code is predicated on __LINUX_ARM_ARCH__ >= 6 Signed-off-by: Dave Martin <dave.martin@linaro.org> Acked-by: Nicolas Pitre <nicolas.pitre@linaro.org> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
-rw-r--r--arch/arm/lib/bitops.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/arm/lib/bitops.h b/arch/arm/lib/bitops.h
index a9d9d152a751..10d868a5a481 100644
--- a/arch/arm/lib/bitops.h
+++ b/arch/arm/lib/bitops.h
@@ -12,7 +12,7 @@
12 strex r0, r2, [r1] 12 strex r0, r2, [r1]
13 cmp r0, #0 13 cmp r0, #0
14 bne 1b 14 bne 1b
15 mov pc, lr 15 bx lr
16 .endm 16 .endm
17 17
18 .macro testop, instr, store 18 .macro testop, instr, store
@@ -33,7 +33,7 @@
33 smp_dmb 33 smp_dmb
34 cmp r0, #0 34 cmp r0, #0
35 movne r0, #1 35 movne r0, #1
362: mov pc, lr 362: bx lr
37 .endm 37 .endm
38#else 38#else
39 .macro bitop, instr 39 .macro bitop, instr