diff options
author | Martin Josefsson <gandalf@wlug.westbo.se> | 2006-04-01 05:24:48 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2006-04-01 05:24:48 -0500 |
commit | e64a70be5175ac2c209fa742123a6ce845852e0e (patch) | |
tree | d02293d403fa6d0fdf82a4ea55244f328b37fde4 | |
parent | bcd1e830a5ac37d708647d492a1436a8a9babb07 (diff) |
[NETFILTER]: {ip,nf}_conntrack_netlink: fix expectation notifier unregistration
This patch fixes expectation notifier unregistration on module unload to
use ip_conntrack_expect_unregister_notifier(). This bug causes a soft
lockup at the first expectation created after a rmmod ; insmod of this
module.
Should go into -stable as well.
Signed-off-by: Martin Josefsson <gandalf@wlug.westbo.se>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/ipv4/netfilter/ip_conntrack_netlink.c | 2 | ||||
-rw-r--r-- | net/netfilter/nf_conntrack_netlink.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/net/ipv4/netfilter/ip_conntrack_netlink.c b/net/ipv4/netfilter/ip_conntrack_netlink.c index 9b6e19bae90f..01bd7cab9367 100644 --- a/net/ipv4/netfilter/ip_conntrack_netlink.c +++ b/net/ipv4/netfilter/ip_conntrack_netlink.c | |||
@@ -1658,7 +1658,7 @@ static void __exit ctnetlink_exit(void) | |||
1658 | printk("ctnetlink: unregistering from nfnetlink.\n"); | 1658 | printk("ctnetlink: unregistering from nfnetlink.\n"); |
1659 | 1659 | ||
1660 | #ifdef CONFIG_IP_NF_CONNTRACK_EVENTS | 1660 | #ifdef CONFIG_IP_NF_CONNTRACK_EVENTS |
1661 | ip_conntrack_unregister_notifier(&ctnl_notifier_exp); | 1661 | ip_conntrack_expect_unregister_notifier(&ctnl_notifier_exp); |
1662 | ip_conntrack_unregister_notifier(&ctnl_notifier); | 1662 | ip_conntrack_unregister_notifier(&ctnl_notifier); |
1663 | #endif | 1663 | #endif |
1664 | 1664 | ||
diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c index 3138ae79fa21..bd10eb944b65 100644 --- a/net/netfilter/nf_conntrack_netlink.c +++ b/net/netfilter/nf_conntrack_netlink.c | |||
@@ -1687,7 +1687,7 @@ static void __exit ctnetlink_exit(void) | |||
1687 | printk("ctnetlink: unregistering from nfnetlink.\n"); | 1687 | printk("ctnetlink: unregistering from nfnetlink.\n"); |
1688 | 1688 | ||
1689 | #ifdef CONFIG_NF_CONNTRACK_EVENTS | 1689 | #ifdef CONFIG_NF_CONNTRACK_EVENTS |
1690 | nf_conntrack_unregister_notifier(&ctnl_notifier_exp); | 1690 | nf_conntrack_expect_unregister_notifier(&ctnl_notifier_exp); |
1691 | nf_conntrack_unregister_notifier(&ctnl_notifier); | 1691 | nf_conntrack_unregister_notifier(&ctnl_notifier); |
1692 | #endif | 1692 | #endif |
1693 | 1693 | ||