NFSv4: Fix an Oops in nfs_do_expire_all_delegations

 If the loop errors, we need to exit.

 Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

1 files changed, 2 insertions, 4 deletions

diff --git a/fs/nfs/delegation.c b/fs/nfs/delegation.c
index 66cc720e3927..c6f07c1c71e6 100644
--- a/fs/nfs/delegation.c
+++ b/fs/nfs/delegation.c
@@ -236,7 +236,6 @@ int nfs_do_expire_all_delegations(void *ptr)
         struct nfs4_client *clp = ptr;
         struct nfs_delegation *delegation;
         struct inode *inode;
-        int err = 0;
 
         allow_signal(SIGKILL);
 restart:
@@ -250,10 +249,9 @@ restart:
                 if (inode == NULL)
                         continue;
                 spin_unlock(&clp->cl_lock);
-                err = nfs_inode_return_delegation(inode);
+                nfs_inode_return_delegation(inode);
                 iput(inode);
-                if (!err)
-                        goto restart;
+                goto restart;
         }
 out:
         spin_unlock(&clp->cl_lock);