diff options
author | Christoph Hellwig <hch@lst.de> | 2005-09-06 08:15:37 -0400 |
---|---|---|
committer | James Bottomley <jejb@mulgrave.(none)> | 2005-09-06 18:26:37 -0400 |
commit | fe1b2d544d71300f8e2d151c3c77a130d13a58be (patch) | |
tree | 770c8c9e857bb4d0bf7c96d831e35f91f2e11f9e | |
parent | c5478def7a3a2dba9ceda452c2aa3539514d30a9 (diff) |
[SCSI] unexport scsi_add_timer/scsi_delete_timer
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-rw-r--r-- | Documentation/scsi/scsi_mid_low_api.txt | 41 | ||||
-rw-r--r-- | drivers/scsi/scsi_error.c | 2 | ||||
-rw-r--r-- | drivers/scsi/scsi_priv.h | 3 | ||||
-rw-r--r-- | include/scsi/scsi_eh.h | 3 |
4 files changed, 3 insertions, 46 deletions
diff --git a/Documentation/scsi/scsi_mid_low_api.txt b/Documentation/scsi/scsi_mid_low_api.txt index 7536823c0cb1..44df89c9c049 100644 --- a/Documentation/scsi/scsi_mid_low_api.txt +++ b/Documentation/scsi/scsi_mid_low_api.txt | |||
@@ -373,13 +373,11 @@ Summary: | |||
373 | scsi_activate_tcq - turn on tag command queueing | 373 | scsi_activate_tcq - turn on tag command queueing |
374 | scsi_add_device - creates new scsi device (lu) instance | 374 | scsi_add_device - creates new scsi device (lu) instance |
375 | scsi_add_host - perform sysfs registration and SCSI bus scan. | 375 | scsi_add_host - perform sysfs registration and SCSI bus scan. |
376 | scsi_add_timer - (re-)start timer on a SCSI command. | ||
377 | scsi_adjust_queue_depth - change the queue depth on a SCSI device | 376 | scsi_adjust_queue_depth - change the queue depth on a SCSI device |
378 | scsi_assign_lock - replace default host_lock with given lock | 377 | scsi_assign_lock - replace default host_lock with given lock |
379 | scsi_bios_ptable - return copy of block device's partition table | 378 | scsi_bios_ptable - return copy of block device's partition table |
380 | scsi_block_requests - prevent further commands being queued to given host | 379 | scsi_block_requests - prevent further commands being queued to given host |
381 | scsi_deactivate_tcq - turn off tag command queueing | 380 | scsi_deactivate_tcq - turn off tag command queueing |
382 | scsi_delete_timer - cancel timer on a SCSI command. | ||
383 | scsi_host_alloc - return a new scsi_host instance whose refcount==1 | 381 | scsi_host_alloc - return a new scsi_host instance whose refcount==1 |
384 | scsi_host_get - increments Scsi_Host instance's refcount | 382 | scsi_host_get - increments Scsi_Host instance's refcount |
385 | scsi_host_put - decrements Scsi_Host instance's refcount (free if 0) | 383 | scsi_host_put - decrements Scsi_Host instance's refcount (free if 0) |
@@ -458,27 +456,6 @@ int scsi_add_host(struct Scsi_Host *shost, struct device * dev) | |||
458 | 456 | ||
459 | 457 | ||
460 | /** | 458 | /** |
461 | * scsi_add_timer - (re-)start timer on a SCSI command. | ||
462 | * @scmd: pointer to scsi command instance | ||
463 | * @timeout: duration of timeout in "jiffies" | ||
464 | * @complete: pointer to function to call if timeout expires | ||
465 | * | ||
466 | * Returns nothing | ||
467 | * | ||
468 | * Might block: no | ||
469 | * | ||
470 | * Notes: Each scsi command has its own timer, and as it is added | ||
471 | * to the queue, we set up the timer. When the command completes, | ||
472 | * we cancel the timer. An LLD can use this function to change | ||
473 | * the existing timeout value. | ||
474 | * | ||
475 | * Defined in: drivers/scsi/scsi_error.c | ||
476 | **/ | ||
477 | void scsi_add_timer(struct scsi_cmnd *scmd, int timeout, | ||
478 | void (*complete)(struct scsi_cmnd *)) | ||
479 | |||
480 | |||
481 | /** | ||
482 | * scsi_adjust_queue_depth - allow LLD to change queue depth on a SCSI device | 459 | * scsi_adjust_queue_depth - allow LLD to change queue depth on a SCSI device |
483 | * @sdev: pointer to SCSI device to change queue depth on | 460 | * @sdev: pointer to SCSI device to change queue depth on |
484 | * @tagged: 0 - no tagged queuing | 461 | * @tagged: 0 - no tagged queuing |
@@ -566,24 +543,6 @@ void scsi_deactivate_tcq(struct scsi_device *sdev, int depth) | |||
566 | 543 | ||
567 | 544 | ||
568 | /** | 545 | /** |
569 | * scsi_delete_timer - cancel timer on a SCSI command. | ||
570 | * @scmd: pointer to scsi command instance | ||
571 | * | ||
572 | * Returns 1 if able to cancel timer else 0 (i.e. too late or already | ||
573 | * cancelled). | ||
574 | * | ||
575 | * Might block: no [may in the future if it invokes del_timer_sync()] | ||
576 | * | ||
577 | * Notes: All commands issued by upper levels already have a timeout | ||
578 | * associated with them. An LLD can use this function to cancel the | ||
579 | * timer. | ||
580 | * | ||
581 | * Defined in: drivers/scsi/scsi_error.c | ||
582 | **/ | ||
583 | int scsi_delete_timer(struct scsi_cmnd *scmd) | ||
584 | |||
585 | |||
586 | /** | ||
587 | * scsi_host_alloc - create a scsi host adapter instance and perform basic | 546 | * scsi_host_alloc - create a scsi host adapter instance and perform basic |
588 | * initialization. | 547 | * initialization. |
589 | * @sht: pointer to scsi host template | 548 | * @sht: pointer to scsi host template |
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index ebe74ccb518a..ae28bcb79242 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c | |||
@@ -116,7 +116,6 @@ void scsi_add_timer(struct scsi_cmnd *scmd, int timeout, | |||
116 | 116 | ||
117 | add_timer(&scmd->eh_timeout); | 117 | add_timer(&scmd->eh_timeout); |
118 | } | 118 | } |
119 | EXPORT_SYMBOL(scsi_add_timer); | ||
120 | 119 | ||
121 | /** | 120 | /** |
122 | * scsi_delete_timer - Delete/cancel timer for a given function. | 121 | * scsi_delete_timer - Delete/cancel timer for a given function. |
@@ -144,7 +143,6 @@ int scsi_delete_timer(struct scsi_cmnd *scmd) | |||
144 | 143 | ||
145 | return rtn; | 144 | return rtn; |
146 | } | 145 | } |
147 | EXPORT_SYMBOL(scsi_delete_timer); | ||
148 | 146 | ||
149 | /** | 147 | /** |
150 | * scsi_times_out - Timeout function for normal scsi commands. | 148 | * scsi_times_out - Timeout function for normal scsi commands. |
diff --git a/drivers/scsi/scsi_priv.h b/drivers/scsi/scsi_priv.h index d30d7f4e63ec..ee6de1768e53 100644 --- a/drivers/scsi/scsi_priv.h +++ b/drivers/scsi/scsi_priv.h | |||
@@ -63,6 +63,9 @@ extern int __init scsi_init_devinfo(void); | |||
63 | extern void scsi_exit_devinfo(void); | 63 | extern void scsi_exit_devinfo(void); |
64 | 64 | ||
65 | /* scsi_error.c */ | 65 | /* scsi_error.c */ |
66 | extern void scsi_add_timer(struct scsi_cmnd *, int, | ||
67 | void (*)(struct scsi_cmnd *)); | ||
68 | extern int scsi_delete_timer(struct scsi_cmnd *); | ||
66 | extern void scsi_times_out(struct scsi_cmnd *cmd); | 69 | extern void scsi_times_out(struct scsi_cmnd *cmd); |
67 | extern int scsi_error_handler(void *host); | 70 | extern int scsi_error_handler(void *host); |
68 | extern int scsi_decide_disposition(struct scsi_cmnd *cmd); | 71 | extern int scsi_decide_disposition(struct scsi_cmnd *cmd); |
diff --git a/include/scsi/scsi_eh.h b/include/scsi/scsi_eh.h index 80557f879e3e..4b71095be681 100644 --- a/include/scsi/scsi_eh.h +++ b/include/scsi/scsi_eh.h | |||
@@ -27,9 +27,6 @@ struct scsi_sense_hdr { /* See SPC-3 section 4.5 */ | |||
27 | }; | 27 | }; |
28 | 28 | ||
29 | 29 | ||
30 | extern void scsi_add_timer(struct scsi_cmnd *, int, | ||
31 | void (*)(struct scsi_cmnd *)); | ||
32 | extern int scsi_delete_timer(struct scsi_cmnd *); | ||
33 | extern void scsi_report_bus_reset(struct Scsi_Host *, int); | 30 | extern void scsi_report_bus_reset(struct Scsi_Host *, int); |
34 | extern void scsi_report_device_reset(struct Scsi_Host *, int, int); | 31 | extern void scsi_report_device_reset(struct Scsi_Host *, int, int); |
35 | extern int scsi_block_when_processing_errors(struct scsi_device *); | 32 | extern int scsi_block_when_processing_errors(struct scsi_device *); |