aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJim Cromie <jim.cromie@gmail.com>2011-05-23 14:44:57 -0400
committerMichal Marek <mmarek@suse.cz>2011-05-24 10:07:07 -0400
commitca995cbf77f3df599b7e751c2d08d90787c65c45 (patch)
tree3004eea8ebd0caada01d4e012d95810249ea0b20
parentbdabc7a345db97b3839c2c3deef40023cf8017ef (diff)
export_report: use warn() to issue WARNING, so they go to stderr
Also count CONFIG_MODVERSIONS warnings, and print a NOTE at start of SECTION 2 if any were issued. Section 2 will be empty if the build is lacking this CONFIG_ item, and user may have missed the warnings, as they're off screen. Signed-off-by: Jim Cromie <jim.cromie@gmail.com> Signed-off-by: Michal Marek <mmarek@suse.cz>
-rw-r--r--scripts/export_report.pl8
1 files changed, 7 insertions, 1 deletions
diff --git a/scripts/export_report.pl b/scripts/export_report.pl
index 48398a19fbbc..8f79b701de87 100644
--- a/scripts/export_report.pl
+++ b/scripts/export_report.pl
@@ -102,6 +102,8 @@ close($module_symvers);
102# 102#
103# collect the usage count of each symbol. 103# collect the usage count of each symbol.
104# 104#
105my $modversion_warnings = 0;
106
105foreach my $thismod (@allcfiles) { 107foreach my $thismod (@allcfiles) {
106 my $module; 108 my $module;
107 109
@@ -132,7 +134,8 @@ foreach my $thismod (@allcfiles) {
132 } 134 }
133 } 135 }
134 if ($state != 2) { 136 if ($state != 2) {
135 print "WARNING:$thismod is not built with CONFIG_MODVERSION enabled\n"; 137 warn "WARNING:$thismod is not built with CONFIG_MODVERSIONS enabled\n";
138 $modversion_warnings++;
136 } 139 }
137 close($module); 140 close($module);
138} 141}
@@ -166,6 +169,9 @@ printf("SECTION 2:\n\tThis section reports export-symbol-usage of in-kernel
166modules. Each module lists the modules, and the symbols from that module that 169modules. Each module lists the modules, and the symbols from that module that
167it uses. Each listed symbol reports the number of modules using it\n"); 170it uses. Each listed symbol reports the number of modules using it\n");
168 171
172print "\nNOTE: Got $modversion_warnings CONFIG_MODVERSIONS warnings\n\n"
173 if $modversion_warnings;
174
169print "~"x80 , "\n"; 175print "~"x80 , "\n";
170for my $thismod (sort keys %MODULE) { 176for my $thismod (sort keys %MODULE) {
171 my $list = $MODULE{$thismod}; 177 my $list = $MODULE{$thismod};