diff options
author | Toshiyuki Okajima <toshi.okajima@jp.fujitsu.com> | 2009-06-08 12:41:35 -0400 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2009-06-08 12:41:35 -0400 |
commit | 9aee2286071c23c535fe9928eec1a26e0bcf256d (patch) | |
tree | e0518acaa75c1399ffcf67ca74a54d5a9488296b | |
parent | f8514083cd61daef12fba5ef883ad9352c450428 (diff) |
ext4: fix dx_map_entry to support 256k directory blocks
The dx_map_entry structure doesn't support over 64KB block size by
current usage of its member("offs"). Because "offs" treats an offset
of copies of the ext4_dir_entry_2 structure as is. This member size is
16 bits. But real offset for over 64KB(256KB) block size needs 18
bits. However, real offset keeps 4 byte boundary, so lower 2 bits is
not used.
Therefore, we do the following to fix this limitation:
For "store":
we divide the real offset by 4 and then store this result to "offs"
member.
For "use":
we multiply "offs" member by 4 and then use this result
as real offset.
Signed-off-by: Toshiyuki Okajima <toshi.okajima@jp.fujitsu.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
-rw-r--r-- | fs/ext4/namei.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index f2bc160463b7..07eb6649e4fa 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c | |||
@@ -749,7 +749,7 @@ static int dx_make_map(struct ext4_dir_entry_2 *de, unsigned blocksize, | |||
749 | ext4fs_dirhash(de->name, de->name_len, &h); | 749 | ext4fs_dirhash(de->name, de->name_len, &h); |
750 | map_tail--; | 750 | map_tail--; |
751 | map_tail->hash = h.hash; | 751 | map_tail->hash = h.hash; |
752 | map_tail->offs = (u16) ((char *) de - base); | 752 | map_tail->offs = ((char *) de - base)>>2; |
753 | map_tail->size = le16_to_cpu(de->rec_len); | 753 | map_tail->size = le16_to_cpu(de->rec_len); |
754 | count++; | 754 | count++; |
755 | cond_resched(); | 755 | cond_resched(); |
@@ -1147,7 +1147,8 @@ dx_move_dirents(char *from, char *to, struct dx_map_entry *map, int count, | |||
1147 | unsigned rec_len = 0; | 1147 | unsigned rec_len = 0; |
1148 | 1148 | ||
1149 | while (count--) { | 1149 | while (count--) { |
1150 | struct ext4_dir_entry_2 *de = (struct ext4_dir_entry_2 *) (from + map->offs); | 1150 | struct ext4_dir_entry_2 *de = (struct ext4_dir_entry_2 *) |
1151 | (from + (map->offs<<2)); | ||
1151 | rec_len = EXT4_DIR_REC_LEN(de->name_len); | 1152 | rec_len = EXT4_DIR_REC_LEN(de->name_len); |
1152 | memcpy (to, de, rec_len); | 1153 | memcpy (to, de, rec_len); |
1153 | ((struct ext4_dir_entry_2 *) to)->rec_len = | 1154 | ((struct ext4_dir_entry_2 *) to)->rec_len = |