aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYehuda Sadeh <yehuda@hq.newdream.net>2010-02-09 14:08:40 -0500
committerSage Weil <sage@newdream.net>2010-02-11 14:48:51 -0500
commit3d497d858ae6e5f23a28783030aecc69074e102d (patch)
tree43c69325be88a7a1ea3842d5f64a33d613fb710c
parent4af6b2257ee0eb8f4bf3b1dc8acb643c0e8a887f (diff)
ceph: fix truncation when not holding caps
A truncation should occur when either we have the specified caps for the file, or (in cases where we are not the only ones referencing the file) when it is mapped or when it is opened. The latter two cases were not handled. Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net> Signed-off-by: Sage Weil <sage@newdream.net>
-rw-r--r--fs/ceph/inode.c12
1 files changed, 10 insertions, 2 deletions
diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c
index a4f573ab232e..af85f2de2f7c 100644
--- a/fs/ceph/inode.c
+++ b/fs/ceph/inode.c
@@ -416,9 +416,17 @@ int ceph_fill_file_size(struct inode *inode, int issued,
416 dout("truncate_seq %u -> %u\n", 416 dout("truncate_seq %u -> %u\n",
417 ci->i_truncate_seq, truncate_seq); 417 ci->i_truncate_seq, truncate_seq);
418 ci->i_truncate_seq = truncate_seq; 418 ci->i_truncate_seq = truncate_seq;
419 if (issued & (CEPH_CAP_FILE_CACHE|CEPH_CAP_FILE_RD| 419 /*
420 * If we hold relevant caps, or in the case where we're
421 * not the only client referencing this file and we
422 * don't hold those caps, then we need to check whether
423 * the file is either opened or mmaped
424 */
425 if ((issued & (CEPH_CAP_FILE_CACHE|CEPH_CAP_FILE_RD|
420 CEPH_CAP_FILE_WR|CEPH_CAP_FILE_BUFFER| 426 CEPH_CAP_FILE_WR|CEPH_CAP_FILE_BUFFER|
421 CEPH_CAP_FILE_EXCL)) { 427 CEPH_CAP_FILE_EXCL)) ||
428 mapping_mapped(inode->i_mapping) ||
429 __ceph_caps_file_wanted(ci)) {
422 ci->i_truncate_pending++; 430 ci->i_truncate_pending++;
423 queue_trunc = 1; 431 queue_trunc = 1;
424 } 432 }