diff options
author | Harvey Harrison <harvey.harrison@gmail.com> | 2008-02-13 20:08:16 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-03-04 17:47:06 -0500 |
commit | 3634634edd49c115da931998b9540bcc17665b05 (patch) | |
tree | 1bd626e95866cf67e190d209d8525d3287d31b81 | |
parent | c1fe539a7e031302af1d121163e7ce68e679ba8c (diff) |
debugfs: fix sparse warnings
extern does not belong in C files, move declaration to linux/debugfs.h
fs/debugfs/file.c:42:30: warning: symbol 'debugfs_file_operations' was not declared. Should it be static?
fs/debugfs/file.c:54:31: warning: symbol 'debugfs_link_operations' was not declared. Should it be static?
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r-- | fs/debugfs/inode.c | 4 | ||||
-rw-r--r-- | include/linux/debugfs.h | 5 |
2 files changed, 5 insertions, 4 deletions
diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c index d26e2826ba5b..e9602d85c11d 100644 --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c | |||
@@ -29,10 +29,6 @@ | |||
29 | 29 | ||
30 | #define DEBUGFS_MAGIC 0x64626720 | 30 | #define DEBUGFS_MAGIC 0x64626720 |
31 | 31 | ||
32 | /* declared over in file.c */ | ||
33 | extern struct file_operations debugfs_file_operations; | ||
34 | extern struct inode_operations debugfs_link_operations; | ||
35 | |||
36 | static struct vfsmount *debugfs_mount; | 32 | static struct vfsmount *debugfs_mount; |
37 | static int debugfs_mount_count; | 33 | static int debugfs_mount_count; |
38 | 34 | ||
diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h index f592d6de3b97..7266124361b4 100644 --- a/include/linux/debugfs.h +++ b/include/linux/debugfs.h | |||
@@ -27,6 +27,11 @@ struct debugfs_blob_wrapper { | |||
27 | }; | 27 | }; |
28 | 28 | ||
29 | #if defined(CONFIG_DEBUG_FS) | 29 | #if defined(CONFIG_DEBUG_FS) |
30 | |||
31 | /* declared over in file.c */ | ||
32 | extern const struct file_operations debugfs_file_operations; | ||
33 | extern const struct inode_operations debugfs_link_operations; | ||
34 | |||
30 | struct dentry *debugfs_create_file(const char *name, mode_t mode, | 35 | struct dentry *debugfs_create_file(const char *name, mode_t mode, |
31 | struct dentry *parent, void *data, | 36 | struct dentry *parent, void *data, |
32 | const struct file_operations *fops); | 37 | const struct file_operations *fops); |