aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBartlomiej Zolnierkiewicz <bzolnier@gmail.com>2005-11-19 16:17:55 -0500
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>2005-11-19 16:17:55 -0500
commite07bc7096424b977e53a16d72ec02645389107ba (patch)
treed415e926d3a1b5f0e280464e91db239af0adbe59
parentc0bc113373d94ebd89d0d024421df8aac60ed08a (diff)
[PATCH] ide: remove dead code from flagged_taskfile()
flagged_taskfile() is called from execute_drive_cmd() (the only user) only if args->tf_out_flags.all != 0. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
-rw-r--r--drivers/ide/ide-taskfile.c12
-rw-r--r--include/linux/hdreg.h6
2 files changed, 7 insertions, 11 deletions
diff --git a/drivers/ide/ide-taskfile.c b/drivers/ide/ide-taskfile.c
index b3c32c5fef35..62ebefd6394a 100644
--- a/drivers/ide/ide-taskfile.c
+++ b/drivers/ide/ide-taskfile.c
@@ -773,19 +773,13 @@ ide_startstop_t flagged_taskfile (ide_drive_t *drive, ide_task_t *task)
773 } 773 }
774 774
775 /* 775 /*
776 * (ks) Check taskfile in/out flags. 776 * (ks) Check taskfile in flags.
777 * If set, then execute as it is defined. 777 * If set, then execute as it is defined.
778 * If not set, then define default settings. 778 * If not set, then define default settings.
779 * The default values are: 779 * The default values are:
780 * write and read all taskfile registers (except data) 780 * read all taskfile registers (except data)
781 * write and read the hob registers (sector,nsector,lcyl,hcyl) 781 * read the hob registers (sector, nsector, lcyl, hcyl)
782 */ 782 */
783 if (task->tf_out_flags.all == 0) {
784 task->tf_out_flags.all = IDE_TASKFILE_STD_OUT_FLAGS;
785 if (drive->addressing == 1)
786 task->tf_out_flags.all |= (IDE_HOB_STD_OUT_FLAGS << 8);
787 }
788
789 if (task->tf_in_flags.all == 0) { 783 if (task->tf_in_flags.all == 0) {
790 task->tf_in_flags.all = IDE_TASKFILE_STD_IN_FLAGS; 784 task->tf_in_flags.all = IDE_TASKFILE_STD_IN_FLAGS;
791 if (drive->addressing == 1) 785 if (drive->addressing == 1)
diff --git a/include/linux/hdreg.h b/include/linux/hdreg.h
index b5d660089de4..2b54eac738ea 100644
--- a/include/linux/hdreg.h
+++ b/include/linux/hdreg.h
@@ -80,10 +80,12 @@
80/* 80/*
81 * Define standard taskfile in/out register 81 * Define standard taskfile in/out register
82 */ 82 */
83#define IDE_TASKFILE_STD_OUT_FLAGS 0xFE
84#define IDE_TASKFILE_STD_IN_FLAGS 0xFE 83#define IDE_TASKFILE_STD_IN_FLAGS 0xFE
85#define IDE_HOB_STD_OUT_FLAGS 0x3C
86#define IDE_HOB_STD_IN_FLAGS 0x3C 84#define IDE_HOB_STD_IN_FLAGS 0x3C
85#ifndef __KERNEL__
86#define IDE_TASKFILE_STD_OUT_FLAGS 0xFE
87#define IDE_HOB_STD_OUT_FLAGS 0x3C
88#endif
87 89
88typedef unsigned char task_ioreg_t; 90typedef unsigned char task_ioreg_t;
89typedef unsigned long sata_ioreg_t; 91typedef unsigned long sata_ioreg_t;