diff options
author | Patrick McHardy <kaber@trash.net> | 2008-01-21 03:13:19 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 18:08:21 -0500 |
commit | 645a1e39e4e3e84a275c5e4a7c8049041146f9b5 (patch) | |
tree | 51cfe70dea020466ba67aeb5966a36e9b0f29ddc | |
parent | c6ee877f2e4c4d44c934528b4cec6c8d7f54d3ad (diff) |
[NET_SCHED]: sch_ingress: move dependencies to Kconfig
Instead of complaining at scheduler initialization time, check the
dependencies in Kconfig.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Acked-by: Jamal Hadi Salim <hadi@cyberus.ca>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/sched/Kconfig | 1 | ||||
-rw-r--r-- | net/sched/sch_ingress.c | 11 |
2 files changed, 2 insertions, 10 deletions
diff --git a/net/sched/Kconfig b/net/sched/Kconfig index f5ab54b1edd3..554248e0fc4c 100644 --- a/net/sched/Kconfig +++ b/net/sched/Kconfig | |||
@@ -198,6 +198,7 @@ config NET_SCH_NETEM | |||
198 | 198 | ||
199 | config NET_SCH_INGRESS | 199 | config NET_SCH_INGRESS |
200 | tristate "Ingress Qdisc" | 200 | tristate "Ingress Qdisc" |
201 | depends on NET_CLS_ACT || NETFILTER | ||
201 | ---help--- | 202 | ---help--- |
202 | Say Y here if you want to use classifiers for incoming packets. | 203 | Say Y here if you want to use classifiers for incoming packets. |
203 | If unsure, say Y. | 204 | If unsure, say Y. |
diff --git a/net/sched/sch_ingress.c b/net/sched/sch_ingress.c index c69e7bc7fb6c..b30ca01bdc04 100644 --- a/net/sched/sch_ingress.c +++ b/net/sched/sch_ingress.c | |||
@@ -162,19 +162,10 @@ static struct nf_hook_ops ing_ops[] __read_mostly = { | |||
162 | 162 | ||
163 | static int ingress_init(struct Qdisc *sch, struct rtattr *opt) | 163 | static int ingress_init(struct Qdisc *sch, struct rtattr *opt) |
164 | { | 164 | { |
165 | /* Make sure either netfilter or preferably CLS_ACT is | ||
166 | * compiled in */ | ||
167 | #ifndef CONFIG_NET_CLS_ACT | 165 | #ifndef CONFIG_NET_CLS_ACT |
168 | #ifndef CONFIG_NETFILTER | 166 | #ifdef CONFIG_NETFILTER |
169 | printk("You MUST compile classifier actions into the kernel\n"); | ||
170 | return -EINVAL; | ||
171 | #else | ||
172 | printk("Ingress scheduler: Classifier actions prefered over netfilter\n"); | 167 | printk("Ingress scheduler: Classifier actions prefered over netfilter\n"); |
173 | #endif | ||
174 | #endif | ||
175 | 168 | ||
176 | #ifndef CONFIG_NET_CLS_ACT | ||
177 | #ifdef CONFIG_NETFILTER | ||
178 | if (!nf_registered) { | 169 | if (!nf_registered) { |
179 | if (nf_register_hooks(ing_ops, ARRAY_SIZE(ing_ops)) < 0) { | 170 | if (nf_register_hooks(ing_ops, ARRAY_SIZE(ing_ops)) < 0) { |
180 | printk("ingress qdisc registration error \n"); | 171 | printk("ingress qdisc registration error \n"); |