diff options
author | Kashyap, Desai <kashyap.desai@lsi.com> | 2010-06-17 03:55:13 -0400 |
---|---|---|
committer | James Bottomley <James.Bottomley@suse.de> | 2010-07-27 13:02:06 -0400 |
commit | ab6ce92541ea24c6a92be8498d7d1b26c14ec62d (patch) | |
tree | f56c00fede2575053251c402dad1583b63b26822 | |
parent | 593d5720745658a4a973952fb74f6d863c531e97 (diff) |
[SCSI] mpt2sas: Fix to use sas device list instead of enclosure list for _transpor_get_enclosure_identifier.
Enclosure_identifier not being returned by mpt2sas
The driver exports callback function to the sas transport layer
for obtaining the enclosure logical id. This function is called
_transport_get_enclosure_identifier. The driver was searching
the wrong list for the enclosure_identifier. The driver should be
searching the sas device list instead of enclosure list. The
sas address that is passed to the driver is for the end device, not
enclosure.
Signed-off-by: Kashyap Desai <kashyap.desai@lsi.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
-rw-r--r-- | drivers/scsi/mpt2sas/mpt2sas_transport.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/drivers/scsi/mpt2sas/mpt2sas_transport.c b/drivers/scsi/mpt2sas/mpt2sas_transport.c index 2727c3b65104..778e149f9637 100644 --- a/drivers/scsi/mpt2sas/mpt2sas_transport.c +++ b/drivers/scsi/mpt2sas/mpt2sas_transport.c | |||
@@ -1007,18 +1007,18 @@ static int | |||
1007 | _transport_get_enclosure_identifier(struct sas_rphy *rphy, u64 *identifier) | 1007 | _transport_get_enclosure_identifier(struct sas_rphy *rphy, u64 *identifier) |
1008 | { | 1008 | { |
1009 | struct MPT2SAS_ADAPTER *ioc = rphy_to_ioc(rphy); | 1009 | struct MPT2SAS_ADAPTER *ioc = rphy_to_ioc(rphy); |
1010 | struct _sas_node *sas_expander; | 1010 | struct _sas_device *sas_device; |
1011 | unsigned long flags; | 1011 | unsigned long flags; |
1012 | 1012 | ||
1013 | spin_lock_irqsave(&ioc->sas_node_lock, flags); | 1013 | spin_lock_irqsave(&ioc->sas_device_lock, flags); |
1014 | sas_expander = mpt2sas_scsih_expander_find_by_sas_address(ioc, | 1014 | sas_device = mpt2sas_scsih_sas_device_find_by_sas_address(ioc, |
1015 | rphy->identify.sas_address); | 1015 | rphy->identify.sas_address); |
1016 | spin_unlock_irqrestore(&ioc->sas_node_lock, flags); | 1016 | spin_unlock_irqrestore(&ioc->sas_device_lock, flags); |
1017 | 1017 | ||
1018 | if (!sas_expander) | 1018 | if (!sas_device) |
1019 | return -ENXIO; | 1019 | return -ENXIO; |
1020 | 1020 | ||
1021 | *identifier = sas_expander->enclosure_logical_id; | 1021 | *identifier = sas_device->enclosure_logical_id; |
1022 | return 0; | 1022 | return 0; |
1023 | } | 1023 | } |
1024 | 1024 | ||