diff options
author | Jeff Garzik <jeff@garzik.org> | 2007-10-19 01:56:02 -0400 |
---|---|---|
committer | Jeff Garzik <jeff@garzik.org> | 2007-10-23 19:53:15 -0400 |
commit | f230d1010ad0dcd71d9ca8ea6864afac49c5aa9b (patch) | |
tree | 6bb5e61167c520727724c9ad0297f3bcd743151b | |
parent | 3f2e40df0e1d7694224c3083b0bebd129039a40a (diff) |
[PARPORT] Kill useful 'irq' arg from parport_{generic_irq,ieee1284_interrupt}
parport_ieee1284_interrupt() was not using its first arg at all.
Delete.
parport_generic_irq()'s second arg makes its first arg completely
redundant. Delete, and use port->irq in the one place where we actually
need it.
Also, s/__inline__/inline/ to make the code look nicer.
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
-rw-r--r-- | drivers/parport/ieee1284.c | 2 | ||||
-rw-r--r-- | drivers/parport/parport_mfc3.c | 2 | ||||
-rw-r--r-- | drivers/parport/share.c | 2 | ||||
-rw-r--r-- | drivers/usb/misc/uss720.c | 4 | ||||
-rw-r--r-- | include/linux/parport.h | 8 |
5 files changed, 9 insertions, 9 deletions
diff --git a/drivers/parport/ieee1284.c b/drivers/parport/ieee1284.c index 5accaa7bde31..54a6ef72906e 100644 --- a/drivers/parport/ieee1284.c +++ b/drivers/parport/ieee1284.c | |||
@@ -571,7 +571,7 @@ static int parport_ieee1284_ack_data_avail (struct parport *port) | |||
571 | #endif /* IEEE1284 support */ | 571 | #endif /* IEEE1284 support */ |
572 | 572 | ||
573 | /* Handle an interrupt. */ | 573 | /* Handle an interrupt. */ |
574 | void parport_ieee1284_interrupt (int which, void *handle) | 574 | void parport_ieee1284_interrupt (void *handle) |
575 | { | 575 | { |
576 | struct parport *port = handle; | 576 | struct parport *port = handle; |
577 | parport_ieee1284_wakeup (port); | 577 | parport_ieee1284_wakeup (port); |
diff --git a/drivers/parport/parport_mfc3.c b/drivers/parport/parport_mfc3.c index 77726fc49766..6dec9ba5ed28 100644 --- a/drivers/parport/parport_mfc3.c +++ b/drivers/parport/parport_mfc3.c | |||
@@ -219,7 +219,7 @@ static irqreturn_t mfc3_interrupt(int irq, void *dev_id) | |||
219 | if (this_port[i] != NULL) | 219 | if (this_port[i] != NULL) |
220 | if (pia(this_port[i])->crb & 128) { /* Board caused interrupt */ | 220 | if (pia(this_port[i])->crb & 128) { /* Board caused interrupt */ |
221 | dummy = pia(this_port[i])->pprb; /* clear irq bit */ | 221 | dummy = pia(this_port[i])->pprb; /* clear irq bit */ |
222 | parport_generic_irq(irq, this_port[i]); | 222 | parport_generic_irq(this_port[i]); |
223 | } | 223 | } |
224 | return IRQ_HANDLED; | 224 | return IRQ_HANDLED; |
225 | } | 225 | } |
diff --git a/drivers/parport/share.c b/drivers/parport/share.c index 414c52a5883a..d0b353cf14ac 100644 --- a/drivers/parport/share.c +++ b/drivers/parport/share.c | |||
@@ -999,7 +999,7 @@ irqreturn_t parport_irq_handler(int irq, void *dev_id) | |||
999 | { | 999 | { |
1000 | struct parport *port = dev_id; | 1000 | struct parport *port = dev_id; |
1001 | 1001 | ||
1002 | parport_generic_irq(irq, port); | 1002 | parport_generic_irq(port); |
1003 | 1003 | ||
1004 | return IRQ_HANDLED; | 1004 | return IRQ_HANDLED; |
1005 | } | 1005 | } |
diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c index 2734fe2b9c43..f1255b0a182d 100644 --- a/drivers/usb/misc/uss720.c +++ b/drivers/usb/misc/uss720.c | |||
@@ -128,7 +128,7 @@ static void async_complete(struct urb *urb) | |||
128 | #endif | 128 | #endif |
129 | /* if nAck interrupts are enabled and we have an interrupt, call the interrupt procedure */ | 129 | /* if nAck interrupts are enabled and we have an interrupt, call the interrupt procedure */ |
130 | if (rq->reg[2] & rq->reg[1] & 0x10 && pp) | 130 | if (rq->reg[2] & rq->reg[1] & 0x10 && pp) |
131 | parport_generic_irq(0, pp); | 131 | parport_generic_irq(pp); |
132 | } | 132 | } |
133 | complete(&rq->compl); | 133 | complete(&rq->compl); |
134 | kref_put(&rq->ref_count, destroy_async); | 134 | kref_put(&rq->ref_count, destroy_async); |
@@ -337,7 +337,7 @@ static int uss720_irq(int usbstatus, void *buffer, int len, void *dev_id) | |||
337 | memcpy(priv->reg, buffer, 4); | 337 | memcpy(priv->reg, buffer, 4); |
338 | /* if nAck interrupts are enabled and we have an interrupt, call the interrupt procedure */ | 338 | /* if nAck interrupts are enabled and we have an interrupt, call the interrupt procedure */ |
339 | if (priv->reg[2] & priv->reg[1] & 0x10) | 339 | if (priv->reg[2] & priv->reg[1] & 0x10) |
340 | parport_generic_irq(0, pp); | 340 | parport_generic_irq(pp); |
341 | return 1; | 341 | return 1; |
342 | } | 342 | } |
343 | #endif | 343 | #endif |
diff --git a/include/linux/parport.h b/include/linux/parport.h index 66026eab10c7..557c37de1f38 100644 --- a/include/linux/parport.h +++ b/include/linux/parport.h | |||
@@ -465,7 +465,7 @@ static __inline__ int parport_yield_blocking(struct pardevice *dev) | |||
465 | #define PARPORT_FLAG_EXCL (1<<1) /* EXCL driver registered. */ | 465 | #define PARPORT_FLAG_EXCL (1<<1) /* EXCL driver registered. */ |
466 | 466 | ||
467 | /* IEEE1284 functions */ | 467 | /* IEEE1284 functions */ |
468 | extern void parport_ieee1284_interrupt (int, void *); | 468 | extern void parport_ieee1284_interrupt (void *); |
469 | extern int parport_negotiate (struct parport *, int mode); | 469 | extern int parport_negotiate (struct parport *, int mode); |
470 | extern ssize_t parport_write (struct parport *, const void *buf, size_t len); | 470 | extern ssize_t parport_write (struct parport *, const void *buf, size_t len); |
471 | extern ssize_t parport_read (struct parport *, void *buf, size_t len); | 471 | extern ssize_t parport_read (struct parport *, void *buf, size_t len); |
@@ -518,12 +518,12 @@ extern void parport_daisy_deselect_all (struct parport *port); | |||
518 | extern int parport_daisy_select (struct parport *port, int daisy, int mode); | 518 | extern int parport_daisy_select (struct parport *port, int daisy, int mode); |
519 | 519 | ||
520 | /* Lowlevel drivers _can_ call this support function to handle irqs. */ | 520 | /* Lowlevel drivers _can_ call this support function to handle irqs. */ |
521 | static inline void parport_generic_irq(int irq, struct parport *port) | 521 | static inline void parport_generic_irq(struct parport *port) |
522 | { | 522 | { |
523 | parport_ieee1284_interrupt (irq, port); | 523 | parport_ieee1284_interrupt (port); |
524 | read_lock(&port->cad_lock); | 524 | read_lock(&port->cad_lock); |
525 | if (port->cad && port->cad->irq_func) | 525 | if (port->cad && port->cad->irq_func) |
526 | port->cad->irq_func(irq, port->cad->private); | 526 | port->cad->irq_func(port->irq, port->cad->private); |
527 | read_unlock(&port->cad_lock); | 527 | read_unlock(&port->cad_lock); |
528 | } | 528 | } |
529 | 529 | ||